Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12.0][REF] sale_triple_discount: subtotal computation #1495

Conversation

SimoRubi
Copy link
Member

@SimoRubi SimoRubi commented Mar 3, 2021

Depends on OCA/account-invoicing#876.
Use the new mixin for triple discount computation

@SimoRubi
Copy link
Member Author

SimoRubi commented Mar 4, 2021

This module currently erases all the data in discount2, discount3 and discounting_type due to the above issue in Odoo

@rco-odoo
Copy link

rco-odoo commented Dec 2, 2021

This module currently erases all the data in discount2, discount3 and discounting_type due to the above issue in Odoo

I just had a look at the runbot build, and the logfile shows the error

TypeError: Model 'sale.order.line' inherits from non-existing model 'line.triple_discount.mixin'.

In other words, the code of the mixin model is not present in this branch.

Isn't it what is causing the data loss with this branch?
Make sure you combine both branches in order to test an upgrade.

@SimoRubi
Copy link
Member Author

SimoRubi commented Mar 1, 2022

In other words, the code of the mixin model is not present in this branch.

Isn't it what is causing the data loss with this branch? Make sure you combine both branches in order to test an upgrade.

Thanks for having a look, the erased data issue can't be reproduced in runbot because it requires to coordinate code changes and module updates, so the runbot's build results are not the problem right now, they will simply fail until the dependency is merged.

I have pointed out the steps to reproduce the erased data issue in a more abstract fashion in odoo/odoo#67168.

@SimoRubi SimoRubi force-pushed the 12.0-fix-sale_triple_discount-subtotal_computation branch from e41a735 to 1230219 Compare March 8, 2022 13:17
@github-actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Mar 19, 2023
@github-actions github-actions bot closed this Apr 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants