[ADD] sale_packaging_price: New module to assign a package price. #221

sergio-teruel · 2015-10-08T11:07:05Z

This module was written to extends the functionality of sale workflow and allow you to assign a selling price of a complete package.
This price is split for having the price unit according the number of pieces that fits in that packaging, so there can be rounding issues to get the exact price that are warned if happens.

rafaelbn · 2015-10-08T15:29:00Z

I cannot test it, something wrong in runbot. Please could you review? Thanks

pedrobaeza · 2015-10-09T00:04:45Z

sale_packaging_price/README.rst

+
+To use this module, you need to:
+
+* go to warehause config and check 'Use packages: pallets, boxes, ...' and


s/warehause/warehouse

This should be on Configuration section

pedrobaeza · 2015-10-09T00:06:41Z

Remove sale_packaging_price/i18n/.gitkeep

pedrobaeza · 2015-10-09T00:08:05Z

sale_packaging_price/views/sale_packaging_price_menu.xml

+			  action="action_product_packaging_form"
+              parent="base.menu_product" sequence="99" />
+</data>
+</openerp>		


Remove extra spaces and put a line feed

pedrobaeza · 2015-10-09T00:11:15Z

You need to add product_packaging field to the form view.

pedrobaeza · 2015-10-09T00:12:54Z

sale_packaging_price/models/sale_stock.py

@@ -0,0 +1,30 @@
+# -*- coding: utf-8 -*-


Why name it sale_stock.py instead sale_order.py?

I rewrite function product_packaging_change that is located into sale_stock module in sale_stock.py file

Upstream is wrong then: https://www.odoo.com/documentation/8.0/reference/guidelines.html

No, it's not wrong. You should rename it to sale_order (model name, not module name).

Quoting from there:

File naming: [...]
models/< inherited_main_model >.py

And class name is correct in CamelCase, also as guidelines say.

I still don't know what's wrong with my proposal: rename it to sale_order.py

Maybe it was a mistake, you said:

You should rename it to sale_order (model name, not module name).

The model name is SaleOrderLine, correct.

Indeed the module should be sale_order.py.

No, the main model is sale.order, not sale.order.line, that's why I ask for sale_order.py

Ah OK, I was understanding that you wanted him to rename the model! We agree then 😉

pedrobaeza · 2015-10-09T00:14:39Z

You have to also intercept product_id_change for handling changes on quantity. You should also prevent when packaging is selected, non multiple quantities.

sergio-teruel · 2015-10-09T10:25:49Z

@rafaelbn @pedrobaeza Changes made

pedrobaeza · 2015-10-09T10:41:16Z

sale_packaging_price/README.rst

+* go to warehouse config and check 'Use packages: pallets, boxes, ...' and
+'Allow to define several packaging methods on products'
+
+* go to product and into procurement tab you can add new packages with a


This part is Usage section. I was talking about the other paragraph

sergio-teruel · 2015-10-09T12:01:48Z

@rafaelbn @pedrobaeza Chnges made

pedrobaeza · 2015-10-09T12:04:55Z

👍

yajo · 2015-10-20T14:36:44Z

sale_packaging_price/README.rst

+Bug Tracker
+===========
+
+Bugs are tracked on `GitHub Issues <https://github.com/OCA/167/issues>`_.


yajo · 2015-10-20T15:11:10Z

Testing in runbot, I created a package with 6 wine bottles (individual price would be 20€, pack price 100€).

See the results:

100.02€ is not the price I set.

To avoid this kind of problems, add a constraint that will not let the user to set an icompatible unit + package price combination. It will hassle them, but better hassle the user than the client.

yajo · 2015-10-20T15:11:57Z

sale_packaging_price/README.rst

+
+To use this module, you need to:
+
+* go to product and into procurement tab you can add new packages with a


It's in the inventory tab.

Ok.
About the previous comment(100.02) you can increment the price decimal precision.

sergio-teruel · 2015-10-22T17:37:31Z

@yajo @pedrobaeza @rafaelbn Changes made.

yajo · 2015-10-23T14:32:55Z

Much better, but still getting #221 (comment) though. Fix it and test it please.

sergio-teruel · 2015-10-23T17:14:14Z

@yajo about #221 (comment) you can increment the price decimal precision.

yajo · 2015-10-27T16:50:41Z

Not sure how to do that. Can you explain?

Anyway, independently of the decimal precision, if you set a final price for a bundle of products, that should always be the final price. If the final price cannot be exactly matched because of the mix of quantity, price and decimal precision, then it should not allow to put that price in the first place.

…cimal precision unit price

carlosdauden · 2015-11-06T14:01:10Z

cc @pedrobaeza @yajo @rafaelbn @sergio-incaser

yajo · 2015-11-10T08:47:12Z

The code looks good, but there is a new bug.

Add a new product.
Go to Inventory > Packaging > Configurations.
Add new.

Error:

Traceback (most recent call last):
  File "/srv/openerp/instances/openerp-oca-runbot/parts/odoo-extra/runbot/static/build/3119204-221-bd055f/openerp/http.py", line 537, in _handle_exception
    return super(JsonRequest, self)._handle_exception(exception)
  File "/srv/openerp/instances/openerp-oca-runbot/parts/odoo-extra/runbot/static/build/3119204-221-bd055f/openerp/http.py", line 574, in dispatch
    result = self._call_function(**self.params)
  File "/srv/openerp/instances/openerp-oca-runbot/parts/odoo-extra/runbot/static/build/3119204-221-bd055f/openerp/http.py", line 310, in _call_function
    return checked_call(self.db, *args, **kwargs)
  File "/srv/openerp/instances/openerp-oca-runbot/parts/odoo-extra/runbot/static/build/3119204-221-bd055f/openerp/service/model.py", line 118, in wrapper
    return f(dbname, *args, **kwargs)
  File "/srv/openerp/instances/openerp-oca-runbot/parts/odoo-extra/runbot/static/build/3119204-221-bd055f/openerp/http.py", line 307, in checked_call
    return self.endpoint(*a, **kw)
  File "/srv/openerp/instances/openerp-oca-runbot/parts/odoo-extra/runbot/static/build/3119204-221-bd055f/openerp/http.py", line 803, in __call__
    return self.method(*args, **kw)
  File "/srv/openerp/instances/openerp-oca-runbot/parts/odoo-extra/runbot/static/build/3119204-221-bd055f/openerp/http.py", line 403, in response_wrap
    response = f(*args, **kw)
  File "/srv/openerp/instances/openerp-oca-runbot/parts/odoo-extra/runbot/static/build/3119204-221-bd055f/openerp/addons/web/controllers/main.py", line 944, in call_kw
    return self._call_kw(model, method, args, kwargs)
  File "/srv/openerp/instances/openerp-oca-runbot/parts/odoo-extra/runbot/static/build/3119204-221-bd055f/openerp/addons/web/controllers/main.py", line 936, in _call_kw
    return getattr(request.registry.get(model), method)(request.cr, request.uid, *args, **kwargs)
  File "/srv/openerp/instances/openerp-oca-runbot/parts/odoo-extra/runbot/static/build/3119204-221-bd055f/openerp/api.py", line 250, in wrapper
    return old_api(self, *args, **kwargs)
  File "/srv/openerp/instances/openerp-oca-runbot/parts/odoo-extra/runbot/static/build/3119204-221-bd055f/openerp/api.py", line 372, in old_api
    result = method(recs, *args, **kwargs)
  File "/srv/openerp/instances/openerp-oca-runbot/parts/odoo-extra/runbot/static/build/3119204-221-bd055f/openerp/models.py", line 5929, in onchange
    record._onchange_eval(name, field_onchange[name], result)
  File "/srv/openerp/instances/openerp-oca-runbot/parts/odoo-extra/runbot/static/build/3119204-221-bd055f/openerp/models.py", line 5787, in _onchange_eval
    method_res = method(self)
  File "/srv/openerp/instances/openerp-oca-runbot/parts/odoo-extra/runbot/static/build/3119204-221-bd055f/openerp/addons/sale_packaging_price/models/product.py", line 23, in _onchange_list_price
    round(self.list_price / self.qty, price_precision) *
ZeroDivisionError: float division by zero

yajo · 2015-11-10T08:50:50Z

Seems to happen when qty = 0. When saving a wrong package price, the warning works as expected.

carlosdauden · 2015-11-11T12:32:46Z

@pedrobaeza @yajo @rafaelbn Changes made

carlosdauden · 2015-11-13T08:53:50Z

@pedrobaeza Changes made

carlosdauden · 2015-11-13T18:32:47Z

cc @yajo @rafaelbn

rafaelbn · 2015-11-14T03:37:56Z

About this: #221 (comment) I agree with @yajo . Check: Setting -> Technical -> Database structure -> Decimal accuracy

rafaelbn · 2015-11-14T04:42:45Z

To solve problem of decimal precision please add in usage (even-though this is not the solution):

Go to Setting -> Technical -> Database structure -> Decimal accuracy, select Product Price and set Digits to 3, if you get better accuracy set 4 digits of higher.

Been exactly: (maybe I need some illustration here)

sale_packaging_price: New module to assign a package price

A package in Odoo is object stock.quant.package - Go To Warehouse -> Products -> Packages.
A Logistic Unit in Odoo is object product.ul - Go To Warehouse -> Configuration -> Products -> Logistic Units. Also here I cannot see price.
A product packaging in Odoo is object product.packaging - Go To Warehouse -> Products -> Products packaging. In the product form (tab Inventory) this is called Packaging configuration.

Having this clear (I'm not sure if I have) the objective of module:

To sell 1 product in packages, then if you make a quotation or invoice you are not selling 6 units of individual product, you are selling 1 unit of the package. Thanks why you set the price in the package and not in the product.
- With this point of view you can guess that the problem of decimal precision disappears as if you say a package/box cost 100 and you sell 1 unit of a package.
- So you buy individual units or packages/boxes but you store units
  For example:
- You buy 1 package of 12 bottles of cola (6€) and you stock is 12 bottles of cola, each one cost 0.50€
- You sell packages of 2 bottles of cola, each package has sell price 2€.

rafaelbn · 2015-11-17T01:04:56Z

What do you think about this? #221 (comment)
cc @liebana

rafaelbn · 2015-11-17T01:05:45Z

@sergio-incaser runbot is failing, could you please check it? thanks

liebana · 2015-11-17T08:46:07Z

We have something for one customer, we based in the old product-pack of v6.1. You first define a service product as a bundle:

and then you select which are their components:

Then, because the first product is a service and there can be different VATs on the components in our case, we detail everything in the sale order

but only the stock of the components is carried to the delivery order.

But this module is not finished, because is intended to work with Magento connector and right now it's not possible to create from the ERP the sale order itself. We can upload the code anyway if you want.

This is the way we would eventually solve your requirement, but I haven't look your solution.

yajo · 2015-11-20T17:17:19Z

IMHO this solution is better integrated with current core Odoo. The notice of decimal precision seems fair enough to me. If you want 1.99€/pack, you will be warned, but not disabled to do it.

rafaelbn · 2015-12-02T17:40:51Z

Hi @liebana could you make a PR in https://github.com/OCA/product-attribute/tree/8.0 with that functionality? Module name could be product_pack, this could be better to compare. Ping us when done please, thanks.

yajo · 2015-12-02T17:47:31Z

👍 to this PR, but @liebana's implementation is interesting too. Could you send it please?

pedrobaeza · 2015-12-02T17:53:52Z

That module is in 8.0 in https://github.com/ingadhoc/odoo-addons/tree/8.0/product_pack, but it has the problems I mention here: OCA/product-attribute#6 (comment)

rafaelbn · 2015-12-21T21:01:08Z

Thanks! Tested in runbot 👍

[ADD] sale_packaging_price: New module to assign a package price.

pedrobaeza reviewed Oct 9, 2015
View reviewed changes

[ADD] sale_packaging_price: New module to assign a package price.

27650a3

yajo reviewed Oct 20, 2015
View reviewed changes

[FIX] sale_packaging_price: Changes suggested by @yajo and @pedrobaeza.

9bbd90d

[FIX] sale_packaging_price: Fix flake8.

caa2f01

[IMP][8.0] sale_packaging_price: Check list price differences with de…

600d210

…cimal precision unit price

[IMP][8.0] sale_packaging_price: Rename sale_stock to sale_order

bd055f5

[FIX][8.0] sale_packaging_price: ZeroDivisionError, Translate

23efc32

[FIX][8.0] sale_packaging_price: Better message description

473b536

rafaelbn added the needs review label Dec 2, 2015

rafaelbn added this to the 8.0 milestone Dec 2, 2015

rafaelbn self-assigned this Dec 4, 2015

rafaelbn mentioned this pull request Dec 10, 2015

[8.0][product_pack] New module to have product packs OCA/product-attribute#118

Closed

rafaelbn added a commit that referenced this pull request Dec 21, 2015

Merge pull request #221 from incaser/sale_packaging_price

4e078a5

[ADD] sale_packaging_price: New module to assign a package price.

rafaelbn merged commit 4e078a5 into OCA:8.0 Dec 21, 2015

yvaucher removed the needs review label Dec 21, 2015

sergio-teruel deleted the sale_packaging_price branch December 24, 2015 11:22

rafaelbn mentioned this pull request Sep 19, 2018

[11.0][NEW] product_secondary_unit: New module for set a second units for a product OCA/product-attribute#377

Merged


		To use this module, you need to:

		* go to warehause config and check 'Use packages: pallets, boxes, ...' and


		To use this module, you need to:

		* go to product and into procurement tab you can add new packages with a

[ADD] sale_packaging_price: New module to assign a package price. #221

[ADD] sale_packaging_price: New module to assign a package price. #221

Conversation

sergio-teruel commented Oct 8, 2015

rafaelbn commented Oct 8, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pedrobaeza commented Oct 9, 2015

Choose a reason for hiding this comment

pedrobaeza commented Oct 9, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pedrobaeza commented Oct 9, 2015

sergio-teruel commented Oct 9, 2015

Choose a reason for hiding this comment

sergio-teruel commented Oct 9, 2015

pedrobaeza commented Oct 9, 2015

Choose a reason for hiding this comment

yajo commented Oct 20, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sergio-teruel commented Oct 22, 2015

yajo commented Oct 23, 2015

sergio-teruel commented Oct 23, 2015

yajo commented Oct 27, 2015

carlosdauden commented Nov 6, 2015

yajo commented Nov 10, 2015

yajo commented Nov 10, 2015

carlosdauden commented Nov 11, 2015

carlosdauden commented Nov 13, 2015

carlosdauden commented Nov 13, 2015

rafaelbn commented Nov 14, 2015

rafaelbn commented Nov 14, 2015

rafaelbn commented Nov 17, 2015

rafaelbn commented Nov 17, 2015

liebana commented Nov 17, 2015

yajo commented Nov 20, 2015

rafaelbn commented Dec 2, 2015

yajo commented Dec 2, 2015

pedrobaeza commented Dec 2, 2015

rafaelbn commented Dec 21, 2015