[16.0][MIG] sale_automatic_workflow_payment_mode #2321

florian-dacosta · 2022-12-30T18:47:31Z

Standard Migration

RodrigoBM · 2023-01-31T09:46:28Z

@florian-dacosta sale_automatic_workflow is merged #2281.

Can you rebase it?

Thanks

[ADD] sale_automatic_workflow_payment_mode

[MIG] Rename manifest files

[IMP] sale_automatic_workflow_payment_mode: Use related fields for payment_filter_domain & char_domain widget

Currently translated at 20.0% (2 of 10 strings) Translation: sale-workflow-12.0/sale-workflow-12.0-sale_automatic_workflow_payment_mode Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_automatic_workflow_payment_mode/zh_CN/

Currently translated at 30.0% (3 of 10 strings) Translation: sale-workflow-12.0/sale-workflow-12.0-sale_automatic_workflow_payment_mode Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_automatic_workflow_payment_mode/zh_CN/

Currently translated at 40.0% (4 of 10 strings) Translation: sale-workflow-12.0/sale-workflow-12.0-sale_automatic_workflow_payment_mode Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_automatic_workflow_payment_mode/zh_CN/

Currently translated at 100.0% (10 of 10 strings) Translation: sale-workflow-12.0/sale-workflow-12.0-sale_automatic_workflow_payment_mode Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_automatic_workflow_payment_mode/zh_CN/

Currently translated at 90.0% (9 of 10 strings) Translation: sale-workflow-12.0/sale-workflow-12.0-sale_automatic_workflow_payment_mode Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_automatic_workflow_payment_mode/es/

Use Queue Jobs to process the Sales Automatic Workflow actions. The default behavior of the automatic workflow module is to use a scheduled action that searches all the record that need a workflow action and sequentially process all of them. It can hit some limits when the number of records is too high. This module keeps the scheduled action to search the records, but instead of directly executing the actions (confirm a sales order, create invoices for a sales order, validate invoices, ...), it creates one job per operation to do. It uses an identity key on the jobs so it will not create the same job for the same record and same operation twice. ~ I needed to extract methods in `sale_automatic_workflow` in order to be able to execute them as jobs. A new decorator "job_auto_delay" (to eventually move in queue_job) makes these methods automatically delayed when called.

Currently translated at 30.0% (3 of 10 strings) Translation: sale-workflow-12.0/sale-workflow-12.0-sale_automatic_workflow_payment_mode Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_automatic_workflow_payment_mode/sl/

… increase coverage

Parts of `sale_automatic_workflow_payment_mode` have been merged into `sale_automatic_workflow`. But these parts have been not removed from `sale_automatic_workflow_payment_mode`. This PR clean both modules after this merge. Originals PR of the merge: OCA#1789

…ng SO's workflow if payment.mode hasn't one set It seems this feature was added during the 14.0 migration PR, here: 111bb97 But it wasn't like this before, and IMO it was ok.

- Move register_payment option from sale_automatic_workflow_payment_mode to sale_automatic_workflow. - Add _register_payments function in sale_automatic_workflow. TT31208

...payment when no fixed journal and remove sale_workflow_process

* Fix tests errors

florian-dacosta · 2023-01-31T11:00:59Z

@RodrigoBM Done, thanks for the ping

asierneiradev · 2023-02-23T09:57:55Z

Hi @florian-dacosta !
Would it be possible for you to review the failed tests in order to speed up the migration?
Thank you very much

florian-dacosta · 2023-02-23T10:08:24Z

Hi @asierneiradev It seems it is a incompatibility of tests between sale_automatic_workflow and account_payment_partner

I believe sale_automatic_workflow tests should be refactored here https://github.com/OCA/sale-workflow/blob/16.0/sale_automatic_workflow/tests/test_multicompany.py#L123
Because default company is changed on the user, but since v14, it is not the way to do this kind of stuff, I think it should be replace by with_company to change company of a user.

Sadly, I don't have time for now to work on this subject...

…payment_partner

florian-dacosta · 2023-03-07T22:07:17Z

@asierneiradev here it is, I've fix the test compatibility between sale_automatic_workflow and account_payment_partner
Can you review please ?

asierneiradev · 2023-03-08T05:57:18Z

@asierneiradev here it is, I've fix the test compatibility between sale_automatic_workflow and account_payment_partner Can you review please ?

Approved!
Thank you very much for your time @florian-dacosta and for adapting the test compatibility.

@sbidoul @guewen ,
Can we push this migration?
Thank you very much

OCA-git-bot · 2023-03-09T09:48:04Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

bguillot · 2023-03-09T09:54:59Z

/ocabot merge nobump

OCA-git-bot · 2023-03-09T09:55:16Z

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-2321-by-bguillot-bump-nobump, awaiting test results.

OCA-git-bot · 2023-03-09T10:04:09Z

Congratulations, your PR was merged at abac9db. Thanks a lot for contributing to OCA. ❤️

RodrigoBM mentioned this pull request Jan 17, 2023

Migration to version 16.0 #2215

Open

98 tasks

florian-dacosta force-pushed the 16.0-mig-sale_automatic_workflow_payment_mode branch from fbafc8e to ae48622 Compare January 27, 2023 15:12

guewen and others added 27 commits January 31, 2023 11:47

[WIP][9.0] Add sale_automatic_workflow_payment_mode (OCA#297)

426d32a

[ADD] sale_automatic_workflow_payment_mode

[MIG] Make modules uninstallable

b0809bd

[MIG] Rename manifest files

[MIG] sale_automatic_workflow_payment_mode: Upgrade to v10

6e9e41d

[IMP] sale_automatic_workflow_payment_mode: improve test coverage

5778f08

[IMP] sale_automatic_workflow_payment_mode: OCA conventions

9189d67

[IMP] sale_automatic_workflow_payment_mode: Use related fields for payment_filter_domain & char_domain widget

[MIG] sale_automatic_workflow_payment_mode to V11

439f094

[11.0] [MIG]sale_procurement_group_by_line: Migration to 11.0.

8d97e60

Migration to version 12.0

5a59609

[IMP] sale_automatic_workflow_payment_mode cosmetics

c8f063f

[FIX] pep8 and pylint

20d5cf2

[MIG] sale_automatic_workflow_payment_mode from 12.0 to 13.0

43c443f

[MIG] sale_automatic_workflow_payment_mode: run pre-commit

a8681f0

[IMP] sale_automatic_workflow_payment_mode: black, isort, prettier

08ffd7f

[MIG] sale_automatic_workflow_payment_mode: Migration to 14.0

155dee2

[IMP] sale_automatic_workflow_payment_mode: sync SO workflow process,…

5032b75

… increase coverage

[FIX] sale_automatic_workflow_payment_mode: avoid overwritting/removi…

8ded1cd

…ng SO's workflow if payment.mode hasn't one set It seems this feature was added during the 14.0 migration PR, here: 111bb97 But it wasn't like this before, and IMO it was ok.

sale_automatic_workflow_payment_mode 14.0.1.0.1

3d62597

[IMP] sale_automatic_workflow:

734eef3

- Move register_payment option from sale_automatic_workflow_payment_mode to sale_automatic_workflow. - Add _register_payments function in sale_automatic_workflow. TT31208

[FIX] sale_automatic_workflow_mode: missing super()

9c40cfb

sonhd and others added 4 commits January 31, 2023 11:47

[FIX] sale_automatic_workflow_payment_mode: not register...

5b0b95c

...payment when no fixed journal and remove sale_workflow_process

[MIG] sale_automatic_workflow_payment_mode 15.0 &

c0a9484

* Fix tests errors

[IMP] sale_automatic_workflow_payment_mode: black, isort, prettier

ae663e7

[16.0][MIG] Migrate sale_automatic_workflow_payment_mode to v16

117c588

florian-dacosta force-pushed the 16.0-mig-sale_automatic_workflow_payment_mode branch from ae48622 to 117c588 Compare January 31, 2023 10:56

asierneiradev mentioned this pull request Feb 1, 2023

[16.0][MIG] connector_ecommerce OCA/connector-ecommerce#75

Merged

[FIX] test compatibility between sale_automatic_workflow and account_…

1674022

…payment_partner

asierneiradev approved these changes Mar 8, 2023

View reviewed changes

RodrigoBM approved these changes Mar 9, 2023

View reviewed changes

OCA-git-bot added approved ready to merge labels Mar 9, 2023

OCA-git-bot added the bot is merging ⏳ label Mar 9, 2023

OCA-git-bot merged commit 9a225e3 into OCA:16.0 Mar 9, 2023

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Mar 9, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[16.0][MIG] sale_automatic_workflow_payment_mode #2321

[16.0][MIG] sale_automatic_workflow_payment_mode #2321

florian-dacosta commented Dec 30, 2022

RodrigoBM commented Jan 31, 2023

florian-dacosta commented Jan 31, 2023

asierneiradev commented Feb 23, 2023

florian-dacosta commented Feb 23, 2023

florian-dacosta commented Mar 7, 2023

asierneiradev commented Mar 8, 2023

OCA-git-bot commented Mar 9, 2023

bguillot commented Mar 9, 2023

OCA-git-bot commented Mar 9, 2023

OCA-git-bot commented Mar 9, 2023

[16.0][MIG] sale_automatic_workflow_payment_mode #2321

[16.0][MIG] sale_automatic_workflow_payment_mode #2321

Conversation

florian-dacosta commented Dec 30, 2022

RodrigoBM commented Jan 31, 2023

florian-dacosta commented Jan 31, 2023

asierneiradev commented Feb 23, 2023

florian-dacosta commented Feb 23, 2023

florian-dacosta commented Mar 7, 2023

asierneiradev commented Mar 8, 2023

OCA-git-bot commented Mar 9, 2023

bguillot commented Mar 9, 2023

OCA-git-bot commented Mar 9, 2023

OCA-git-bot commented Mar 9, 2023