Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][MIG] sale_planner_calendar: Migration to version 16.0 #3198

Merged

Conversation

pilarvargas-tecnativa
Copy link
Contributor

@pilarvargas-tecnativa pilarvargas-tecnativa commented Jun 18, 2024

supersedes #2556

cc @Tecnativa TT44359

@CarlosRoca13 @carolinafernandez-tecnativa please review

@pedrobaeza
Copy link
Member

/ocabot migration sale_planner_calendar

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Jun 18, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request Jun 18, 2024
98 tasks
@pilarvargas-tecnativa pilarvargas-tecnativa force-pushed the 16.0-mig-sale_planner_calendar-continue branch 4 times, most recently from 190d7e0 to 2c292e3 Compare June 24, 2024 08:49
@pilarvargas-tecnativa pilarvargas-tecnativa force-pushed the 16.0-mig-sale_planner_calendar-continue branch from 2c292e3 to 79fce54 Compare July 10, 2024 10:44
CarlosRoca13 and others added 21 commits July 11, 2024 10:23
… from RedirectWarning popup.

Inline is not possible because v15 try save partner record.
Use of "ir.action.do_nothing" can cause concurrency problems in registry writing.

TT43060
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: sale-workflow-15.0/sale-workflow-15.0-sale_planner_calendar
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-15-0/sale-workflow-15-0-sale_planner_calendar/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: sale-workflow-15.0/sale-workflow-15.0-sale_planner_calendar
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-15-0/sale-workflow-15-0-sale_planner_calendar/
Copy link
Contributor

@CarlosRoca13 CarlosRoca13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something is wrong on Sale planner calendar summary form
image
vs
image

@pilarvargas-tecnativa pilarvargas-tecnativa force-pushed the 16.0-mig-sale_planner_calendar-continue branch from 5c654eb to 699ffb7 Compare July 11, 2024 11:16
@pilarvargas-tecnativa
Copy link
Contributor Author

Something is wrong on Sale planner calendar summary form

Please check again

image

Copy link
Contributor

@CarlosRoca13 CarlosRoca13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On Configuration > Reassignment of salesperson

This buttons should be above the tree
image

And the buttons to apply the changes are missing:
image

@pilarvargas-tecnativa pilarvargas-tecnativa force-pushed the 16.0-mig-sale_planner_calendar-continue branch from 699ffb7 to 878fe95 Compare July 11, 2024 14:02
@CarlosRoca13
Copy link
Contributor

Check this steps:

  1. Create a calendar recurrence for a user of 1 year
  2. Go to Configuration > Reassignment of salesperson
  3. Select the salesperson of the recurrence
  4. Press on Fill events from filters
  5. Select a period (New Start and New End)
  6. Press option Assign New Salesperson
  7. On the event line set the new user for the period
  8. Apply Changes

An error is thrown

@pilarvargas-tecnativa pilarvargas-tecnativa force-pushed the 16.0-mig-sale_planner_calendar-continue branch from 878fe95 to 9613fbb Compare July 12, 2024 09:40
@carolinafernandez-tecnativa
Copy link
Contributor

I create a planner for a contact with tag Delivery

image

I create a sale order for that contact and when press button Confirm i got this error message:

image

You need to include this fix to migration:

#3225

I have tested and with recent changes this is solved.
Waiting for @CarlosRoca13 to check other things.
Thanks!

Copy link
Member

@Deriman-Alonso Deriman-Alonso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍, code review

@pilarvargas-tecnativa pilarvargas-tecnativa force-pushed the 16.0-mig-sale_planner_calendar-continue branch 2 times, most recently from c75ec6e to 2a5f59a Compare July 12, 2024 15:03
@pilarvargas-tecnativa pilarvargas-tecnativa force-pushed the 16.0-mig-sale_planner_calendar-continue branch from 2a5f59a to 8d2ea1e Compare July 16, 2024 09:52
Copy link
Contributor

@CarlosRoca13 CarlosRoca13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much 😄

@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-3198-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Jul 17, 2024
Signed-off-by pedrobaeza
@OCA-git-bot
Copy link
Contributor

It looks like something changed on 16.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 16.0-ocabot-merge-pr-3198-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 1dd88b3 into OCA:16.0 Jul 17, 2024
7 of 9 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at d87d784. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza deleted the 16.0-mig-sale_planner_calendar-continue branch July 17, 2024 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.