Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][FIX] sale_blanket_order: filter default taxes by company for all users #3288

Open
wants to merge 1 commit into
base: 17.0
Choose a base branch
from

Conversation

StefanRijnhart
Copy link
Member

Because all users can potentially access taxes from multiple companies.

Also add some minor usability improvements (cf. sale.order.line's tax_id).

@StefanRijnhart StefanRijnhart added this to the 17.0 milestone Aug 29, 2024
@StefanRijnhart

This comment was marked as resolved.

Copy link
Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@espo-tony espo-tony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Copy link

@CasVissers-360ERP CasVissers-360ERP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review

@StefanRijnhart
Copy link
Member Author

@OCA/crm-sales-marketing-maintainers ready to merge, I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants