Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17.0][FIX] sale_blanket_order: set analytic distribution on created sale lines #3294

Open
wants to merge 3 commits into
base: 17.0
Choose a base branch
from
Open

[17.0][FIX] sale_blanket_order: set analytic distribution on created sale lines #3294

wants to merge 3 commits into from

Conversation

StefanRijnhart
Copy link
Member

No description provided.

@StefanRijnhart StefanRijnhart added this to the 17.0 milestone Aug 29, 2024
@StefanRijnhart StefanRijnhart force-pushed the 17.0-fix-sale_blanket_order-create_sale_line_with_analytic branch from 55e6fe3 to f6d1ea2 Compare August 29, 2024 19:19
@StefanRijnhart StefanRijnhart mentioned this pull request Sep 4, 2024
Merged
Saran440
Saran440 reviewed Sep 4, 2024
View reviewed changes
Copy link
Member

@Saran440 Saran440 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review, a little bit comment.

sale_blanket_order/wizard/create_sale_orders.py Outdated Show resolved Hide resolved
Saran440
Saran440 approved these changes Sep 4, 2024
View reviewed changes
Copy link
Member

@Saran440 Saran440 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review 👍

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

espo-tony
espo-tony approved these changes Sep 26, 2024
View reviewed changes
Copy link

@espo-tony espo-tony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@CasVissers-360ERP
Copy link

@rousseldenis can we merge?

@StefanRijnhart
Copy link
Member Author

@OCA/crm-sales-marketing-maintainers ready to merge, I think.

@StefanRijnhart StefanRijnhart mentioned this pull request Jan 31, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@espo-tony espo-tony espo-tony approved these changes

@rousseldenis rousseldenis rousseldenis approved these changes

@Saran440 Saran440 Saran440 approved these changes

Assignees
No one assigned
Labels
approved ready to merge
Projects
None yet
Milestone
17.0
Development

Successfully merging this pull request may close these issues.
6 participants
@StefanRijnhart @OCA-git-bot @CasVissers-360ERP @espo-tony @rousseldenis @Saran440