Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18.0][MIG] sale_delivery_state #3395

Open
wants to merge 37 commits into
base: 18.0
Choose a base branch
from

Conversation

Virendrasinh1909
Copy link

No description provided.

PierrickBrun and others added 30 commits November 10, 2024 01:52
Make it optional to work with module `delivery` without adding it as a dependency
Co-authored-by: Simone Orsi <simahawk@users.noreply.github.com>
@dreispt
Copy link
Member

dreispt commented Nov 18, 2024

As a note,#3349 will need forward porting to 18.0.

Copy link

@thienvh332 thienvh332 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG overall,
In addition to PR 3349 that the previous person suggested, you also need to pick #3020.

Additionally, I think we should have a migration for the sale_stock_delivery_state module. To avoid problems when sale_stock is installed.

</field>
<group name="sale_shipping" position="inside">
<field name="delivery_status" invisible="state != 'sale'" />
<field name="force_delivery_state" invisible="1" />

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, Since https://github.com/odoo/odoo/pull/137031 the invisible fields are add automatically (invisible and readonly) if they are used by python expressions in views (invisible, required, readonly, context, domain...).

Suggested change
<field name="force_delivery_state" invisible="1" />

<field
name="delivery_status"
widget="badge"
optional="hide"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
optional="hide"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why hiding? I thought it was a global recommendation in OCA to hide new fields in tree/list views to not clutter them. By default the std field is hidden too in sale_stock.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@sebalix
Copy link
Contributor

sebalix commented Jan 23, 2025

/ocabot migration sale_delivery_state

@OCA-git-bot OCA-git-bot added this to the 18.0 milestone Jan 23, 2025
@OCA-git-bot OCA-git-bot mentioned this pull request Jan 23, 2025
60 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.