Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[18.0][MIG] sale_discount_display_amount: Migration to 18.0 #3471

Open
wants to merge 42 commits into
base: 18.0
Choose a base branch
from
Open

[18.0][MIG] sale_discount_display_amount: Migration to 18.0 #3471

wants to merge 42 commits into from

Conversation

LucasTran380381
Copy link

No description provided.

Cédric Pigeon and others added 30 commits November 29, 2024 16:05
[ADD] add new module to display discount amount on sale orders
7ae3443
Added translation using Weblate (French)
5c572f3
Added translation using Weblate (Spanish)
2bc4cbb
@Abranes
[12.0][MIG] sale_discount_display_amount
a47cd32
@marylla
Added translation using Weblate (German)
69d577d
@marylla
Translated using Weblate (German)
577c770 
Currently translated at 100.0% (4 of 4 strings)

Translation: sale-workflow-12.0/sale-workflow-12.0-sale_discount_display_amount
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_discount_display_amount/de/
@liweijie0812
Added translation using Weblate (Chinese (Simplified))
fef1a7e
@liweijie0812
Translated using Weblate (Chinese (Simplified))
f99bf2c 
Currently translated at 100.0% (4 of 4 strings)

Translation: sale-workflow-12.0/sale-workflow-12.0-sale_discount_display_amount
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_discount_display_amount/zh_CN/
[IMP] sale_discount_display_amount: black, isort
222c993
[MIG] sale_discount_display_amount: Migration to 13.0
c142cb7
@lmignon
[MIG] sale_discount_display_amount: Computed values must be reset by …
dbf962b 
…the compute method
[IMP] sale_discount_display_amount rename view
79de0e5
@pedrobaeza
[FIX] sale_discount_display_amount: Guidelines in compute methods names
7f2739c 
If not, it can collide with other modules defining the same compute name, so let's
follow the guidelines and name properly the method.
@danimv5
Translated using Weblate (Spanish)
222fddf 
Currently translated at 100.0% (4 of 4 strings)

Translation: sale-workflow-13.0/sale-workflow-13.0-sale_discount_display_amount
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-13-0/sale-workflow-13-0-sale_discount_display_amount/es/
@chafique-delli
[MIG] sale_discount_display_amount: Migration to 14.0
a1ae534 
[FIX] README.rst
@bosd
Added translation using Weblate (Dutch)
e99ef2f
@bosd
Translated using Weblate (Dutch)
1f82ae2 
Currently translated at 100.0% (7 of 7 strings)

Translation: sale-workflow-14.0/sale-workflow-14.0-sale_discount_display_amount
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-sale_discount_display_amount/nl/
@danimv5
Added translation using Weblate (Catalan)
f65cf21
@danimv5
Translated using Weblate (Catalan)
861c3e2 
Currently translated at 100.0% (7 of 7 strings)

Translation: sale-workflow-14.0/sale-workflow-14.0-sale_discount_display_amount
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-sale_discount_display_amount/ca/
@marylla
Translated using Weblate (German)
175a6a1 
Currently translated at 100.0% (4 of 4 strings)

Translation: sale-workflow-14.0/sale-workflow-14.0-sale_discount_display_amount
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-sale_discount_display_amount/de/
@simahawk
sale_discount_display_amount: fix init hook
2e87185 
Prevent failure if new columns are already in DB.
@rousseldenis
[14.0][IMP] sale_discount_display_amount: Adds hook for depends
ebd5926
@francesco-ooops
Added translation using Weblate (Italian)
ffa3417
@francesco-ooops
Translated using Weblate (Italian)
312d169 
Currently translated at 100.0% (7 of 7 strings)

Translation: sale-workflow-14.0/sale-workflow-14.0-sale_discount_display_amount
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-sale_discount_display_amount/it/
@manuelregidor
[MIG]sale_discount_display_amount: Migration to 15.0
726eff3
@mymage
Translated using Weblate (Italian)
7660038 
Currently translated at 100.0% (7 of 7 strings)

Translation: sale-workflow-15.0/sale-workflow-15.0-sale_discount_display_amount
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-15-0/sale-workflow-15-0-sale_discount_display_amount/it/
[MIG] sale_discount_display_amount: Migration to 16.0
503b77c
@francesco-ooops
Translated using Weblate (Italian)
07cf275 
Currently translated at 100.0% (4 of 4 strings)

Translation: sale-workflow-16.0/sale-workflow-16.0-sale_discount_display_amount
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_discount_display_amount/it/
[IMP] sale_discount_display_amount: Show total discount on sale report.
cf84bc2
@mymage
Translated using Weblate (Italian)
ffb07ba 
Currently translated at 100.0% (5 of 5 strings)

Translation: sale-workflow-16.0/sale-workflow-16.0-sale_discount_display_amount
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_discount_display_amount/it/
FSchiepers and others added 11 commits November 29, 2024 16:05
@FSchiepers
[MIG] Sale Discount Display Amount: Migration to 17.0
49b947f
@mymage
Translated using Weblate (Italian)
1f94ddc 
Currently translated at 100.0% (11 of 11 strings)

Translation: sale-workflow-17.0/sale-workflow-17.0-sale_discount_display_amount
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-17-0/sale-workflow-17-0-sale_discount_display_amount/it/
@antonioburic
[IMP] linting changes to .rst files
d41e08e
@manuelregidor
[14.0][IMP]sale_discount_display_amount: Show total discount on sale …
32d83d1 
…report
@paradoxxxzero
[IMP] sale_discount_display_amount: Add untaxed no discount
38520d2
@renda-dev
[IMP] sale_discount_display_amount: add total without discount in report
b4a2936
@renda-dev
[FIX] sale_discount_display_amount: switch field positions
1fd214f
@henrybackman
[FIX] sale_discount_display_amount: config views fixes
c62a52e 
fix issues with config settings views after forward porting
@henrybackman
sale_discount_display_amount: adapt migration scripts to v17
c06199a
@mymage
Translated using Weblate (Italian)
7ccc910 
Currently translated at 100.0% (17 of 17 strings)

Translation: sale-workflow-17.0/sale-workflow-17.0-sale_discount_display_amount
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-17-0/sale-workflow-17-0-sale_discount_display_amount/it/
[IMP] sale_discount_display_amount: pre-commit execution
eb89cb8
@rousseldenis
Copy link
Contributor

/ocabot migration sale_discount_display_amount

@OCA-git-bot OCA-git-bot added this to the 18.0 milestone Dec 10, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request Dec 10, 2024
Open
57 tasks
Naraka
Naraka approved these changes Dec 17, 2024
View reviewed changes
Copy link

@Naraka Naraka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

TDu
TDu reviewed Jan 28, 2025
View reviewed changes
Copy link
Member

@TDu TDu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would be good to have runboat to test this...

sale_discount_display_amount/models/sale_order_line.py Outdated
@@ -9,7 +9,6 @@ class SaleOrderLine(models.Model):

discount_total = fields.Monetary(
compute="_compute_amount",
string="Discount Subtotal",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changes the field description in the UI, I would remove this modification.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/OCA/sale-workflow/pull/3563 forwarded this PR in v17 we define more field discount_subtotal so it suitable to change ui of label field discount_total

@LucasTran380381 LucasTran380381 force-pushed the 18.0-mig-sale_discount_display_amount branch 3 times, most recently from 453619b to 9166201 Compare February 3, 2025 03:33
@LucasTran380381 LucasTran380381 force-pushed the 18.0-mig-sale_discount_display_amount branch from 9166201 to 37c09cb Compare February 3, 2025 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TDu TDu TDu left review comments

@Naraka Naraka Naraka approved these changes

@henrybackman henrybackman henrybackman approved these changes

Assignees
No one assigned
Labels
approved migration needs review ready to merge
Projects
None yet
Milestone
18.0
Development

Successfully merging this pull request may close these issues.