[16.0][ADD] sale_order_country_allowed_product: Restrict products by country in sales #3599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@manuelregidor you should checks tests |
|
@HaraldPanten There's an incompatibility related to OCA/account-invoicing#1840 that has not been solver yet. There's a PR to solve it which I'm following (#3598). |
|
Ok, let's wait few days until the related PRs are merged. |
manuelregidor
force-pushed
the
16.0-add-sale_order_country_allowed_product
branch
from
f07c99e to
e1464e9
Compare
|
@Tisho99 Changes applied |
| @@ -0,0 +1,6 @@ | |||
| <?xml version="1.0" encoding="utf-8" ?> | |||
| <odoo> | |||
| <record id="ignore_country_sale" model="res.groups"> | |||
There was a problem hiding this comment.
add admin by default
| @@ -0,0 +1,6 @@ | |||
| <?xml version="1.0" encoding="utf-8" ?> | |||
| <odoo> | |||
|
|
||
|
|
||
| class TestSaleOrderCountryAllowedProduct(TransactionCase): | ||
| def setUp(self): |
There was a problem hiding this comment.
"@classmethod" is not necessary ?
There was a problem hiding this comment.
It is not, as we are using setUp and not setUpClass. There's only one test, so I think that it is the same using setUp and setUpClass.
manuelregidor
force-pushed
the
16.0-add-sale_order_country_allowed_product
branch
from
e1464e9 to
f1e0b89
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This module allows to restrict the selection of products in sale order lines based on the shipping address country.
@HaraldPanten @ValentinVinagre @luis-ron
T-6187