Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[11.0][NEW] sale_order_secondary_unit: New module for sale in a secondary product unit #693

Merged
merged 1 commit into from
Oct 11, 2018

Conversation

sergio-teruel
Copy link
Contributor

@sergio-teruel sergio-teruel commented Sep 5, 2018

cc @Tecnativa
This module depends of OCA/product-attribute#377

@sergio-teruel sergio-teruel force-pushed the 11.0-PR-sale_order_secondary_unit branch 2 times, most recently from f2954fe to 939c556 Compare September 5, 2018 12:04
@sergio-teruel sergio-teruel force-pushed the 11.0-PR-sale_order_secondary_unit branch from 939c556 to de070d6 Compare September 20, 2018 07:44
Copy link

@tschanzt tschanzt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Copy link
Member

@nikul-serpentcs nikul-serpentcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Improve code

@sergio-teruel sergio-teruel force-pushed the 11.0-PR-sale_order_secondary_unit branch 2 times, most recently from 5bf2f06 to dee01da Compare October 1, 2018 16:06
Copy link
Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested. It has no more interface conflicts with stock-logistics-warehouse/sale_packaging module. They can coexist.

The error is due to missing OCA/product-attribute#377

@sergio-teruel sergio-teruel force-pushed the 11.0-PR-sale_order_secondary_unit branch 3 times, most recently from 71b643f to de5bd32 Compare October 10, 2018 08:04
@sergio-teruel sergio-teruel force-pushed the 11.0-PR-sale_order_secondary_unit branch from de5bd32 to d7ac444 Compare October 10, 2018 08:15
@pedrobaeza pedrobaeza added this to the 11.0 milestone Oct 11, 2018
@pedrobaeza pedrobaeza merged commit 329ebb9 into OCA:11.0 Oct 11, 2018
@pedrobaeza pedrobaeza deleted the 11.0-PR-sale_order_secondary_unit branch October 11, 2018 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants