Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[10.0][IMP] sale_order_type: find type by rule #716

Merged
merged 1 commit into from
Dec 21, 2018
Merged

[10.0][IMP] sale_order_type: find type by rule #716

merged 1 commit into from
Dec 21, 2018

Conversation

SimoRubi
Copy link
Member

@SimoRubi SimoRubi commented Oct 16, 2018 •
edited
Loading

Add feature to automatically select the sale order type based on products (or their categories) of the sale order.

@SimoRubi
Copy link
Member Author

Travis is failing due to #717

@SimoRubi SimoRubi force-pushed the 10.0-add-sale_order_type_trigger branch 2 times, most recently from a7751b7 to 76a1ede Compare October 16, 2018 13:01
@SimoRubi
Copy link
Member Author

Should be rebased after #718 is merged

@SimoRubi SimoRubi force-pushed the 10.0-add-sale_order_type_trigger branch 2 times, most recently from 654a9b4 to 599b1a8 Compare October 16, 2018 16:21
SimoRubi added a commit to SimoRubi/e-commerce that referenced this pull request Oct 16, 2018
@SimoRubi
[ADD] matching types by rule, from OCA/sale-workflow#716
5acf8c5
@SimoRubi SimoRubi force-pushed the 10.0-add-sale_order_type_trigger branch from 599b1a8 to b79a0ab Compare October 17, 2018 10:22
@SimoRubi
Copy link
Member Author

Rebased after #718

@SimoRubi SimoRubi mentioned this pull request Oct 23, 2018
Merged
@SimoRubi SimoRubi changed the title [10.0][ADD] sale_order_type_rule [10.0][IMP] sale_order_type: find type by rule Nov 7, 2018
eLBati
eLBati suggested changes Nov 7, 2018
View reviewed changes
sale_order_type/readme/USAGE.rst Show resolved Hide resolved
sale_order_type/models/sale_order.py Show resolved Hide resolved
sale_order_type/views/sale_order_view.xml Show resolved Hide resolved
tafaRU
tafaRU approved these changes Nov 7, 2018
View reviewed changes
Copy link
Member

@tafaRU tafaRU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review and test.

@SimoRubi
Copy link
Member Author

SimoRubi commented Nov 8, 2018

@tafaRU and @eLBati thanks for your reviews, I did what you asked for in 148e7b6, could you please check?

tafaRU
tafaRU requested changes Nov 12, 2018
View reviewed changes
sale_order_type/models/sale_order_type_rule.py Outdated Show resolved Hide resolved
sale_order_type/models/sale_order_type_rule.py Outdated Show resolved Hide resolved
sale_order_type/models/sale_order_type_rule.py Outdated Show resolved Hide resolved
sale_order_type/models/sale_order_type_rule.py Outdated Show resolved Hide resolved
sale_order_type/__manifest__.py Show resolved Hide resolved
@SimoRubi
Copy link
Member Author

@eLBati I did what you asked for could you please check and update your review?

eLBati
eLBati suggested changes Nov 15, 2018
View reviewed changes
Copy link
Member

@eLBati eLBati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created an order type
image
where ice rule is
image
created an invoice
image

Payment term should be 30% Advance End of Following Month. It is not correctly computed by onchange nor by button

@SimoRubi
Copy link
Member Author

SimoRubi commented Nov 27, 2018 •
edited
Loading

@eLBati I fixed the bug you found out in 9ea9032, could you please check now?
@tafaRU I did what you asked for, could you please update your review?
Thanks

@SimoRubi SimoRubi force-pushed the 10.0-add-sale_order_type_trigger branch from 1d1076f to 9ea9032 Compare November 27, 2018 11:47
tafaRU
tafaRU approved these changes Nov 29, 2018
View reviewed changes
Copy link
Member

@tafaRU tafaRU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This time I only did the code review.

@eLBati
Copy link
Member

eLBati commented Dec 3, 2018

@SimoRubi ok, thanks.
Please just use user friendly labels for product ids and product category ids

image

@SimoRubi
Copy link
Member Author

SimoRubi commented Dec 3, 2018

@eLBati done in bc79830

eLBati
eLBati approved these changes Dec 3, 2018
View reviewed changes
Copy link
Member

@eLBati eLBati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be ported to 11.0 afterwards

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@SimoRubi SimoRubi force-pushed the 10.0-add-sale_order_type_trigger branch from bc79830 to b8b7fa2 Compare December 4, 2018 16:22
@SimoRubi
Copy link
Member Author

SimoRubi commented Dec 4, 2018

Fixed commit history

@SimoRubi
Copy link
Member Author

SimoRubi commented Dec 5, 2018

@eLBati I'll try to cherry-pick this commit in v11 after it's merged

@SimoRubi
Copy link
Member Author

SimoRubi commented Dec 6, 2018

@OCA/crm-sales-marketing-maintainers can this be merged? Thanks

@pedrobaeza
Copy link
Member

Instead of using the sequence, isn't this interesting to be auto-sorted the same as now pricelist items are auto-arranged?

@SimoRubi
Copy link
Member Author

SimoRubi commented Dec 7, 2018

@pedrobaeza I don't know what auto-arrangement you are suggesting, could you provide a link where it is performed? It sounds interesting, thanks

@pedrobaeza
Copy link
Member

I mean this:

https://github.com/odoo/odoo/blob/aed0a828e4c6c1945c09f9701b2e5e5992954924/addons/product/models/product_pricelist.py#L365

in combination with a proper sorted selection field:

https://github.com/odoo/odoo/blob/aed0a828e4c6c1945c09f9701b2e5e5992954924/addons/product/models/product_pricelist.py#L384

This selection field can be computed stored and got from the input in the rest of the fields.

@rafaelbn rafaelbn added this to the 10.0 milestone Dec 10, 2018
@SimoRubi SimoRubi force-pushed the 10.0-add-sale_order_type_trigger branch from b8b7fa2 to f3b721f Compare December 21, 2018 12:42
@SimoRubi
Copy link
Member Author

Thanks @pedrobaeza for the suggestion, that is another good thing to know about Odoo.
In this case, I prefer to give the users more power (it comes with more responsibility) and let them choose the order manually.
I added your suggestion in the roadmap of the module as a possible improvement.

@pedrobaeza pedrobaeza merged commit 87bfc95 into OCA:10.0 Dec 21, 2018
@SimoRubi SimoRubi mentioned this pull request Dec 21, 2018
Merged
SimoRubi added a commit to SimoRubi/e-commerce that referenced this pull request Jan 4, 2019
@SimoRubi
[ADD] matching types by rule, from OCA/sale-workflow#716
e6a2528
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tafaRU tafaRU tafaRU approved these changes

@eLBati eLBati eLBati approved these changes

Assignees
No one assigned
Labels
approved ready to merge
Projects
None yet
Milestone
10.0
Development

Successfully merging this pull request may close these issues.
6 participants
@SimoRubi @eLBati @OCA-git-bot @pedrobaeza @tafaRU @rafaelbn