Skip to content

Commit

Permalink
[FIX] auth_saml: do not force using vulnerable cryptography module
Browse files Browse the repository at this point in the history
  • Loading branch information
vincent-hatakeyama committed Apr 22, 2024
1 parent 7fc0fce commit afb078a
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 8 deletions.
9 changes: 1 addition & 8 deletions auth_saml/__manifest__.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,14 +12,7 @@
"license": "AGPL-3",
"depends": ["base_setup", "web"],
"external_dependencies": {
# Place an upper bound on cryptography version to be compatible with
# pyopenssl 19 mentioned in Odoo 15's requirements.txt. If we don't do
# this, installing this module will try to upgrade cryptography to the latest
# version because the minimum required version in pysaml2 (>=3.1) is greater than
# version 2.6 (from Odoo's requirement.txt). Since cryptography/pyopenssl don't
# declare minimum supported versions, this lead to inconsistencies.
# https://github.com/OCA/server-auth/issues/424
"python": ["pysaml2", "cryptography<37"],
"python": ["pysaml2"],
"bin": ["xmlsec1"],
# special definition used by OCA to install packages
"deb": ["xmlsec1"],
Expand Down
5 changes: 5 additions & 0 deletions auth_saml/readme/INSTALL.rst
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
This addon requires the python module ``pysaml2``.

``pysaml2`` requires the binary ``xmlsec1`` (on Debian or Ubuntu you can install it with ``apt-get install xmlsec1``)

When following the requirements.txt from odoo, the cryptography module must not be the latest version, otherwise it is incompatible with pyopenssl 19.
This is necessary because old cryptography/pyopenssl don't declare minimum supported versions.
It is possible to use newer version of those libraries, eventually patching the Odoo core to stay compatible.
As this issue is not related to this module, nothing is enforced at the module level.
2 changes: 2 additions & 0 deletions test-requirements.txt
Original file line number Diff line number Diff line change
@@ -1 +1,3 @@
responses
# necessary to avoid incompatibilities with pyopenssl
cryptography<37

0 comments on commit afb078a

Please sign in to comment.