[FIX] password_security: Error 500 when login with bad password #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Travis is red and please change version number |
Since some implementation details are changed, I had to change some tests that were actually testing the implementation instead of the desired result of the method.
|
It should be 💚 now. |
hieulucky111
approved these changes
Jun 15, 2018
|
This repo's runbots are failing:
|
|
@chienandalu Remove the |
|
@yajo Yeah, I tried that before, but it redirects to the https one... |
|
Try in a private window, before visiting the https version (possibly it sets a HSTS header) |
|
No luck. Does it work for you?: http://runbot.odoo-community.org:8796/?db=3329552-27-bf3417-all |
|
Yes... 😕 If you try on Firefox? Private window. |
|
Ok, I had to try it in https://www.browserling.com. It works as expected 😄 |
chienandalu
approved these changes
Jun 19, 2018
pedrobaeza
approved these changes
Jun 19, 2018
pedrobaeza
deleted the
11.0-password_security-fix_error_500_login_failure
branch
TIL 😲 |
fkantelberg
pushed a commit
to initOS/server-auth
that referenced
this pull request
Apr 26, 2019
Since some implementation details are changed, I had to change some tests that were actually testing the implementation instead of the desired result of the method.
llacroix
pushed a commit
to archeti-org/server-auth
that referenced
this pull request
Dec 9, 2020
Since some implementation details are changed, I had to change some tests that were actually testing the implementation instead of the desired result of the method.
llacroix
pushed a commit
to archeti-org/server-auth
that referenced
this pull request
Dec 9, 2020
Since some implementation details are changed, I had to change some tests that were actually testing the implementation instead of the desired result of the method.
dsolanki-initos
pushed a commit
to initOS/server-auth
that referenced
this pull request
Feb 8, 2021
Since some implementation details are changed, I had to change some tests that were actually testing the implementation instead of the desired result of the method.
dsolanki-initos
pushed a commit
to initOS/server-auth
that referenced
this pull request
Feb 9, 2021
Since some implementation details are changed, I had to change some tests that were actually testing the implementation instead of the desired result of the method.
Chandresh-OSI
pushed a commit
to ursais/server-auth
that referenced
this pull request
Feb 10, 2021
Since some implementation details are changed, I had to change some tests that were actually testing the implementation instead of the desired result of the method.
dsolanki-initos
pushed a commit
to initOS/server-auth
that referenced
this pull request
Mar 8, 2021
Since some implementation details are changed, I had to change some tests that were actually testing the implementation instead of the desired result of the method.
dreispt
pushed a commit
to ursais/server-auth
that referenced
this pull request
Mar 25, 2021
Since some implementation details are changed, I had to change some tests that were actually testing the implementation instead of the desired result of the method.
rjpathan
pushed a commit
to linserv/server-auth
that referenced
this pull request
Mar 8, 2022
Since some implementation details are changed, I had to change some tests that were actually testing the implementation instead of the desired result of the method.
rjpathan
pushed a commit
to rjpathan/server-auth
that referenced
this pull request
Mar 16, 2022
Since some implementation details are changed, I had to change some tests that were actually testing the implementation instead of the desired result of the method.
dsolanki-initos
pushed a commit
to Nitrokey/odoo-server-auth
that referenced
this pull request
Jan 2, 2023
Since some implementation details are changed, I had to change some tests that were actually testing the implementation instead of the desired result of the method.
dsolanki-initos
pushed a commit
to Nitrokey/odoo-server-auth
that referenced
this pull request
Jan 9, 2023
Since some implementation details are changed, I had to change some tests that were actually testing the implementation instead of the desired result of the method.
astirpe
pushed a commit
to onesteinbv/server-auth
that referenced
this pull request
Feb 20, 2023
Since some implementation details are changed, I had to change some tests that were actually testing the implementation instead of the desired result of the method.
astirpe
pushed a commit
to onesteinbv/server-auth
that referenced
this pull request
Apr 12, 2023
Since some implementation details are changed, I had to change some tests that were actually testing the implementation instead of the desired result of the method.
astirpe
pushed a commit
to onesteinbv/server-auth
that referenced
this pull request
Apr 18, 2023
Since some implementation details are changed, I had to change some tests that were actually testing the implementation instead of the desired result of the method.
jeroenev
pushed a commit
to jeroenev/server-auth
that referenced
this pull request
Nov 30, 2023
Since some implementation details are changed, I had to change some tests that were actually testing the implementation instead of the desired result of the method.
beagle-cloud
pushed a commit
to DynAppsNV/server-auth
that referenced
this pull request
Jan 31, 2024
Since some implementation details are changed, I had to change some tests that were actually testing the implementation instead of the desired result of the method.
SiesslPhillip
pushed a commit
to grueneerde/OCA-server-auth
that referenced
this pull request
Nov 20, 2024
Since some implementation details are changed, I had to change some tests that were actually testing the implementation instead of the desired result of the method.
SiesslPhillip
pushed a commit
to grueneerde/OCA-server-auth
that referenced
this pull request
Nov 20, 2024
Syncing from upstream OCA/server-auth (12.0)
alexis-via
pushed a commit
to akretion/server-auth
that referenced
this pull request
Nov 21, 2024
Since some implementation details are changed, I had to change some tests that were actually testing the implementation instead of the desired result of the method.
amh-mw
pushed a commit
to amh-mw/server-auth
that referenced
this pull request
Jan 7, 2025
Since some implementation details are changed, I had to change some tests that were actually testing the implementation instead of the desired result of the method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this patch, when logging in, and website addon was installed, and you failed the password, you get error 500.
@Tecnativa