[16.0][IMP] auth_saml: Allow admin/managers to edit User SAML information #652
Conversation
| access_auth_saml_attribute_mapping,auth_saml_attribute_mapping,model_auth_saml_attribute_mapping,base.group_system,1,1,1,1 | ||
| auth_saml_provider_erp_manager_access,auth_saml_provider_erp_manager_access,model_auth_saml_provider,base.group_erp_manager,1,0,0,0 |
There was a problem hiding this comment.
I think we might still need this given that res.users.saml has a many2one to auth.saml.provider and one needs to select the provider when making/editing an entry
aronabencherif
force-pushed
the
16.0-auth-saml-downgrade-res_user-access-right
branch
from
b281457 to
5641a1b
Compare
|
/ocabot merge minor |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
@vincent-hatakeyama your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-652-by-vincent-hatakeyama-bump-minor. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
* Add current time as password_write_date for admin user in demo, disabling the reset prompt - fixes OCA#652
Updated the signin method to reflect changes in similar method signin from auth_oauth. Without the changes, the ORM crashes with psycopg2.errors.InvalidSavepointSpecification when trying to signin. Fixes OCA#664
As user in that group can already edit users, so it make sense to allow them to see and edit that information rather than restrict it to admin/system.
vincent-hatakeyama
force-pushed
the
16.0-auth-saml-downgrade-res_user-access-right
branch
from
5641a1b to
06b66a9
Compare
|
/ocabot merge minor |
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at affe350. Thanks a lot for contributing to OCA. ❤️ |
* Add current time as password_write_date for admin user in demo, disabling the reset prompt - fixes OCA#652
* Add current time as password_write_date for admin user in demo, disabling the reset prompt - fixes OCA#652
As user in that group can already edit users, so it make sense to allow them to see and edit that information rather than restrict it to admin/system.