[17.0][MIG] users_ldap_populate: Migration to 17.0 #675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to get visibility on https://www.odoo.com/apps the OCA board has decided to add the OCA as author of all the addons maintained as part of the association.
and remove use of deprecated except_orm on the way
* leftovers from old api * python-ldap does not like Unicode strings
* [MIG] migrate users_ldap_populate to 10.0 Changes include: - move views to views folder - move models to models folder - in views rename openerp to odoo - __openerp__.py to __manifest__.py * [FIX] Add read me to module users_ldap_populate * [FIX] users_ldap_populate: cleanup manifest file Cleanup of the author list * [FIX] users_ldap_populate: More modern copyright in .py files * [FIX] users_ldap_populate: Update read me Fixes include: - more human module name - Fix web links
….0 port (OCA#408) * [ADD] possibility to deactivate users not found in ldap while populating * [IMP] search in ldap for every possibly unknown user to be really sure it actually is not present there * [FIX] refactoring mistake * [IMP] don't use self.query() to be sure to be stopped if any error occurs * [IMP] remove superfluous check as exceptions are not supressed any more * [FIX] typo in variable name [FIX] handle unicode characters in search filter [FIX] search for user's login, not her name * [FIX] don't pass user_name as assertion_value * [FIX] don't deactivate users if we got a non-existent ldap configuration * [FIX] flake8 * [FIX] more flake8 * [FIX] make form usable * [FIX] name clash between function and field * [ADD] test
Also various changes to satisfy pylint/flake/travis.
when the LDAP search returns values for a user existing in Odoo but deactivated, the 'deactivate unknown users' feature was silently disabled. This commit changes the behavior to reactivate the user in Odoo
would not always archive users, esp. when run from a cron on the way: * add some logs to help check what's going on * use sets to remove duplicates * don't query all ldap configurations if one has said the user must be archived
Currently translated at 100.0% (21 of 21 strings) Translation: server-tools-10.0/server-tools-10.0-users_ldap_populate Translate-URL: https://translation.odoo-community.org/projects/server-tools-10-0/server-tools-10-0-users_ldap_populate/fr/
* [10.0] users_ldap_populate special characters
Without this fix, when hitting the populate button, Odoo failed with:
```
Odoo Server Error
Traceback (most recent call last):
File "/opt/odoo/custom/src/odoo/odoo/http.py", line 656, in _handle_exception
return super(JsonRequest, self)._handle_exception(exception)
File "/opt/odoo/custom/src/odoo/odoo/http.py", line 314, in _handle_exception
raise pycompat.reraise(type(exception), exception, sys.exc_info()[2])
File "/opt/odoo/custom/src/odoo/odoo/tools/pycompat.py", line 87, in reraise
raise value
File "/opt/odoo/custom/src/odoo/odoo/http.py", line 698, in dispatch
result = self._call_function(**self.params)
File "/opt/odoo/custom/src/odoo/odoo/http.py", line 346, in _call_function
return checked_call(self.db, *args, **kwargs)
File "/opt/odoo/custom/src/odoo/odoo/service/model.py", line 97, in wrapper
return f(dbname, *args, **kwargs)
File "/opt/odoo/custom/src/odoo/odoo/http.py", line 339, in checked_call
result = self.endpoint(*a, **kw)
File "/opt/odoo/custom/src/odoo/odoo/http.py", line 941, in __call__
return self.method(*args, **kw)
File "/opt/odoo/custom/src/odoo/odoo/http.py", line 519, in response_wrap
response = f(*args, **kw)
File "/opt/odoo/auto/addons/web/controllers/main.py", line 966, in call_button
action = self._call_kw(model, method, args, {})
File "/opt/odoo/auto/addons/web/controllers/main.py", line 954, in _call_kw
return call_kw(request.env[model], method, args, kwargs)
File "/opt/odoo/custom/src/odoo/odoo/api.py", line 759, in call_kw
return _call_kw_multi(method, model, args, kwargs)
File "/opt/odoo/custom/src/odoo/odoo/api.py", line 746, in _call_kw_multi
result = method(recs, *args, **kwargs)
File "/opt/odoo/auto/addons/users_ldap_populate/models/users_ldap.py", line 189, in populate_wizard
res_id = wizard_obj.create({'ldap_id': self.id}).id
File "<decorator-gen-155>", line 2, in create
File "/opt/odoo/custom/src/odoo/odoo/api.py", line 461, in _model_create_multi
return create(self, [arg])
File "/opt/odoo/auto/addons/users_ldap_populate/models/populate_wizard.py", line 32, in create
ldap.action_populate()
File "/opt/odoo/auto/addons/users_ldap_populate/models/users_ldap.py", line 65, in action_populate
results = self._get_ldap_entry_dicts(conf)
File "/opt/odoo/auto/addons/users_ldap_populate/models/users_ldap.py", line 128, in _get_ldap_entry_dicts
ldap_password.encode('utf-8')
File "/usr/local/lib/python3.7/site-packages/ldap/ldapobject.py", line 382, in simple_bind_s
msgid = self.simple_bind(who,cred,serverctrls,clientctrls)
File "/usr/local/lib/python3.7/site-packages/ldap/ldapobject.py", line 376, in simple_bind
return self._ldap_call(self._l.simple_bind,who,cred,RequestControlTuples(serverctrls),RequestControlTuples(clientctrls))
File "/usr/local/lib/python3.7/site-packages/ldap/ldapobject.py", line 263, in _ldap_call
result = func(*args,**kwargs)
TypeError: argument 1 must be str, not bytes
```
Don't know why the POT hasn't been regenerated.
Currently translated at 100.0% (22 of 22 strings) Translation: server-auth-16.0/server-auth-16.0-users_ldap_populate Translate-URL: https://translation.odoo-community.org/projects/server-auth-16-0/server-auth-16-0-users_ldap_populate/it/
Currently translated at 100.0% (22 of 22 strings) Translation: server-auth-16.0/server-auth-16.0-users_ldap_populate Translate-URL: https://translation.odoo-community.org/projects/server-auth-16-0/server-auth-16-0-users_ldap_populate/pt_BR/
This was referenced Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.