[FIX] auth_session_timeout: add /longpolling/im_status as ignored url #689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @hugho-ad, @keylor2906, @imanie383, @luisg123v and @moylop260, please, could you review this PR? This is related to T#84550 |
rolandojduartem
force-pushed
the
15.0-auth_session_timeout-fix_timeout-rolando
branch
from
547fb94
to
a97224e
Compare
luisg123v
suggested changes
Sep 13, 2024
| env = api.Environment(cr, SUPERUSER_ID, {}) | ||
| new_url = "/longpolling/im_status" | ||
| ignored_path_key = "inactive_session_time_out_ignored_url" | ||
| param = env["ir.config_parameter"].sudo() |
There was a problem hiding this comment.
sudo not required as already running as superuser
hugho-ad
approved these changes
Sep 13, 2024
auth_session_timeout [1] uses the time of the modification of the session file to calculate the time of inactivity, but any edition in the session file will change the time of modification of the file and cause inexact time of inactivity. The controller /longpolling/im_status is called several times (every 50 seconds) [2][3], so it is required taking it into account to avoid modifying the time of modification of the session file, so it is required adding /longpolling/im_status as a ignored url [4][5]. References: - [1] https://github.com/Oca/server-auth/blob/1db10f29/auth_session_timeout/models/res_users.py#L73 - [2] https://github.com/odoo/odoo/blob/e5b67f9c/addons/mail/static/src/models/partner/partner.js#L395 - [3] https://github.com/odoo/odoo/blob/e5b67f9c/addons/mail/static/src/models/partner/partner.js#L407 - [4] https://github.com/Oca/server-auth/blob/1db10f29/auth_session_timeout/data/ir_config_parameter_data.xml#L12 - [5] https://github.com/Oca/server-auth/blob/1db10f29/auth_session_timeout/models/res_users.py#L93
rolandojduartem
force-pushed
the
15.0-auth_session_timeout-fix_timeout-rolando
branch
from
a97224e
to
17ae4f6
Compare
|
Hi, @luisg123v, I applied your suggestion, could you review it? |
luisg123v
approved these changes
Sep 13, 2024
|
Hi, @moylop260, could you merge it? |
|
/ocabot merge patch |
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at a7f16f6. Thanks a lot for contributing to OCA. ❤️ |
|
@moylop260 this fits better as nobump because @rolandojduartem already increased version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
auth_session_timeout [1] uses the time of the modification of the session file to calculate the time of inactivity, but any edition in the session file will change the time of modification of the file and cause inexact time of inactivity.
The controller /longpolling/im_status is called several times (every 50 seconds) [2][3], so it is required taking it into account to avoid modifying the time of modification of the session file, so it is required adding /longpolling/im_status as a ignored url [4][5].
References: