Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] auth_oauht_multi_token: Migration to 17.0 #694

Open
wants to merge 21 commits into
base: 17.0
Choose a base branch
from

Conversation

timnis
Copy link

@timnis timnis commented Sep 24, 2024

Based on #678 and thanks to tb-flyt

Tried to follow instructions and hopefully I got it right 😃

Florent de Labarre and others added 20 commits September 24, 2024 06:54
Allow multiple oauth login at the same time.
* cleanup, improve, docstrings
* add tests
Nothing special. Just making linters happy and splitting the readme.

@Tecnativa TT25619
Otherwise lookup is slow when there are many users.
Otherwise you can't delete a user.
This is cosmetic only, because this field is not used
when auth_oauth_multi_token is installed.
Currently translated at 100.0% (15 of 15 strings)

Translation: server-auth-16.0/server-auth-16.0-auth_oauth_multi_token
Translate-URL: https://translation.odoo-community.org/projects/server-auth-16-0/server-auth-16-0-auth_oauth_multi_token/it/
@timnis timnis mentioned this pull request Sep 24, 2024
19 tasks
@ap-wtioit
Copy link
Contributor

ap-wtioit commented Sep 24, 2024

Can you please remove the pandoc-3.4-1-amd64.deb file.

It looks like you missed the rm *.deb step added here: https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-17.0/_compare/4c480a672acf063a72b568879c90bc04d0bf3abe...1040301847c99d82ada874a94e9b8f14b9221757 or is the rm not working as expected?

Edit: ah the step is no longer in the migration docs: https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-17.0

@timnis
Copy link
Author

timnis commented Sep 24, 2024

@ap-wtioit now pandoc-3.4-1-amd64.deb removed

Copy link
Contributor

@CRogos CRogos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is important to squash the *.deb removal commit with the commit, where the file was added. Otherwise this large file stays in the git repository.... in this case the commit needs to be squashed with "[IMP] auth_oauth_multi_token: pre-commit auto fixes"

There are also some more commits which should be squashed with the commit above:
image

https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests#mergesquash-the-commits-generated-by-bots-or-weblate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants