[18.0][MIG] auth_api_key: Migration to 18.0 #701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…custom one from shopinvader
Get rid of keychain dependency
Co-Authored-By: qgroulard <43472442+qgroulard@users.noreply.github.com>
Api key is now based on the new version of server env Key belong to a specifiv database that can be requested based on the domain name. Just setup the db_filter with "%d^" to filter based on domain name
… to manage auth api keys
Add a migration script to create the auth.api.key records from keys defined into the cfg file Provides a specific serction name builder to continue reading the key info from the same section as the one expected by the previous version
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-auth-17.0/server-auth-17.0-auth_api_key Translate-URL: https://translation.odoo-community.org/projects/server-auth-17-0/server-auth-17-0-auth_api_key/
Currently translated at 100.0% (17 of 17 strings) Translation: server-auth-17.0/server-auth-17.0-auth_api_key Translate-URL: https://translation.odoo-community.org/projects/server-auth-17-0/server-auth-17-0-auth_api_key/it/
Currently translated at 100.0% (17 of 17 strings) Translation: server-auth-17.0/server-auth-17.0-auth_api_key Translate-URL: https://translation.odoo-community.org/projects/server-auth-17-0/server-auth-17-0-auth_api_key/it/
An archived user should not have an active api key anymore. But to stay backward compatible the migration script will keep all key active.
simahawk
reviewed
Oct 10, 2024
There was a problem hiding this comment.
@thienvh332 LG but please report the rationale to keep this module as is in the description of the module, thanks :)
(in separate commmit that we can backport)
1 task
|
/ocabot migration auth_api_key |
1 task
simahawk
requested changes
Oct 11, 2024
thienvh332
force-pushed
the
18.0-mig-auth_api_key
branch
from
6327e96
to
10a5106
Compare
simahawk
approved these changes
Oct 11, 2024
|
@thienvh332 would you mind backporting the readme update to v17? /ocabot merge nobump |
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at 26ac77c. Thanks a lot for contributing to OCA. ❤️ |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OCA - Port:
Summary:
This PR migrates the
auth_api_keymodule to Odoo 18.0.Background:
Since Odoo 14.0, native API keys (
res.users.apikey) have been supported, allowing users to authenticate XMLRPC/JSONRPC calls using their API key instead of a password. In Odoo 18.0, the native API key feature has been enhanced.Some special features of the module:
auth="bearer")Why keep
auth_api_key:The
auth_api_keymodule, introduced in Odoo 10.0, offers unique advantages over native API keys.Some special features of the module:
e.g., for system users in a shopinvader case).Given these advantages, particularly in use case like system user authentication, we have decided to retain and migrate the
auth_api_keymodule to Odoo 18.0.