[14.0][IMP/FIX] base_user_role_company - re-add logic around multiple active companies #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdidderen-noviat
changed the title
jdidderen-noviat
force-pushed
the
14.0-user_role_company_fix
branch
4 times, most recently
from
30566d3
to
efc8a8e
Compare
jdidderen-noviat
force-pushed
the
14.0-user_role_company_fix
branch
from
efc8a8e
to
ac241f0
Compare
jdidderen-noviat
changed the title
|
@OCA/tools-maintainers @dreispt Can you have a look at this PR ? |
dreispt
approved these changes
Dec 21, 2023
|
I did not test it, but I agree with the implementation goals and code review looks good. |
|
/ocabot merge patch |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
Congratulations, your PR was merged at 4200890. Thanks a lot for contributing to OCA. ❤️ |
SiesslPhillip
pushed a commit
to grueneerde/OCA-server-backend
that referenced
this pull request
Nov 20, 2024
Syncing from upstream OCA/server-backend (15.0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since this PR #147, the logic when you have several companies active at the same time is broken because only the main/active company is considered (And then inconsistent with the README of the module)
Imagine the following scenario where all companies below are active :
Without the patch: The user will be Seller and Account Manager on all companies
With the patch: The user will be only Seller on all companies
Another situation is also managed. Having the same role for several companies.