Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[15.0][IMP] base_user_role: Improve tests to avoid false errors (ids in different order) #266

Merged
merged 1 commit into from
Feb 2, 2024
Merged

[15.0][IMP] base_user_role: Improve tests to avoid false errors (ids in different order) #266

merged 1 commit into from
Feb 2, 2024

Conversation

victoralmau
Copy link
Member

@victoralmau victoralmau commented Feb 1, 2024 •
edited
Loading

Improve tests to avoid false errors (ids in different order)

Please @chienandalu and @pedrobaeza can you review it?

@Tecnativa

@OCA-git-bot
Copy link
Contributor

Hi @novawish, @sebalix, @jcdrubay,
some modules you are maintaining are being modified, check this out!

@victoralmau victoralmau changed the title [15.0][IMP] base_user_role: Improve tests to avoid false errors (ids in different order) [15.0][WIP] base_user_role: Improve tests to avoid false errors (ids in different order) Feb 1, 2024
@victoralmau victoralmau changed the title [15.0][WIP] base_user_role: Improve tests to avoid false errors (ids in different order) [15.0][IMP] base_user_role: Improve tests to avoid false errors (ids in different order) Feb 1, 2024
@victoralmau victoralmau marked this pull request as ready for review February 1, 2024 13:18
chienandalu
chienandalu approved these changes Feb 1, 2024
View reviewed changes
Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Tardo
Copy link
Member

Tardo commented Feb 2, 2024

Thanks!

@pedrobaeza pedrobaeza added this to the 15.0 milestone Feb 2, 2024
@pedrobaeza
Copy link
Member

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 15.0-ocabot-merge-pr-266-by-pedrobaeza-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit ba467d4 into OCA:15.0 Feb 2, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 40d5ff0. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza deleted the 15.0-fix-base_user_role-tests branch February 2, 2024 16:29
SiesslPhillip pushed a commit to grueneerde/OCA-server-backend that referenced this pull request Nov 20, 2024
@bt-admin
Merge pull request OCA#266 from OCA/14.0
99e54b1 
Syncing from upstream OCA/server-backend (14.0)
This was referenced Jan 28, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tardo Tardo Tardo approved these changes

@chienandalu chienandalu chienandalu approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
15.0
Development

Successfully merging this pull request may close these issues.
5 participants
@victoralmau @OCA-git-bot @Tardo @pedrobaeza @chienandalu