[MIG] base_user_role: Migration to 13.0 #46

sebalix · 2019-10-01T15:44:24Z

No description provided.

oca-clabot · 2019-10-01T15:44:26Z

Hey @sebalix, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/cla
Here is a list of the users:

Duc Dao duc.dd@komit-consulting.com (no github login found)
Duc Dao ducdd@komit-consulting.com (no github login found)

Appreciation of efforts,
OCA CLAbot

jcdrubay · 2019-10-02T01:03:41Z

Hi this is the gihub login of duc.dd@komit-consulting.com: https://github.com/novawish

The email address ducdd@komit-consulting.com is a typo.

jcdrubay

Thank you @sebalix :) I have added 2 small comments. The rest LGTM.

jcdrubay · 2019-10-02T01:08:56Z

base_user_role/data/ir_module_category.xml

+<odoo>
+
+<record model="ir.module.category" id="ir_module_category_role">
+    <field name='name'>User roles</field>


I don' think this is used anywhere, and I think that we should NOT create this module category as it seems like other similar modules in Odoo core are using the category Tools or Extra Tools.

This module category aims to be linked to role/group you create in your own custom module (https://github.com/odoo/odoo/blob/13.0/odoo/addons/base/models/res_users.py#L101) if you want. By doing this you'll have the section 'User roles' in the "Access rights" tab on the user form which will regroup all groups related to role. Without it, all these groups will be in the 'Other' section.
I could add a comment above this XML record about that.

jcdrubay · 2019-10-02T01:16:46Z

base_user_role/readme/USAGE.rst

+[ This file must be present and contains the usage instructions
+  for end-users. As all other rst files included in the README,
+  it MUST NOT contain reStructuredText sections
+  only body text (paragraphs, lists, tables, etc). Should you need
+  a more elaborate structure to explain the addon, please create a
+  Sphinx documentation (which may include this file as a "quick start"
+  section). ]


I guess you should remove this lines

bealdav · 2019-10-04T11:53:03Z

Hi @sebalix is it possible to add these commits in this PR ?

https://github.com/OCA/server-tools/pull/1489/commits

Not blocking for me but you know perfectly this module, it could be nice

Thanks in advance

bealdav · 2019-10-04T20:58:49Z

Thanks @sebalix

sebalix · 2019-10-05T09:00:00Z

@bealdav I'll continue to work on this the next week. There are a lot of fix and improvements in different branches, all of them need to be consolidated. It should be ok for 13.0 now (I just need to rebase some of them).
BTW I would like a tool/git command to compare commits between different branches based not on the commit hash (which has changed) but on other keys like author/date/message to know what to forward port/backport on a branch.

alan196

Tested locally 👍 works as expected

OCA-git-bot · 2019-11-21T11:55:37Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

lmgr0312 · 2019-11-21T16:09:52Z

LGTM

pedrobaeza · 2019-11-21T20:03:55Z

/ocabot merge

OCA-git-bot · 2019-11-21T20:04:09Z

What a great day to merge this nice PR. Let's do it!
Prepared branch 13.0-ocabot-merge-pr-46-by-pedrobaeza-bump-no, awaiting test results.

Signed-off-by pedrobaeza

OCA-git-bot · 2019-11-21T20:07:24Z

@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 13.0-ocabot-merge-pr-46-by-pedrobaeza-bump-no.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

pedrobaeza · 2019-11-21T20:09:27Z

You have to rebase and pass black in pre-commit. See https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-13.0

original branch from OCA#46

eggu68 · 2019-12-16T12:51:39Z

@sebalix @pedrobaeza @Laurent-Corron what is the status of this migration? I see it did not pass all checks? Thank you for your good work.

sebalix · 2019-12-16T21:50:39Z

@pedrobaeza @eggu68 thank you to notice me about this. It's done, all checks are green now. Ready to be merged.

eggu68 · 2020-01-27T12:18:10Z

@pedrobaeza can this be merged to 13.0 now? Thank you.

pedrobaeza · 2020-01-27T12:19:52Z

/ocabot merge

Currently translated at 100,0% (37 of 37 strings) Translation: server-backend-11.0/server-backend-11.0-base_user_role Translate-URL: https://translation.odoo-community.org/projects/server-backend-11-0/server-backend-11-0-base_user_role/da/

Updated by Update PO files to match POT (msgmerge) hook in Weblate.

the groups that have changed with respecto the role.

…notebook users line (#1170)

…users.role.line" This reverts commit b537941d5a2d1fcb3fbacc602124c1b3f6e1d495.

sebalix · 2020-01-30T08:42:57Z

@pedrobaeza sorry for the delay, it's now rebased + isort.cfg updated to resolve the upcoming conflict. Ready to be merged.

pedrobaeza · 2020-01-30T08:43:51Z

/ocabot merge

OCA-git-bot · 2020-01-30T08:44:14Z

This PR looks fantastic, let's merge it!
Prepared branch 13.0-ocabot-merge-pr-46-by-pedrobaeza-bump-no, awaiting test results.

Signed-off-by pedrobaeza

OCA-git-bot · 2020-01-30T08:54:28Z

Congratulations, your PR was merged at c7dc687. Thanks a lot for contributing to OCA. ❤️

Syncing from upstream OCA/server-backend (13.0)

sebalix mentioned this pull request Oct 1, 2019

Migration to version 13.0 #44

Closed

8 tasks

jcdrubay reviewed Oct 2, 2019

View reviewed changes

pedrobaeza added this to the 13.0 milestone Oct 2, 2019

sebalix force-pushed the 13.0-mig-base_user_role branch 2 times, most recently from ba3ae7e to 48da5cd Compare October 4, 2019 14:53

jcdrubay approved these changes Oct 4, 2019

View reviewed changes

sebalix force-pushed the 13.0-mig-base_user_role branch from 8ab0f13 to ad5ae3e Compare October 7, 2019 08:13

alan196 approved these changes Nov 21, 2019

View reviewed changes

OCA-git-bot added approved ready to merge labels Nov 21, 2019

lmgr0312 approved these changes Nov 21, 2019

View reviewed changes

OCA-git-bot added a commit that referenced this pull request Nov 21, 2019

Merge PR #46 into 13.0

b045846

Signed-off-by pedrobaeza

Laurent-Corron pushed a commit to acsone/server-backend that referenced this pull request Nov 26, 2019

[ADD] temp add setup.py

bacc6ea

original branch from OCA#46

sebalix force-pushed the 13.0-mig-base_user_role branch from ad5ae3e to ce06102 Compare December 16, 2019 21:40

baimont mentioned this pull request Dec 18, 2019

[13.0][MIG] base_user_role_history: Migration to 13.0 #53

Merged

hhgabelgaard and others added 18 commits January 29, 2020 10:57

Translated using Weblate (Danish)

b2bb8f2

Currently translated at 100,0% (37 of 37 strings) Translation: server-backend-11.0/server-backend-11.0-base_user_role Translate-URL: https://translation.odoo-community.org/projects/server-backend-11-0/server-backend-11-0-base_user_role/da/

[MIG] base_user_role: Migration to 12.0

12ff9ff

[UPD] README.rst

ccd18b1

[UPD] Update base_user_role.pot

b85a29f

Update translation files

9c8eaa3

Updated by Update PO files to match POT (msgmerge) hook in Weblate.

[UPD] README.rst

2caafd2

[12.0][FIX] readme

6c58c17

[UPD] README.rst

49cd885

[MIG] base_import_match: Migration to 12.0

1a18675

[base_user_role] improve performance by only adding/removing from a user

2865831

the groups that have changed with respecto the role.

[UPD] README.rst

25f0ad3

[10.0][UPD] base_user_role: Disabled Administrator user selection in …

43d15f1

…notebook users line (#1170)

Switch AGPL to LGPL license

63b6e5a

Revert "[FIX] Crash in base_user_role when role_id is not set on res.…

30bc377

…users.role.line" This reverts commit b537941d5a2d1fcb3fbacc602124c1b3f6e1d495.

Make user_id and role_id required in base_user_role_line

9dde533

[IMP] make base_user_role_line company dependent

df80d59

FIX check_company

9d77f58

[MIG] base_user_role: Migration to 13.0

4f7df6d

sebalix force-pushed the 13.0-mig-base_user_role branch from ce06102 to 0fdc2ad Compare January 30, 2020 07:59

[IMP] base_user_role: black, isort

7615a99

sebalix force-pushed the 13.0-mig-base_user_role branch from 0fdc2ad to 7615a99 Compare January 30, 2020 08:09

OCA-git-bot added a commit that referenced this pull request Jan 30, 2020

Merge PR #46 into 13.0

d6bd271

Signed-off-by pedrobaeza

OCA-git-bot merged commit 7615a99 into OCA:13.0 Jan 30, 2020

OCA-git-bot added the merged 🎉 label Jan 30, 2020

sebalix deleted the 13.0-mig-base_user_role branch January 30, 2020 09:12

SiesslPhillip pushed a commit to grueneerde/OCA-server-backend that referenced this pull request Nov 20, 2024

Merge pull request OCA#46 from OCA/13.0

c5cb8e6

Syncing from upstream OCA/server-backend (13.0)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[MIG] base_user_role: Migration to 13.0 #46

[MIG] base_user_role: Migration to 13.0 #46

sebalix commented Oct 1, 2019

oca-clabot commented Oct 1, 2019

jcdrubay commented Oct 2, 2019 •

edited

Loading

jcdrubay left a comment

jcdrubay Oct 2, 2019

sebalix Oct 4, 2019

jcdrubay Oct 2, 2019

bealdav commented Oct 4, 2019

bealdav commented Oct 4, 2019

sebalix commented Oct 5, 2019

alan196 left a comment

OCA-git-bot commented Nov 21, 2019

lmgr0312 commented Nov 21, 2019

pedrobaeza commented Nov 21, 2019

OCA-git-bot commented Nov 21, 2019

OCA-git-bot commented Nov 21, 2019

pedrobaeza commented Nov 21, 2019

eggu68 commented Dec 16, 2019

sebalix commented Dec 16, 2019

eggu68 commented Jan 27, 2020

pedrobaeza commented Jan 27, 2020

sebalix commented Jan 30, 2020

pedrobaeza commented Jan 30, 2020

OCA-git-bot commented Jan 30, 2020

OCA-git-bot commented Jan 30, 2020

[MIG] base_user_role: Migration to 13.0 #46

[MIG] base_user_role: Migration to 13.0 #46

Conversation

sebalix commented Oct 1, 2019

oca-clabot commented Oct 1, 2019

jcdrubay commented Oct 2, 2019 • edited Loading

jcdrubay left a comment

Choose a reason for hiding this comment

jcdrubay Oct 2, 2019

Choose a reason for hiding this comment

sebalix Oct 4, 2019

Choose a reason for hiding this comment

jcdrubay Oct 2, 2019

Choose a reason for hiding this comment

bealdav commented Oct 4, 2019

bealdav commented Oct 4, 2019

sebalix commented Oct 5, 2019

alan196 left a comment

Choose a reason for hiding this comment

OCA-git-bot commented Nov 21, 2019

lmgr0312 commented Nov 21, 2019

pedrobaeza commented Nov 21, 2019

OCA-git-bot commented Nov 21, 2019

OCA-git-bot commented Nov 21, 2019

pedrobaeza commented Nov 21, 2019

eggu68 commented Dec 16, 2019

sebalix commented Dec 16, 2019

eggu68 commented Jan 27, 2020

pedrobaeza commented Jan 27, 2020

sebalix commented Jan 30, 2020

pedrobaeza commented Jan 30, 2020

OCA-git-bot commented Jan 30, 2020

OCA-git-bot commented Jan 30, 2020

jcdrubay commented Oct 2, 2019 •

edited

Loading