[13.0] migrate base_external_system #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* [ADD] base_external_system: Implement interface/adapter for external systems * base_external_system: Fix OS model, add inherits, add validate * base_external_system: Usability and private key pass * base_external_system: Use contextmanager in adapter client * base_external_system: Move contextmanager to interface * base_external_system: Include contextmanager on adapter and system * base_external_system: Unify client * Use password widget for password field * Add tests & security * Fix lint * Add plaintext note
* In cases of deep inheritance, it may be required to create an adapter directly. Add an override in the create via the env context to support this. * Add default system type if creating from an interface * Fix interface assignment during creation in adapter
* Perform standard v11 migration
NL66278
force-pushed
the
13.0-mig-base_external_system
branch
from
a44d896
to
0e3ee4c
Compare
NL66278
force-pushed
the
13.0-mig-base_external_system
branch
from
0e3ee4c
to
1815585
Compare
Testing fingerprint, with ignore_finger_print set to False, caused an error, because it would first set
ignore_fingerprint to False, then validate, never getting to actually setting the fingerprint, causing the
following stacktrace:
Traceback (most recent call last):
File "/home/travis/build/OCA/server-backend/base_external_system/tests/test_external_system.py", line 28, in test_check_fingerprint_allowed
self.record.write({"ignore_fingerprint": False, "fingerprint": "Data"})
File "/home/travis/odoo-13.0/odoo/models.py", line 3573, in write
fields[0].determine_inverse(real_recs)
File "/home/travis/odoo-13.0/odoo/fields.py", line 1122, in determine_inverse
self.inverse(records)
File "/home/travis/odoo-13.0/odoo/fields.py", line 594, in _inverse_related
target[field.name] = record_value[record]
File "/home/travis/odoo-13.0/odoo/models.py", line 5629, in __setitem__
return self._fields[key].__set__(self, value)
File "/home/travis/odoo-13.0/odoo/fields.py", line 1087, in __set__
records.write({self.name: write_value})
File "/home/travis/odoo-13.0/odoo/models.py", line 3568, in write
real_recs._validate_fields(set(vals) - set(inverse_fields))
File "/home/travis/odoo-13.0/odoo/models.py", line 1176, in _validate_fields
check(self)
dreispt
approved these changes
May 5, 2021
|
/ocabot merge nobump |
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at 67439e5. Thanks a lot for contributing to OCA. ❤️ |
SiesslPhillip
pushed a commit
to grueneerde/OCA-server-backend
that referenced
this pull request
Nov 20, 2024
Syncing from upstream OCA/server-backend (12.0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.