Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0] server_environment: allow setting running env through env #146

Merged
merged 1 commit into from
Sep 12, 2023
Merged

[14.0] server_environment: allow setting running env through env #146

merged 1 commit into from
Sep 12, 2023

Conversation

petrus-v
Copy link
Contributor

@petrus-v petrus-v commented Mar 7, 2023 •
edited
Loading

This also give a chance to use server enivornment on odoo.sh !

@petrus-v petrus-v mentioned this pull request Mar 8, 2023
Merged
@petrus-v petrus-v force-pushed the 14.0-allow-to-set-running-env-through-environment-variable branch from 4870cd1 to 5671e7c Compare March 8, 2023 08:34
@petrus-v petrus-v changed the title [IMP] server_environment: allow setting running env through environme… [IMP] server_environment: allow setting running env through env Jun 9, 2023
@petrus-v petrus-v force-pushed the 14.0-allow-to-set-running-env-through-environment-variable branch from a33faf0 to 0061c61 Compare June 9, 2023 14:47
@petrus-v petrus-v changed the title [IMP] server_environment: allow setting running env through env [14.0] server_environment: allow setting running env through env Jun 16, 2023
@damdam-s
Copy link
Member

damdam-s commented Sep 6, 2023

@grindtildeath are you OK with the last changes? thanks

@simahawk
Copy link
Contributor

simahawk commented Sep 7, 2023

@petrus-v could you please shorten commit msgs?

[IMP] server_environment: allow env variable conf should be enough

@petrus-v petrus-v force-pushed the 14.0-allow-to-set-running-env-through-environment-variable branch from 0061c61 to 4286429 Compare September 7, 2023 10:31
@petrus-v
Copy link
Contributor Author

petrus-v commented Sep 7, 2023

@simahawk I've sqashed, rebased and reword the final commit

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@simahawk
Copy link
Contributor

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 14.0-ocabot-merge-pr-146-by-simahawk-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit c0b43a4 into OCA:14.0 Sep 12, 2023
6 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 1332c22. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damdam-s damdam-s damdam-s approved these changes

@Koudja Koudja Koudja approved these changes

@grindtildeath grindtildeath grindtildeath approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@petrus-v @damdam-s @simahawk @OCA-git-bot @grindtildeath @Koudja