Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0] server_environmnet: allow to overwrite odoo config options #159

Merged
merged 1 commit into from
Mar 23, 2024
Merged

[14.0] server_environmnet: allow to overwrite odoo config options #159

merged 1 commit into from
Mar 23, 2024

Conversation

petrus-v
Copy link
Contributor

from server_environment_files module

@petrus-v petrus-v changed the title [IMP] server_environmnet: allow to overwrite odoo config options [14.0] server_environmnet: allow to overwrite odoo config options Jun 16, 2023
@petrus-v petrus-v mentioned this pull request Jun 16, 2023
Closed
damdam-s
damdam-s approved these changes Sep 6, 2023
View reviewed changes
Copy link
Member

@damdam-s damdam-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thomaspaulb
Copy link

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 14.0-ocabot-merge-pr-159-by-thomaspaulb-bump-minor, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Dec 18, 2023
@OCA-git-bot
Merge PR #159 into 14.0
38d0b0a 
Signed-off-by thomaspaulb
@OCA-git-bot
Copy link
Contributor

@thomaspaulb your merge command was aborted due to failed check(s), which you can inspect on this commit of 14.0-ocabot-merge-pr-159-by-thomaspaulb-bump-minor.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@petrus-v petrus-v force-pushed the 14.0-server_environment_overwrite_odoo_options branch from 3c461f8 to 9eaaa54 Compare December 19, 2023 20:12
@petrus-v
Copy link
Contributor Author

I've rebase and the pre-commit step failed at the same point, I've create a new PR to bump copier template version and move to ruff here #176, maybe this PR can wait a bit more the other to get merged

@petrus-v petrus-v force-pushed the 14.0-server_environment_overwrite_odoo_options branch from 9eaaa54 to 9996a48 Compare December 19, 2023 20:56
@petrus-v petrus-v force-pushed the 14.0-server_environment_overwrite_odoo_options branch from 9996a48 to f2a1746 Compare March 22, 2024 15:42
@petrus-v
Copy link
Contributor Author

petrus-v commented Mar 22, 2024 •
edited
Loading

@thomaspaulb I've just rebased the PR, CI looks ok now !

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@thomaspaulb
Copy link

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 14.0-ocabot-merge-pr-159-by-thomaspaulb-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 830d43c into OCA:14.0 Mar 23, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 69b8dc7. Thanks a lot for contributing to OCA. ❤️

@qgroulard qgroulard mentioned this pull request Jul 18, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damdam-s damdam-s damdam-s approved these changes

@Koudja Koudja Koudja approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@petrus-v @thomaspaulb @OCA-git-bot @Koudja @damdam-s