Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0] server_environment: Fix value assignation in compute from default #185

Merged
merged 1 commit into from
Jun 25, 2024
Merged

[16.0] server_environment: Fix value assignation in compute from default #185

merged 1 commit into from
Jun 25, 2024

Conversation

grindtildeath
Copy link
Contributor

FW port of #184

@grindtildeath grindtildeath mentioned this pull request Jun 20, 2024
Merged
@gurneyalex gurneyalex added this to the 16.0 milestone Jun 24, 2024
@grindtildeath
server_environment: Fix value assignation in compute from default
c92c0da 
Since previous commit adding support for ssl certificate auth,
field smtp_authentication in ir.mail_server, became a field managed by
environment, when mail_environment is installed.

This field has been defined using a default value relying on the
compute_default property allowing to define a compute function,
which matches the default value of the field.

However, as the function _compute_server_env_from_default was broken,
because it did not assign the computed value to the field, the
field was empty and connection was broken.
@grindtildeath grindtildeath force-pushed the 16.0-fix-server_env_compute_from_default branch from f606ce2 to c92c0da Compare June 24, 2024 16:48
@gurneyalex
Copy link
Member

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-185-by-gurneyalex-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 3c1eacd into OCA:16.0 Jun 25, 2024
6 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

@gurneyalex The merge process could not be finalized, because command git push origin 16.0-ocabot-merge-pr-185-by-gurneyalex-bump-patch:16.0 failed with output:

To https://github.com/OCA/server-env
 ! [rejected]        16.0-ocabot-merge-pr-185-by-gurneyalex-bump-patch -> 16.0 (fetch first)
error: failed to push some refs to 'https://***@github.com/OCA/server-env'
hint: Updates were rejected because the remote contains work that you do
hint: not have locally. This is usually caused by another repository pushing
hint: to the same ref. You may want to first integrate the remote changes
hint: (e.g., 'git pull ...') before pushing again.
hint: See the 'Note about fast-forwards' in 'git push --help' for details.

@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 079d742. Thanks a lot for contributing to OCA. ❤️

gurneyalex added a commit to gurneyalex/server-env that referenced this pull request Jun 27, 2024
@gurneyalex
Revert PR OCA#185
6bf41d5 
Revert "server_environment: Fix value assignation in compute from default"

This reverts commit c92c0da.

This is breaking other modules using server environment.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajaniszewska-dev ajaniszewska-dev ajaniszewska-dev approved these changes

@sebalix sebalix sebalix approved these changes

@gurneyalex gurneyalex gurneyalex approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.
5 participants
@grindtildeath @gurneyalex @OCA-git-bot @sebalix @ajaniszewska-dev