[14.0] server_environment: Fix value assignation in compute from default #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajaniszewska-dev
approved these changes
Jun 21, 2024
sebalix
approved these changes
Jun 24, 2024
Since previous commit adding support for ssl certificate auth, field smtp_authentication in ir.mail_server, became a field managed by environment, when mail_environment is installed. This field has been defined using a default value relying on the compute_default property allowing to define a compute function, which matches the default value of the field. However, as the function _compute_server_env_from_default was broken, because it did not assign the computed value to the field, the field was empty and connection was broken.
grindtildeath
force-pushed
the
14.0-fix-server_env_compute_from_default
branch
from
6af35f5
to
cc56952
Compare
gurneyalex
approved these changes
Jun 24, 2024
gurneyalex
approved these changes
Jun 25, 2024
|
/ocabot merge patch |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
Congratulations, your PR was merged at 338be02. Thanks a lot for contributing to OCA. ❤️ |
gurneyalex
added a commit
to gurneyalex/server-env
that referenced
this pull request
Jun 27, 2024
Revert "server_environment: Fix value assignation in compute from default" This reverts commit cc56952. The fix is breaking other modules, the original problem must be fixed in mail_environment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport from #184