[FIX] server_environment: compute_default assign #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gurneyalex
force-pushed
the
15.0-revert-184
branch
from
c489546
to
98cb6b3
Compare
Revert "server_environment: Fix value assignation in compute from default" This reverts commit 8343e8c. The fix would break other addons using the feature. The original issue must be fixed in mail_environement.
gurneyalex
force-pushed
the
15.0-revert-184
branch
from
98cb6b3
to
e393aaa
Compare
gurneyalex
changed the title
|
see #194 for the proper fix |
JuMiSanAr
approved these changes
Jun 27, 2024
simahawk
approved these changes
Jun 27, 2024
|
/ocabot merge patch |
|
This PR looks fantastic, let's merge it! |
grindtildeath
approved these changes
Jun 27, 2024
|
Congratulations, your PR was merged at ec171c2. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert "server_environment: Fix value assignation in compute from default"
This reverts commit 8343e8c.