Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17.0][MIG] data_encryption: Migration to 17.0 #198

Merged
merged 31 commits into from
Nov 12, 2024
Merged

[17.0][MIG] data_encryption: Migration to 17.0 #198

merged 31 commits into from
Nov 12, 2024

Conversation

map-240221
Copy link

No description provided.

florian-dacosta and others added 29 commits August 19, 2024 09:36
@florian-dacosta @map-240221
[12.0] Add data_encryption
83853d8 
This module come from the previous module keychain. It has been heavely refactored
to be compatible with server_environment module. For this it has been split into
2 modules data_encryption and server_environment_data_encryption
@oca-travis @map-240221
[UPD] Update data_encryption.pot
e5f9636
@OCA-git-bot @map-240221
[UPD] README.rst
949b5f8
@OCA-git-bot @map-240221
[ADD] icon.png
7bc34e4
@ThomasBinsfeld @map-240221
[REF] data_encryption: Black python code
091aede
@ThomasBinsfeld @map-240221
[MIG] data_encryption: Migration to 13.0
135416f
@mourad-ehm @map-240221
[IMP] server_environment_data_encryption, data_encryption: black, iso…
477de0a 
…rt, prettier
@mourad-ehm @map-240221
[MIG] server_environment_data_encryption, data_encryption: Migration …
674c5c7 
…to 14.0

note: exclude tests/fixtures from pre-commit check
@oca-travis @map-240221
[UPD] Update data_encryption.pot
b11e59d
@OCA-git-bot @map-240221
[UPD] README.rst
ebeff6d
@extrememicro @map-240221
Added translation using Weblate (Catalan)
2fb0f9c
@florian-dacosta @map-240221
[IMP] data_encryption: black, isort, prettier
d2e51c7
@florian-dacosta @map-240221
[16][MIG] Migration of data_encryption
ba42bc7
@bealdav @map-240221
FIX data_encryption: typo
9b26a30
@map-240221
[UPD] Update data_encryption.pot
fbfb1c6
@OCA-git-bot @map-240221
[UPD] README.rst
61fe898
@marylla @map-240221
Added translation using Weblate (German)
c9d5284
@marylla @map-240221
Translated using Weblate (German)
f691b18 
Currently translated at 45.0% (9 of 20 strings)

Translation: server-env-16.0/server-env-16.0-data_encryption
Translate-URL: https://translation.odoo-community.org/projects/server-env-16-0/server-env-16-0-data_encryption/de/
@map-240221
[UPD] Update data_encryption.pot
72fb513
@weblate @map-240221
Update translation files
5b878ec 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: server-env-16.0/server-env-16.0-data_encryption
Translate-URL: https://translation.odoo-community.org/projects/server-env-16-0/server-env-16-0-data_encryption/
@bealdav @map-240221
FIX data_encryption: readme typo
a182fc0
@OCA-git-bot @map-240221
[UPD] README.rst
cde2bcd
@OCA-git-bot @map-240221
data_encryption 16.0.1.0.1
ac8e201
@Ivorra78 @map-240221
Added translation using Weblate (Spanish)
56a0977
@Ivorra78 @map-240221
Translated using Weblate (Spanish)
87e347e 
Currently translated at 100.0% (20 of 20 strings)

Translation: server-env-16.0/server-env-16.0-data_encryption
Translate-URL: https://translation.odoo-community.org/projects/server-env-16-0/server-env-16-0-data_encryption/es/
@OCA-git-bot @map-240221
[UPD] README.rst
3908ab7
@weblate @map-240221
Update translation files
e19df1b 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: server-env-16.0/server-env-16.0-data_encryption
Translate-URL: https://translation.odoo-community.org/projects/server-env-16-0/server-env-16-0-data_encryption/
@mymage @map-240221
Added translation using Weblate (Italian)
bfd8d7a
@mymage @map-240221
Translated using Weblate (Italian)
8db9f51 
Currently translated at 100.0% (20 of 20 strings)

Translation: server-env-16.0/server-env-16.0-data_encryption
Translate-URL: https://translation.odoo-community.org/projects/server-env-16-0/server-env-16-0-data_encryption/it/
@map-240221 map-240221 mentioned this pull request Aug 19, 2024
Open
6 tasks
@mkrnac
Copy link

mkrnac commented Sep 25, 2024

when this PR can be merged?

@pedrobaeza
Copy link
Member

It requires reviews: https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst#review

florian-dacosta
florian-dacosta approved these changes Sep 26, 2024
View reviewed changes
Copy link

@florian-dacosta florian-dacosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM code review.
I think you could squash the 2 last commits together though

@map-240221
Copy link
Author

Squashed the commits into one

@florian-dacosta
Copy link

Thanks

@moitabenfdz @bguillot Could you review please?

@hparfr
Copy link

hparfr commented Oct 21, 2024

please remove the pandoc file

hparfr
hparfr suggested changes Oct 21, 2024
View reviewed changes
Copy link

@hparfr hparfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pandoc-3.3-1-amd64.deb is in "[IMP] data_encryption: pre-commit auto fixes" commit

@map-240221
Copy link
Author

pandoc-3.3-1-amd64.deb is in "[IMP] data_encryption: pre-commit auto fixes" commit

Removed and changes squashed into the last commit

@pedrobaeza
Copy link
Member

That's not correct, as it was introduced in the commit "[IMP] data_encryption: pre-commit auto fixes", so you have the double diff, adding and removing it. You must do it in the previous commit.

@map-240221
Copy link
Author

Thanks for the correction. Rebased the last two commits and made the changes in the designated commit, hopefully no more technical (non-functionality) issues.

@pedrobaeza
Copy link
Member

Yes, that part is correct.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@hparfr
Copy link

hparfr commented Oct 24, 2024

Thanks @map-240221

@bguillot
Copy link

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 17.0-ocabot-merge-pr-198-by-bguillot-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit c61cdba into OCA:17.0 Nov 12, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 74e5955. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hparfr hparfr hparfr approved these changes

@florian-dacosta florian-dacosta florian-dacosta approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.