Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[11.0][FIX] server_environment: running_env default to test #46

Merged
merged 4 commits into from
Apr 16, 2020
Merged

[11.0][FIX] server_environment: running_env default to test #46

merged 4 commits into from
Apr 16, 2020

Conversation

alexey-pelykh
Copy link

Backport of #45

@alexey-pelykh
Copy link
Author

@pedrobaeza @simahawk seems right?

@alexey-pelykh
Copy link
Author

Runbot should fail due to this:

2020-04-15 17:52:04,141 173 WARNING openerp_test odoo.addons.server_environment.serv_config: `running_env` not found. Using default = `test`.
2020-04-15 17:52:04,141 173 WARNING openerp_test odoo.addons.server_environment.serv_config: We strongly recommend against using the rc file but instead use an explicit config file or env variable.

simahawk
simahawk approved these changes Apr 16, 2020
View reviewed changes
Copy link

@simahawk simahawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks Alexey

This was referenced Apr 16, 2020
Closed
Merged
@simahawk
Copy link

/ocabot merge patch

@pedrobaeza
Copy link
Member

Let's go for it for having it fixed

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 11.0-ocabot-merge-pr-46-by-simahawk-bump-patch, awaiting test results.

@pedrobaeza
Copy link
Member

haha, duplicated, I'm removing mine.

@simahawk
Copy link

hahah same time :D

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 11.0-ocabot-merge-pr-46-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Apr 16, 2020
@OCA-git-bot
Merge PR #46 into 11.0
cb1216b 
Signed-off-by pedrobaeza
@OCA-git-bot OCA-git-bot merged commit 75da59c into OCA:11.0 Apr 16, 2020
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 9e2b7eb. Thanks a lot for contributing to OCA. ❤️

@alexey-pelykh alexey-pelykh deleted the 11.0-fix-running_env branch April 16, 2020 12:30
@alexey-pelykh
Copy link
Author

Do we need same for v12?

@alexey-pelykh alexey-pelykh mentioned this pull request Apr 16, 2020
Merged
@sbidoul sbidoul mentioned this pull request Mar 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simahawk simahawk simahawk approved these changes

@bodedra bodedra bodedra approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@alexey-pelykh @simahawk @pedrobaeza @OCA-git-bot @bodedra