[FIX] database_cleanup: preserve spaces in quoted identifiers

database_cleanup/identifier_adapter.py

@@ -14,7 +14,7 @@ def __conform__(self, protocol):
 
     def getquoted(self):
         def is_identifier_char(c):
-            return c.isalnum() or c in ["_", "$"]
+            return c.isalnum() or c in (["_", "$", " "] if self.quote else ["_", "$"])
 
         format_string = '"%s"'
         if not self.quote:

database_cleanup/tests/__init__.py

@@ -3,6 +3,7 @@
 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html).
 from . import common
 from . import test_create_indexes
+from . import test_identifier_adapter
 from . import test_purge_columns
 from . import test_purge_data
 from . import test_purge_menus

database_cleanup/tests/test_identifier_adapter.py

@@ -0,0 +1,18 @@
+from odoo.tests import TransactionCase
+
+from odoo.addons.database_cleanup.identifier_adapter import IdentifierAdapter
+
+
+class TestIdentifierAdapter(TransactionCase):
+    def test_column_name_with_spaces(self):
+        """Spaces in column names are preserved except in unquoted identifiers."""
+        self.assertEqual(
+            self.env.cr.mogrify("%s", (IdentifierAdapter("snailmail_cover "),)),
+            b'"snailmail_cover "',
+        )
+        self.assertEqual(
+            self.env.cr.mogrify(
+                "%s", (IdentifierAdapter("snailmail_cover ", quote=False),)
+            ),
+            b"snailmail_cover",
+        )