Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIG] [10.0] base_user_role_history from 9.0 #2314

Open
wants to merge 2 commits into
base: 10.0
Choose a base branch
from

Conversation

FrancoMaxime
Copy link
Member

Migration of baser_user_role_history from 9.0
(related to #1683 )

@oca-clabot
Copy link

Hey @FrancoMaxime, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/cla
Here is a list of the users:

Appreciation of efforts,
OCA CLAbot

@FrancoMaxime
Copy link
Member Author

FrancoMaxime commented Mar 18, 2022

@sbidoul Bonjour Stéphane, pourrais tu regarder au runbot?

Merci

@sbidoul
Copy link
Member

sbidoul commented Mar 18, 2022

The error is

ERROR: Could not find a version that satisfies the requirement dns (from -r test-requirements.txt (line 3)) (from versions: none)
ERROR: No matching distribution found for dns (from -r test-requirements.txt (line 3))

That is because the letsencrypt addon on the 10.0 branch has dns in its external dependencies.
And dns is not a package that is available on PyPI, or rather, it is on PyPI but has no file to download.

I don't know which PyPI package is supposed to provide this dns external dependency.
@NL66278 @blyxxyz do you know ?

@NL66278
Copy link
Contributor

NL66278 commented Mar 18, 2022

@sbidoul The package is called dnspython

@sbidoul
Copy link
Member

sbidoul commented Mar 18, 2022

Thanks Ronald! A fix for that issue and a couple of other is in #2315.

Copy link
Member

@sbidoul sbidoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A minor remark about the copyright that which does not need changing. Otherwise LGTM

@sbidoul
Copy link
Member

sbidoul commented Mar 18, 2022

The runboat issue does not prevent merging.

@FrancoMaxime FrancoMaxime force-pushed the 10.0-mig-base_user_role_history branch from 496f566 to 2f133be Compare March 18, 2022 13:04
@oca-clabot
Copy link

Hey @FrancoMaxime,
We acknowledge that the following users have signed our Contributor License Agreement:

Appreciation of efforts,
OCA CLAbot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants