-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MIG] [10.0] base_user_role_history from 9.0 #2314
base: 10.0
Are you sure you want to change the base?
Conversation
Hey @FrancoMaxime, thank you for your Pull Request. It looks like some users haven't signed our Contributor License Agreement, yet.
Appreciation of efforts, |
@sbidoul Bonjour Stéphane, pourrais tu regarder au runbot? Merci |
The error is
That is because the I don't know which PyPI package is supposed to provide this |
@sbidoul The package is called dnspython |
Thanks Ronald! A fix for that issue and a couple of other is in #2315. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A minor remark about the copyright that which does not need changing. Otherwise LGTM
The runboat issue does not prevent merging. |
496f566
to
2f133be
Compare
Hey @FrancoMaxime, Appreciation of efforts, |
Migration of baser_user_role_history from 9.0
(related to #1683 )