[16.0][MIG] dbfilter_from_header #2450
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[MIG] migrate dbfilter_from_header to 10.0 I have also removed the ability to use HTTP_X_OPENERP_DBFILTER
updates were made in OCA#1137 by @TimLai125 and small lint fixes by @yelizariev
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-tools-13.0/server-tools-13.0-dbfilter_from_header Translate-URL: https://translation.odoo-community.org/projects/server-tools-13-0/server-tools-13-0-dbfilter_from_header/
|
Closing, I see there's another PR already. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The base
httprequestisn't passed todb_filter()anymore.Also, it looks like
http.requestsometimes is not bound - specifically in this call, so we may return multiple DBs in some cases. Unfortunately it looks non-trivial to cover properly.I think probably this will be fine. We've tested with several client sites.
It would be great if someone can test with their own setup also!