-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0][MIG] base_fontawesome #2462
Conversation
[UPD] Update base_fontawesome.pot
[UPD] Update base_fontawesome.pot [UPD] README.rst
[UPD] README.rst [UPD] Update base_fontawesome.pot [UPD] README.rst
[UPD] Update base_fontawesome.pot [UPD] README.rst Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-tools-13.0/server-tools-13.0-base_fontawesome Translate-URL: https://translation.odoo-community.org/projects/server-tools-13-0/server-tools-13-0-base_fontawesome/
/ocabot migration base_fontawesome CC : @simahawk, @etobella , @olgamarcocb |
Sorry @legalsylvain you are not allowed to mark the addon tobe migrated. To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons. If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the |
base_fontawesome/__manifest__.py
Outdated
@@ -5,7 +5,7 @@ | |||
{ | |||
"name": "Base Fontawesome", | |||
"summary": """Up to date Fontawesome resources.""", | |||
"version": "15.0.5.15.4", | |||
"version": "16.0.1.0.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We usually tried to keep the version of font awesome on the version of the module, but it is ok for me to change it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd stick to that rule
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed. I didn't know that rule. Thanks for your review.
(could be merged I guess now).
base_fontawesome/__manifest__.py
Outdated
@@ -5,7 +5,7 @@ | |||
{ | |||
"name": "Base Fontawesome", | |||
"summary": """Up to date Fontawesome resources.""", | |||
"version": "15.0.5.15.4", | |||
"version": "16.0.1.0.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd stick to that rule
/ocabot migration base_fontawesome |
Setting to 'Needs fixing' for the version number alignment. |
This PR has the |
- bump version to V16.0 - replace target due to the move of fontawesome from 'web/static/lib/fontawesome' to 'web/static/src/libs/fontawesome/' - remove obsolete file
bd3e892
to
c9474f7
Compare
/ocabot merge nobump |
On my way to merge this fine PR! |
Congratulations, your PR was merged at 6cdfb83. Thanks a lot for contributing to OCA. ❤️ |
Port
base_fontawesome
from 15.0 to 16.0remove useless file
adapt asset replacement to new location
DONT change the fontawesome. (still the 5.15.4, not the 6.2.0)
(I don't need it, but feel free to make a PR against mine, or a second PR once this one is merged).