Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][MIG] base_fontawesome #2462

Merged
merged 17 commits into from
Dec 5, 2022

Conversation

legalsylvain
Copy link
Contributor

Port base_fontawesome from 15.0 to 16.0

  • remove useless file

  • adapt asset replacement to new location

  • DONT change the fontawesome. (still the 5.15.4, not the 6.2.0)
    (I don't need it, but feel free to make a PR against mine, or a second PR once this one is merged).

@legalsylvain
Copy link
Contributor Author

/ocabot migration base_fontawesome

CC : @simahawk, @etobella , @olgamarcocb

@OCA-git-bot
Copy link
Contributor

Sorry @legalsylvain you are not allowed to mark the addon tobe migrated.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

@@ -5,7 +5,7 @@
{
"name": "Base Fontawesome",
"summary": """Up to date Fontawesome resources.""",
"version": "15.0.5.15.4",
"version": "16.0.1.0.1",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We usually tried to keep the version of font awesome on the version of the module, but it is ok for me to change it

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd stick to that rule

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed. I didn't know that rule. Thanks for your review.

(could be merged I guess now).

@@ -5,7 +5,7 @@
{
"name": "Base Fontawesome",
"summary": """Up to date Fontawesome resources.""",
"version": "15.0.5.15.4",
"version": "16.0.1.0.1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd stick to that rule

@simahawk
Copy link
Contributor

/ocabot migration base_fontawesome

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Nov 15, 2022
@OCA-git-bot OCA-git-bot mentioned this pull request Nov 15, 2022
33 tasks
@sebalix sebalix changed the title 16.0 mig base fontawesome [16.0][MIG] base_fontawesome Nov 17, 2022
@StefanRijnhart
Copy link
Member

Setting to 'Needs fixing' for the version number alignment.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

- bump version to V16.0
- replace target due to the move of fontawesome from 'web/static/lib/fontawesome' to 'web/static/src/libs/fontawesome/'
- remove obsolete file
@legalsylvain legalsylvain force-pushed the 16.0-mig-base_fontawesome branch from bd3e892 to c9474f7 Compare December 5, 2022 18:01
@etobella
Copy link
Member

etobella commented Dec 5, 2022

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-2462-by-etobella-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 26f2a23 into OCA:16.0 Dec 5, 2022
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 6cdfb83. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants