[MIG] base_view_inheritance_extension: Migration to 16.0 #2494

etobella · 2022-12-06T20:08:15Z

Migration to 16.0

Trivial changes: * Version in README changed * Version in manifest changed OCA Transbot updated translations from Transifex OCA Transbot updated translations from Transifex

…extension. (OCA#804) * Add list_add operation. * Add list_remove operation. OCA Transbot updated translations from Transifex

expression not match the node any more. Fixes OCA#885

* warning about dynamic context * import for safe_eval

Use https in URL to licence

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-tools-13.0/server-tools-13.0-base_view_inheritance_extension Translate-URL: https://translation.odoo-community.org/projects/server-tools-13-0/server-tools-13-0-base_view_inheritance_extension/

…d list_remove

* Removed `list_add` and `list_remove`, they've been deprecated and implemented in Odoo core since several versions ago. * Removed `move`, as it has also already been implemented in core several versions ago. * Replaced `python_dict` by `update`, that performs an operation similar to :meth:`dict.update`, but on the ast.Dict.

This fixes an error we could get if the attribute of the inherited tag has some extra carriage returns. Exception raised: SyntaxError: unexpected EOF while parsing

rven · 2022-12-06T20:15:25Z

Superseeded by #2495

It was not just enough to do the upgrade like @legalsylvain mentioned on Twitter.
The attributes where perfectly changed, but the demo view was not showing stuff correctly when creating a parent from the simple contact form.
I've changed the fields so it reflects them correctly when verifying it in the application.

etobella · 2022-12-06T22:00:51Z

@rven There is no issue in superseeding my PR, but I think some things must be followed before doing it:

When we superseed a PR, we are expecting an answer from the author and he does not answer.
We ask the author for supersseding and let him/her some time to answer (usually a week, but at least a day)
On a superseeding PRs, we keep original PR history and commits

So, if you want to superseed this PR, follow at least the last point, as there is no problem from my side in doing the superseed.

etobella · 2022-12-06T22:04:59Z

Meanwhile, I added your change 😉

etobella · 2022-12-06T22:18:01Z

/ocabot migration base_view_inheritance_extension

legalsylvain · 2022-12-06T23:00:20Z

It was not just enough to do the upgrade like @legalsylvain mentioned on Twitter.

? Which tweet ?

rven · 2022-12-07T06:04:03Z

It was not just enough to do the upgrade like @legalsylvain mentioned on Twitter.

? Which tweet ?

It wasn't yours it was https://twitter.com/alexisdlattre/status/1600095838700707840 :-)
I read it wrong, he didn't do any changes at all...
This happens when in the meantime watch football ;-)

rven · 2022-12-07T06:13:23Z

@rven There is no issue in superseeding my PR, but I think some things must be followed before doing it:

When we superseed a PR, we are expecting an answer from the author and he does not answer.

We ask the author for supersseding and let him/her some time to answer (usually a week, but at least a day)

On a superseeding PRs, we keep original PR history and commits

So, if you want to superseed this PR, follow at least the last point, as there is no problem from my side in doing the superseed.

@etobella It was just a timing issue of a couple minutes I guess, we both were working on the same migration at the same time :-)
I wasn't aware of the guidelines you mention. I only superseded your PR because mine was only completer (!= better) ;-).
I only superseded yours because it also happened to one of my PR's in the past, with the same reason.
Maybe it's a good thing to take notice of the superseding guidelines in the OCA guidelines?

When I started on the migration, there was no PR, no mentioning on the issue that someone was working on the migration as mentioned in the guidelines.

For me it's fine to leave this PR open, I'l close mine and approve yours, because I also verified it functionally 💯

The only thing I wan't is a happy community :-p

rven

Working fine!

Reviewed code and functionally tested 👍

etobella · 2022-12-07T06:18:14Z

I know it happened because we where too fast, for that reason I wasn't angry at all. It happens sometimes to everyone, don't worry. About the changes from your PR thanks for them 😁

etobella · 2022-12-07T06:19:52Z

It was not just enough to do the upgrade like @legalsylvain mentioned on Twitter.

? Which tweet ?

My fault, I confused github users, it was a tweet by @alexis-via 🥲

pedrobaeza · 2022-12-07T07:31:00Z

Please propose at https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst#github a section about how to act for doing pull requests and this protocol about superseding.

simahawk

Pure code review: LG

pedrobaeza · 2022-12-07T07:39:31Z

/ocabot merge nobump

OCA-git-bot · 2022-12-07T07:39:40Z

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-2494-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot · 2022-12-07T07:44:09Z

Congratulations, your PR was merged at 0957aa4. Thanks a lot for contributing to OCA. ❤️

alexis-via · 2022-12-08T07:53:04Z

Thank you very much for this migration.

In fact, I had done myself the same kind of "easy" migration of base_view_inheritance_extension with just an update of tests, but I had some crash with my port of account_invoice_transmit_method which depend on base_view_inheritance_extension, and I thought that the crash was caused by base_view_inheritance_extension v16. I eventually figured out that the crash was caused by a missing coma in a domain in a view of account_invoice_transmit_method !!! But the backtrace was so horrible that I thought the bug was in some low-level code like the code of base_view_inheritance_extension.

hbrunn and others added 30 commits December 6, 2022 20:24

[ADD] base_view_inheritance_extension

7cd2002

[base_view_inheritance_extension] Relicense to LGPL. (OCA#4)

30094d5

[MIG] base_view_inheritance_extension: Migration to 9.0

5a61880

Trivial changes: * Version in README changed * Version in manifest changed OCA Transbot updated translations from Transifex OCA Transbot updated translations from Transifex

[8.0][ADD] Add list manipulation operations to base_view_inheritance_…

126dab9

…extension. (OCA#804) * Add list_add operation. * Add list_remove operation. OCA Transbot updated translations from Transifex

[MIG] base_view_inheritance_extension to 10.0

2d4ba31

[FIX] don't break when an attribute node in an xpath makes the

135b9f2

expression not match the node any more. Fixes OCA#885

[FIX] base_view_inheritance_extension: 2 things:

896c2ae

* warning about dynamic context * import for safe_eval

[UPD] Update base_view_inheritance_extension.pot

bd9ce7c

[MIG] base_view_inheritance_extension: Migration to 11.0

7d27d9e

[UPD] Update base_view_inheritance_extension.pot

0e4e667

[MIG] base_view_inheritance_extension: Migration to 12.0

5ae9ffa

Remove the "move" feature which is now native

a27f029

Use https in URL to licence

[UPD] Update base_view_inheritance_extension.pot

50c7462

[UPD] README.rst

848ad96

[IMP] base_view_inheritance_extension: black, isort

45542a0

[MIG] base_view_inheritance_extension: Migration to v13.0

d1a9c49

[UPD] Update base_view_inheritance_extension.pot

32b2dfb

FIX: add missing params on function apply_inheritance_specs

e4bd835

base_view_inheritance_extension 13.0.1.0.1

e6a02a6

[MIG] base_view_inheritance_extension to v14

be24def

Fix apply inheritance specs on views (pre_locate)

434a40b

[UPD] Update base_view_inheritance_extension.pot

8c05707

[UPD] README.rst

df587ee

base_view_inheritance_extension 14.0.1.0.1

01532a0

[IMP] base_view_inheritance_extension: real python_dict

8e2e89b

[UPD] base_view_inheritance_extension: readme - deprecate list_add an…

f915726

…d list_remove

[UPD] README.rst

761b9d5

base_view_inheritance_extension 14.0.1.1.0

44871e1

sebalix and others added 4 commits December 6, 2022 20:24

[FIX] b_v_inheritance_extension: fix parsing of 'update' operation

a227c1e

This fixes an error we could get if the attribute of the inherited tag has some extra carriage returns. Exception raised: SyntaxError: unexpected EOF while parsing

base_view_inheritance_extension 15.0.1.0.2

836f683

[IMP] base_view_inheritance_extension: black, isort, prettier

29e3e5f

[MIG] base_view_inheritance_extension: Migration to 16.0

040320c

[MIG] base_view_inheritance_extension: Fix demo view

152af1a

etobella force-pushed the 16.0-mig-base_view branch from 34c358d to 152af1a Compare December 6, 2022 22:09

OCA-git-bot added this to the 16.0 milestone Dec 6, 2022

OCA-git-bot mentioned this pull request Dec 6, 2022

Migration to version 16.0 #2412

Open

33 tasks

rven approved these changes Dec 7, 2022

View reviewed changes

simahawk approved these changes Dec 7, 2022

View reviewed changes

OCA-git-bot added the approved label Dec 7, 2022

OCA-git-bot added the bot is merging ⏳ label Dec 7, 2022

OCA-git-bot merged commit ee2b883 into OCA:16.0 Dec 7, 2022

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Dec 7, 2022

etobella deleted the 16.0-mig-base_view branch December 7, 2022 08:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[MIG] base_view_inheritance_extension: Migration to 16.0 #2494

[MIG] base_view_inheritance_extension: Migration to 16.0 #2494

etobella commented Dec 6, 2022

rven commented Dec 6, 2022

etobella commented Dec 6, 2022 •

edited

Loading

etobella commented Dec 6, 2022

etobella commented Dec 6, 2022

legalsylvain commented Dec 6, 2022

rven commented Dec 7, 2022 •

edited

Loading

rven commented Dec 7, 2022 •

edited

Loading

rven left a comment

etobella commented Dec 7, 2022

etobella commented Dec 7, 2022

pedrobaeza commented Dec 7, 2022

simahawk left a comment

pedrobaeza commented Dec 7, 2022

OCA-git-bot commented Dec 7, 2022

OCA-git-bot commented Dec 7, 2022

alexis-via commented Dec 8, 2022

[MIG] base_view_inheritance_extension: Migration to 16.0 #2494

[MIG] base_view_inheritance_extension: Migration to 16.0 #2494

Conversation

etobella commented Dec 6, 2022

rven commented Dec 6, 2022

etobella commented Dec 6, 2022 • edited Loading

etobella commented Dec 6, 2022

etobella commented Dec 6, 2022

legalsylvain commented Dec 6, 2022

rven commented Dec 7, 2022 • edited Loading

rven commented Dec 7, 2022 • edited Loading

rven left a comment

Choose a reason for hiding this comment

etobella commented Dec 7, 2022

etobella commented Dec 7, 2022

pedrobaeza commented Dec 7, 2022

simahawk left a comment

Choose a reason for hiding this comment

pedrobaeza commented Dec 7, 2022

OCA-git-bot commented Dec 7, 2022

OCA-git-bot commented Dec 7, 2022

alexis-via commented Dec 8, 2022

etobella commented Dec 6, 2022 •

edited

Loading

rven commented Dec 7, 2022 •

edited

Loading

rven commented Dec 7, 2022 •

edited

Loading