Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][MIG] base_domain_inverse_function: Migrate to version 16.0 #2592

Merged
merged 3 commits into from
Jun 28, 2023

Conversation

sonhd91
Copy link

@sonhd91 sonhd91 commented Mar 23, 2023

@sonhd91 sonhd91 mentioned this pull request Mar 23, 2023
33 tasks
@sebalix sebalix added this to the 16.0 milestone Apr 5, 2023
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@grindtildeath
Copy link
Contributor

@sonhd91 Thanks for the mig. I did update the original PR with pre-commit improvements and fixing the test.

@gurneyalex
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-2592-by-gurneyalex-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request May 15, 2023
Signed-off-by gurneyalex
@OCA-git-bot
Copy link
Contributor

@gurneyalex your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-2592-by-gurneyalex-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@gurneyalex
Copy link
Member

There seems to be an issue in the tests https://github.com/OCA/server-tools/actions/runs/4980917389/jobs/8914445178#step:8:307 I'm not sure if it is related to another module that was merged in the meantime...

@sonhd91 can you rebase your PR?

@sonhd91 sonhd91 force-pushed the 16.0-mig-base_domain_inverse_function branch from 3dbfea8 to 250df30 Compare May 17, 2023 02:44
@sonhd91
Copy link
Author

sonhd91 commented May 17, 2023

There seems to be an issue in the tests https://github.com/OCA/server-tools/actions/runs/4980917389/jobs/8914445178#step:8:307 I'm not sure if it is related to another module that was merged in the meantime...

@sonhd91 can you rebase your PR?

reabase done, thanks
ping @gurneyalex

@sonhd91 sonhd91 force-pushed the 16.0-mig-base_domain_inverse_function branch 4 times, most recently from b0ed8a8 to 95d62a3 Compare May 19, 2023 08:43
@sonhd91 sonhd91 force-pushed the 16.0-mig-base_domain_inverse_function branch from 95d62a3 to 7d69242 Compare May 19, 2023 09:40
@hailangvn2023
Copy link

Good day @gurneyalex, the PR is now green for merging. Thanks in advance for your attention.

@gurneyalex
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-2592-by-gurneyalex-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 3e7b9cc into OCA:16.0 Jun 28, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at f4562f6. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants