[16.0][MIG] base_multi_image #2618

yibudak · 2023-04-26T08:45:57Z

No description provided.

See OCA/product-attribute#135 (comment).

…xisting attachment record + Fix the 'pre_init_hook_for_submodules()' hook to extract the images from the ir_attachment table for binary fields initialized with the 'attachment=True' parameter

…dule is uninstalled.

…dme example * Only except for ImportError * Fix note regarding need of hook use

* Update openerp to odoo * Bump versions * Installable to True

* Add catch in owner unlink to allow for image delete bypass via context

improve uninstall hook to move images from multi to single mode

Currently translated at 100.0% (48 of 48 strings) Translation: server-tools-14.0/server-tools-14.0-base_multi_image Translate-URL: https://translation.odoo-community.org/projects/server-tools-14-0/server-tools-14-0-base_multi_image/es_AR/

Currently translated at 58.3% (28 of 48 strings) Translation: server-tools-15.0/server-tools-15.0-base_multi_image Translate-URL: https://translation.odoo-community.org/projects/server-tools-15-0/server-tools-15-0-base_multi_image/it/

Currently translated at 64.5% (31 of 48 strings) Translation: server-tools-15.0/server-tools-15.0-base_multi_image Translate-URL: https://translation.odoo-community.org/projects/server-tools-15-0/server-tools-15-0-base_multi_image/sl/

Currently translated at 58.3% (28 of 48 strings) Translation: server-tools-15.0/server-tools-15.0-base_multi_image Translate-URL: https://translation.odoo-community.org/projects/server-tools-15-0/server-tools-15-0-base_multi_image/it/

clb-openfire · 2023-05-04T13:30:37Z

Hi,
To me this module has several problems that should be fixed (mentioned in #2601 ):

restrict the folders from which files can be read for security reasons, through the odoo config file.
fix hooks
remove "database" type of storage, which was actually storing in filestore since v13 anyway (I don't think that users can or should decide if files are stored in DB or in filestore)
remove "url" and "file" types of storage. image.mixin class stores all versions of images for performance reasons. I believe it would be even slower to get them from a file/remote url before resizing them. We should as well store everything in filestore. And by the way, restrict the size of those images, like it is done in base_import module, _import_image_by_url()
simplify the filestore type to make it work like the current database type.
adapt module to image.mixin (remove image_main, image_main_medium, etc. from owner)

I've done all that work already in the following fork if anyone interested: https://github.com/odof/server-tools/commits/16.0-base_multi_image

from OCA#2618 and odof@dae0f9a https://hive.versada.eu/projects/metalurga-upgrade/work_packages/21788/activity

thomaspaulb · 2024-08-09T09:56:34Z

Superseded by #3010 as well.

@clb-openfire We're going to try integrating your code, it looks like a lot of improvements.

Maybe you can give it a review once it's done?

Next time you can also just propose it yourself in a new PR.

clb-openfire · 2024-08-19T17:10:17Z

@thomaspaulb thanks, review done.
I wasn't confident enough to post a PR because a migration + rework seemed a lot to review, I'll be sure to do it next time.

yajo and others added 30 commits April 26, 2023 09:58

Split model in abstract & concrete.

874e1b9

Extend model example.

6b39c2f

Tenames and typos.

243143d

No default value for storage.

3ebb723

Do not require a name.

895fc92

Add sequence to images.

4643cf4

Reduce methods.

c0a9286

Cache images' URL.

dfa3012

Remove wrong copyright.

a8b56ac

Add known issues section.

d4e41ab

Fix bug that made previous images to disappear.

920f121

See OCA/product-attribute#135 (comment).

[MIG][9.0] base_multi_image

8ef1e47

[FIX] base_multi_image - New storage backend 'Filestore' to link an e…

947ed37

…xisting attachment record + Fix the 'pre_init_hook_for_submodules()' hook to extract the images from the ir_attachment table for binary fields initialized with the 'attachment=True' parameter

[IMP] base_multi_image - Select only images as attachments

c6fa135

[FIX] base_multi_image - Clean up + updated comments

1d37f98

[FIX] base_multi_image - Make validation error messages translatable

6603df7

[FIX] base_multi_image - Fix method name

2eeb63f

Use v9 ormcache.

65b9379

Add a reference field to get to the owner with 1 click.

a45270d

Add uninstall hook to avoid garbage images hanging around after submo…

3e0d0e9

…dule is uninstalled.

Raise version.

1bf861d

Add ondelete attribute, required for Many2one fields in v9.

5aa044b

[FIX] base_multi_image: Correct README instructions

bc72ec4

[FIX] remove en.po that was erroneously created by transbot

c01b24a

[FIX] adapt to changes in binary attachment branch

e73fc59

[MIG] Make modules uninstallable

fdc4592

[MIG] Rename manifest files

5725e1e

base_multi_image: Fix hook example * Add uninstall hook import to Rea…

39703db

…dme example * Only except for ImportError * Fix note regarding need of hook use

[MIG] base_multi_image: Upgrade to v10

23859ce

* Update openerp to odoo * Bump versions * Installable to True

[FIX] base_multi_image: Adhere to image delete bypass

0ccc401

* Add catch in owner unlink to allow for image delete bypass via context

lasley and others added 18 commits April 26, 2023 09:58

[10.0][FIX] base_multi_image: Uninstall hook (OCA#709)

02ee9dc

[10.0] [IMP] base_multi_image: improve uninstall hook (OCA#1286)

f1eea43

improve uninstall hook to move images from multi to single mode

[MIG] base_multi_image: Migration to 12.0

7c743fe

[FIX]base_multi_image: Fix image url in locales with thousand separator.

d591b23

[MIG][13.0]base_multi_image: Migrated to v13

c37c1a0

[IMP] base_multi_image: black, isort, prettier

20ef3ff

[MIG] base_multi_image: Migration to 14.0

299bb96

Translated using Weblate (Spanish (Argentina))

c227ca6

Currently translated at 100.0% (48 of 48 strings) Translation: server-tools-14.0/server-tools-14.0-base_multi_image Translate-URL: https://translation.odoo-community.org/projects/server-tools-14-0/server-tools-14-0-base_multi_image/es_AR/

[15.0][MIG] base_multi_image

0b5b432

[UPD] Update base_multi_image.pot

ece3590

[UPD] README.rst

2b95cb6

Translated using Weblate (Italian)

9aa270f

Currently translated at 58.3% (28 of 48 strings) Translation: server-tools-15.0/server-tools-15.0-base_multi_image Translate-URL: https://translation.odoo-community.org/projects/server-tools-15-0/server-tools-15-0-base_multi_image/it/

Translated using Weblate (Slovenian)

47743ee

Currently translated at 64.5% (31 of 48 strings) Translation: server-tools-15.0/server-tools-15.0-base_multi_image Translate-URL: https://translation.odoo-community.org/projects/server-tools-15-0/server-tools-15-0-base_multi_image/sl/

Translated using Weblate (Italian)

1d93249

Currently translated at 58.3% (28 of 48 strings) Translation: server-tools-15.0/server-tools-15.0-base_multi_image Translate-URL: https://translation.odoo-community.org/projects/server-tools-15-0/server-tools-15-0-base_multi_image/it/

Translated using Weblate (Italian)

5ee1077

Currently translated at 58.3% (28 of 48 strings) Translation: server-tools-15.0/server-tools-15.0-base_multi_image Translate-URL: https://translation.odoo-community.org/projects/server-tools-15-0/server-tools-15-0-base_multi_image/it/

[IMP] base_multi_image: pre-commit stuff

08ed4f0

[MIG] base_multi_image: Migration to 16.0

d39c0a3

[16.0][FIX] Authors as a string

2a59785

This was referenced Apr 26, 2023

Migration to version 16.0 #2412

Open

[16.0][MIG] product_multi_image OCA/product-attribute#1329

Closed

florian-dacosta mentioned this pull request Jul 25, 2023

[16.0][MIG] connector_prestashop OCA/connector-prestashop#173

Closed

florian-dacosta mentioned this pull request Sep 22, 2023

[16.0][MIG] base_multi_image #2716

Closed

AurelijaNorvaisaite added a commit to versada/server-tools that referenced this pull request Nov 13, 2023

[MIG] base_multi_image: init

cdcede2

from OCA#2618 and odof@dae0f9a https://hive.versada.eu/projects/metalurga-upgrade/work_packages/21788/activity

AurelijaNorvaisaite mentioned this pull request Nov 13, 2023

[MIG] base_multi_image: init versada/server-tools#10

Merged

thomaspaulb mentioned this pull request Aug 9, 2024

[16.0][MIG] base_multi_image #3010

Merged

thomaspaulb closed this Aug 9, 2024

yibudak deleted the 16.0-mig-base_multi_image branch November 25, 2024 10:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[16.0][MIG] base_multi_image #2618

[16.0][MIG] base_multi_image #2618

yibudak commented Apr 26, 2023

clb-openfire commented May 4, 2023

thomaspaulb commented Aug 9, 2024

clb-openfire commented Aug 19, 2024

[16.0][MIG] base_multi_image #2618

[16.0][MIG] base_multi_image #2618

Conversation

yibudak commented Apr 26, 2023

clb-openfire commented May 4, 2023

thomaspaulb commented Aug 9, 2024

clb-openfire commented Aug 19, 2024