Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][MIG] base_import_default_enable_tracking: Migration to 16.0 #3007

Merged
merged 5 commits into from
Nov 12, 2024
Merged

[16.0][MIG] base_import_default_enable_tracking: Migration to 16.0 #3007

merged 5 commits into from
Nov 12, 2024

Conversation

SirAionTech
Copy link
Contributor

@SirAionTech SirAionTech commented Aug 1, 2024 •
edited
Loading

@SirAionTech SirAionTech force-pushed the 16.0-mig-base_import_default_enable_tracking branch from 88954b4 to 9fe59d4 Compare August 1, 2024 09:45
@StefanRijnhart StefanRijnhart changed the title [MIG] base_import_default_enable_tracking: Migration to 16.0 [16.0][MIG] base_import_default_enable_tracking: Migration to 16.0 Aug 9, 2024
@StefanRijnhart StefanRijnhart added this to the 16.0 milestone Aug 9, 2024
StefanRijnhart
StefanRijnhart reviewed Aug 9, 2024
View reviewed changes
Copy link
Member

@StefanRijnhart StefanRijnhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A migration from 10 to 16! And yet so useful, thank you!

Can you improve the module description by stating this concerns the setting Track history during import that is only visible in debug mode?

@SirAionTech SirAionTech force-pushed the 16.0-mig-base_import_default_enable_tracking branch from 9fe59d4 to 7fbb693 Compare August 19, 2024 08:10
@SirAionTech
Copy link
Contributor Author

A migration from 10 to 16! And yet so useful, thank you!

Can you improve the module description by stating this concerns the setting Track history during import that is only visible in debug mode?

Thanks for your review!
Done

StefanRijnhart
StefanRijnhart approved these changes Aug 19, 2024
View reviewed changes
Copy link
Member

@StefanRijnhart StefanRijnhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update!

@SirAionTech
Copy link
Contributor Author

@OCA/tools-maintainers this has enough reviews, can someone please merge?

@thomaspaulb
Copy link
Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-3007-by-thomaspaulb-bump-nobump, awaiting test results.

@thomaspaulb
Copy link
Contributor

/ocabot migration base_import_default_enable_tracking

@OCA-git-bot OCA-git-bot mentioned this pull request Nov 12, 2024
Open
33 tasks
@SirAionTech
Copy link
Contributor Author

/ocabot merge nobump

Thanks 😄

@OCA-git-bot OCA-git-bot merged commit 69e0dfa into OCA:16.0 Nov 12, 2024
8 of 9 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at d0dc780. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StefanRijnhart StefanRijnhart StefanRijnhart approved these changes

Assignees
No one assigned
Labels
merged 🎉
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.
5 participants
@SirAionTech @thomaspaulb @OCA-git-bot @StefanRijnhart @benwillig