Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MIG] 9.0 - auditlog #603

Merged
merged 21 commits into from
Nov 22, 2016
Merged

[MIG] 9.0 - auditlog #603

merged 21 commits into from
Nov 22, 2016

Conversation

sebalix
Copy link
Contributor

@sebalix sebalix commented Nov 13, 2016

Supersedes #454 (no response)

Migration done following the instructions from the wiki + Cherry-picked the commits done by @holdenrehg in #454.

This was referenced Nov 13, 2016
Closed
Closed
@pedrobaeza
Copy link
Member

Thanks for the followup. Please squash all the "OCA Transbot" commits in one, and check Travis status.

@sebalix
Copy link
Contributor Author

sebalix commented Nov 13, 2016

Module tested on runbot (full log, fast log, user session, HTTP requests...), works like expected.

Travis fails on the database_cleanup module.

@sebalix
Copy link
Contributor Author

sebalix commented Nov 14, 2016

As soon as this module is merged I'll port it on 10.

@sebalix sebalix force-pushed the 9.0-mig-auditlog branch 4 times, most recently from 7c9ad7e to d2d6dfa Compare November 14, 2016 14:45
@sebalix
Copy link
Contributor Author

sebalix commented Nov 14, 2016

@pedrobaeza sorry I didn't see the lint errors, it's fixed now.

I also migrated the last methods to the new API, PR ready for reviews now.

pedrobaeza
pedrobaeza reviewed Nov 15, 2016
View reviewed changes
auditlog/models/autovacuum.py
records = self.env[data_model].search(
[('create_date', '<=', fields.Datetime.to_string(deadline))])
nb_records = len(records)
records.unlink()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we need to launch a real "VACUUM" here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not, but I would prefer in a new PR as it's a new feature.
About the VACUUM, I was thinking that Odoo already performs this operation through ir.autovacuum https://github.com/odoo/odoo/blob/9.0/openerp/addons/base/ir/ir_autovacuum.py but it's not a real VACUUM neither.

pedrobaeza
pedrobaeza approved these changes Nov 15, 2016
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Little comment, but overall 👍

lasley
lasley approved these changes Nov 22, 2016
View reviewed changes
Copy link
Contributor

@lasley lasley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sebalix - I agree with your eval that adding the actual vacuum should be a separate PR, which would also allow for easy backports

@lasley
Copy link
Contributor

lasley commented Nov 22, 2016

Travis is 🔴 but not on your module and I think it's been resolved already. Restarting build; this can be merged if 🍏

@lasley lasley added this to the 9.0 milestone Nov 22, 2016
@sebalix
Copy link
Contributor Author

sebalix commented Nov 22, 2016

PR rebased but it's failing on database_cleanup.

@pedrobaeza
Copy link
Member

This PR is supposed to fix it: #612

sebalix and others added 11 commits November 22, 2016 11:53
@sebalix
Module 'auditlog' - Log HTTP user sessions and requests
333d655
@sebalix
Module 'auditlog' - Bump the version to 1.1.0
0b387af
@sebalix
Module 'auditlog' - Cleanup XML views (types removed)
4b8c8a1
@sebalix
Module 'auditlog' - A log can be created with no current HTTP request…
2b2c583 
… (unit tests, ir.cron...)
@sebalix
Module 'auditlog' - 'display_name' fields added for the user session …
791489e 
…and HTTP requests models
@sebalix
Module 'auditlog' - Fix pylint check
872056c
@hbrunn @sebalix
turn off prefetching when reding values
a20cfbf
@sebalix
auditlog - Ability to choose the log type on the rule: Full log (comp…
043cf1b 
…lete but slow) and Fast log (data input only, faster)
@sebalix
auditlog - Field 'type' renamed to 'log_type'
38ed67b
@sebalix
auditlog - Bump version number
8897fe2
@sebalix
auditlog - Auto-vacuum logs, HTTP requests and HTTP user sessions
5aaf6d6
sebalix and others added 10 commits November 22, 2016 11:53
@sebalix
auditlog - Icon added + README updated (screenshots)
90ca923
@hbrunn @sebalix
singleton error if we saved the current session two times (OCA#473)
c4ca262 
* [IMP] index the columns we'll be searching for for every request

* [FIX] singleton error if we saved the current session two times
@oca-transbot @sebalix
OCA Transbot updated translations from Transifex
32adcba
@holdenrehg @sebalix
[MIG] Migrate auditlog module from 8.0 to 9.0
a8dd839 
- Update documentation to point to the new auditlog menu locations. These were changed because the 8.0 version was referencing menus that do not exist in 9.0
- Change version from 8.0.X.Y.Z to 9.0.1.0.0
- Make the module installable again
- Remove an unused parameter from pre-migration.py for versioning
- Fix typos and remove commented out blocks of code that were irrelevant
@holdenrehg @sebalix
[UPD] Updated the __openerp__.xml to include the license and images f…
de3b1ca 
…ields

These were updated to follow OCA conventions.

- License set to AGPL-3
- Images set to empty array
@holdenrehg @sebalix
[UPD] auditlog module, Remove duplicate license key from openerp config
80f22b9
@holdenrehg @sebalix
[DEL] auditlog: Remove migration from audittrail functionality, this …
60534d3 
…is not required for version 9
@holdenrehg @sebalix
[DEL] auditlog: Remove pre_init_hook reference from openerp, no pre_i…
2322d15 
…nit hook exists any more
@sebalix
[FIX] auditlog - Lint
479cecf
@sebalix
[FIX] auditlog - Migrate 'AuditlogRule.create' and 'AuditlogRule.writ…
29e1860 
…e' methods to the new API
@sebalix
Copy link
Contributor Author

sebalix commented Nov 22, 2016

Rebased to include #612 , Travis is now green

@pedrobaeza
Copy link
Member

OK, merging. Thanks for the PR.

@pedrobaeza pedrobaeza merged commit eac8c06 into OCA:9.0 Nov 22, 2016
SiesslPhillip pushed a commit to grueneerde/OCA-server-tools that referenced this pull request Nov 20, 2024
@bt-admin
Merge pull request OCA#603 from OCA/7.0
c7ec3a8 
Syncing from upstream OCA/server-tools (7.0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lasley lasley lasley approved these changes

@pedrobaeza pedrobaeza pedrobaeza approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
9.0
Development

Successfully merging this pull request may close these issues.
6 participants
@sebalix @pedrobaeza @lasley @hbrunn @oca-transbot @holdenrehg