[ADD] allow creating missing indexes and purging properties #736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Well, I don't see something out of scope to have a module base_index_manager. Module database_cleanup is very heavy to be installed (it even modifies the model unlink and so on) for only managing/creating new indexes. |
|
I hope people install |
|
Yes please! |
StefanRijnhart
approved these changes
Feb 15, 2017
hbrunn
changed the title
|
@pedrobaeza @StefanRijnhart I added commits to purge properties too. The reason to lump this together in the same PR is that we'd get a lot of conflicts with two PRs after the first one is merged |
NL66278
reviewed
Feb 20, 2017
database_cleanup/views/menu.xml
Outdated
| <field name="name">Create missing indexes</field> | ||
| <field name="sequence" eval="70" /> | ||
| <field name="action" ref="cleanup_create_indexes_wizard_action" /> | ||
| </record> |
There was a problem hiding this comment.
Is this not missing the parent_id element? This will create top level menu entry...
|
Apart from the remark on the menu entry for creating indexes looks good to me, and tested backported version on 8.0. That worked well. So basically 👍 |
|
@NL66278 thanks for the pointer. Please use github's review mechanism in the future, this makes the approvals machine readable and a few scripts and filters look at this rather than the text people write |
|
Looks like this was approved long ago. Merging |
ecino
pushed a commit
to CompassionCH/server-tools
that referenced
this pull request
Jul 10, 2017
* [ADD] allow creating missing indexes * [FIX] tests; installation * [ADD] allow purging properties * [ADD] missing file * [ADD] test purging properties * [ADD] missing parent_id for menu entry * [FIX] don't delete too many and wrong properties
ecino
pushed a commit
to CompassionCH/server-tools
that referenced
this pull request
Jul 10, 2017
* [ADD] allow creating missing indexes * [FIX] tests; installation * [ADD] allow purging properties * [ADD] missing file * [ADD] test purging properties * [ADD] missing parent_id for menu entry * [FIX] don't delete too many and wrong properties
hbrunn
added a commit
to hbrunn/server-tools
that referenced
this pull request
Oct 3, 2017
* [ADD] allow creating missing indexes * [FIX] tests; installation * [ADD] allow purging properties * [ADD] missing file * [ADD] test purging properties * [ADD] missing parent_id for menu entry * [FIX] don't delete too many and wrong properties
hbrunn
added a commit
to hbrunn/server-tools
that referenced
this pull request
Feb 13, 2018
* [ADD] allow creating missing indexes * [FIX] tests; installation * [ADD] allow purging properties * [ADD] missing file * [ADD] test purging properties * [ADD] missing parent_id for menu entry * [FIX] don't delete too many and wrong properties
mart-e
pushed a commit
to mart-e/server-tools
that referenced
this pull request
Oct 26, 2018
* [ADD] allow creating missing indexes * [FIX] tests; installation * [ADD] allow purging properties * [ADD] missing file * [ADD] test purging properties * [ADD] missing parent_id for menu entry * [FIX] don't delete too many and wrong properties
xhair
pushed a commit
to xhair/server-tools
that referenced
this pull request
Nov 3, 2018
* [ADD] allow creating missing indexes * [FIX] tests; installation * [ADD] allow purging properties * [ADD] missing file * [ADD] test purging properties * [ADD] missing parent_id for menu entry * [FIX] don't delete too many and wrong properties
mart-e
pushed a commit
to mart-e/server-tools
that referenced
this pull request
Apr 8, 2019
* [ADD] allow creating missing indexes * [FIX] tests; installation * [ADD] allow purging properties * [ADD] missing file * [ADD] test purging properties * [ADD] missing parent_id for menu entry * [FIX] don't delete too many and wrong properties
mart-e
pushed a commit
to mart-e/server-tools
that referenced
this pull request
May 10, 2019
* [ADD] allow creating missing indexes * [FIX] tests; installation * [ADD] allow purging properties * [ADD] missing file * [ADD] test purging properties * [ADD] missing parent_id for menu entry * [FIX] don't delete too many and wrong properties
mart-e
pushed a commit
to mart-e/server-tools
that referenced
this pull request
May 29, 2019
* [ADD] allow creating missing indexes * [FIX] tests; installation * [ADD] allow purging properties * [ADD] missing file * [ADD] test purging properties * [ADD] missing parent_id for menu entry * [FIX] don't delete too many and wrong properties
StephaneMangin
pushed a commit
to StephaneMangin/server-tools
that referenced
this pull request
Jan 12, 2021
* [ADD] allow creating missing indexes * [FIX] tests; installation * [ADD] allow purging properties * [ADD] missing file * [ADD] test purging properties * [ADD] missing parent_id for menu entry * [FIX] don't delete too many and wrong properties
Rad0van
pushed a commit
to Rad0van/server-tools
that referenced
this pull request
Jan 12, 2021
* [ADD] allow creating missing indexes * [FIX] tests; installation * [ADD] allow purging properties * [ADD] missing file * [ADD] test purging properties * [ADD] missing parent_id for menu entry * [FIX] don't delete too many and wrong properties
leemannd
pushed a commit
to leemannd/server-tools
that referenced
this pull request
Mar 19, 2021
* [ADD] allow creating missing indexes * [FIX] tests; installation * [ADD] allow purging properties * [ADD] missing file * [ADD] test purging properties * [ADD] missing parent_id for menu entry * [FIX] don't delete too many and wrong properties
leemannd
pushed a commit
to camptocamp/server-tools
that referenced
this pull request
May 31, 2021
* [ADD] allow creating missing indexes * [FIX] tests; installation * [ADD] allow purging properties * [ADD] missing file * [ADD] test purging properties * [ADD] missing parent_id for menu entry * [FIX] don't delete too many and wrong properties
StephaneMangin
pushed a commit
to StephaneMangin/server-tools
that referenced
this pull request
Sep 13, 2021
* [ADD] allow creating missing indexes * [FIX] tests; installation * [ADD] allow purging properties * [ADD] missing file * [ADD] test purging properties * [ADD] missing parent_id for menu entry * [FIX] don't delete too many and wrong properties
sebalix
pushed a commit
to sebalix/server-tools
that referenced
this pull request
Sep 23, 2021
* [ADD] allow creating missing indexes * [FIX] tests; installation * [ADD] allow purging properties * [ADD] missing file * [ADD] test purging properties * [ADD] missing parent_id for menu entry * [FIX] don't delete too many and wrong properties
leemannd
pushed a commit
to camptocamp/server-tools
that referenced
this pull request
Oct 18, 2021
* [ADD] allow creating missing indexes * [FIX] tests; installation * [ADD] allow purging properties * [ADD] missing file * [ADD] test purging properties * [ADD] missing parent_id for menu entry * [FIX] don't delete too many and wrong properties
leemannd
pushed a commit
to camptocamp/server-tools
that referenced
this pull request
Oct 19, 2021
* [ADD] allow creating missing indexes * [FIX] tests; installation * [ADD] allow purging properties * [ADD] missing file * [ADD] test purging properties * [ADD] missing parent_id for menu entry * [FIX] don't delete too many and wrong properties
damdam-s
pushed a commit
to damdam-s/server-tools
that referenced
this pull request
Dec 3, 2021
* [ADD] allow creating missing indexes * [FIX] tests; installation * [ADD] allow purging properties * [ADD] missing file * [ADD] test purging properties * [ADD] missing parent_id for menu entry * [FIX] don't delete too many and wrong properties
psugne
pushed a commit
to versada/server-tools
that referenced
this pull request
Dec 23, 2021
* [ADD] allow creating missing indexes * [FIX] tests; installation * [ADD] allow purging properties * [ADD] missing file * [ADD] test purging properties * [ADD] missing parent_id for menu entry * [FIX] don't delete too many and wrong properties
StephaneMangin
pushed a commit
to StephaneMangin/server-tools
that referenced
this pull request
Feb 1, 2022
* [ADD] allow creating missing indexes * [FIX] tests; installation * [ADD] allow purging properties * [ADD] missing file * [ADD] test purging properties * [ADD] missing parent_id for menu entry * [FIX] don't delete too many and wrong properties
damdam-s
pushed a commit
to damdam-s/server-tools
that referenced
this pull request
Apr 14, 2022
* [ADD] allow creating missing indexes * [FIX] tests; installation * [ADD] allow purging properties * [ADD] missing file * [ADD] test purging properties * [ADD] missing parent_id for menu entry * [FIX] don't delete too many and wrong properties
sebalix
pushed a commit
to camptocamp/server-tools
that referenced
this pull request
May 4, 2022
* [ADD] allow creating missing indexes * [FIX] tests; installation * [ADD] allow purging properties * [ADD] missing file * [ADD] test purging properties * [ADD] missing parent_id for menu entry * [FIX] don't delete too many and wrong properties
thomaspaulb
pushed a commit
to sunflowerit/server-tools
that referenced
this pull request
Aug 17, 2022
* [ADD] allow creating missing indexes * [FIX] tests; installation * [ADD] allow purging properties * [ADD] missing file * [ADD] test purging properties * [ADD] missing parent_id for menu entry * [FIX] don't delete too many and wrong properties
JoelZilli
pushed a commit
to adhoc-dev/server-tools
that referenced
this pull request
Nov 24, 2022
* [ADD] allow creating missing indexes * [FIX] tests; installation * [ADD] allow purging properties * [ADD] missing file * [ADD] test purging properties * [ADD] missing parent_id for menu entry * [FIX] don't delete too many and wrong properties
ajaniszewska-dev
pushed a commit
to ajaniszewska-dev/server-tools
that referenced
this pull request
Jan 4, 2023
* [ADD] allow creating missing indexes * [FIX] tests; installation * [ADD] allow purging properties * [ADD] missing file * [ADD] test purging properties * [ADD] missing parent_id for menu entry * [FIX] don't delete too many and wrong properties
yankinmax
pushed a commit
to yankinmax/server-tools
that referenced
this pull request
Feb 9, 2023
* [ADD] allow creating missing indexes * [FIX] tests; installation * [ADD] allow purging properties * [ADD] missing file * [ADD] test purging properties * [ADD] missing parent_id for menu entry * [FIX] don't delete too many and wrong properties
JasminSForgeFlow
pushed a commit
to ForgeFlow/server-tools
that referenced
this pull request
Jul 28, 2023
* [ADD] allow creating missing indexes * [FIX] tests; installation * [ADD] allow purging properties * [ADD] missing file * [ADD] test purging properties * [ADD] missing parent_id for menu entry * [FIX] don't delete too many and wrong properties
letzdoo-js
pushed a commit
to letzdoo-js/server-tools
that referenced
this pull request
Aug 25, 2023
* [ADD] allow creating missing indexes * [FIX] tests; installation * [ADD] allow purging properties * [ADD] missing file * [ADD] test purging properties * [ADD] missing parent_id for menu entry * [FIX] don't delete too many and wrong properties
alexeirivera87
pushed a commit
to archeti-org/server-tools
that referenced
this pull request
Sep 6, 2023
* [ADD] allow creating missing indexes * [FIX] tests; installation * [ADD] allow purging properties * [ADD] missing file * [ADD] test purging properties * [ADD] missing parent_id for menu entry * [FIX] don't delete too many and wrong properties
jjscarafia
pushed a commit
to adhoc-dev/server-tools
that referenced
this pull request
Oct 10, 2023
* [ADD] allow creating missing indexes * [FIX] tests; installation * [ADD] allow purging properties * [ADD] missing file * [ADD] test purging properties * [ADD] missing parent_id for menu entry * [FIX] don't delete too many and wrong properties
hbrunn
added a commit
to hbrunn/server-tools
that referenced
this pull request
Dec 23, 2023
* [ADD] allow creating missing indexes * [FIX] tests; installation * [ADD] allow purging properties * [ADD] missing file * [ADD] test purging properties * [ADD] missing parent_id for menu entry * [FIX] don't delete too many and wrong properties
augusto-weiss
pushed a commit
to adhoc-dev/server-tools
that referenced
this pull request
Jan 10, 2024
* [ADD] allow creating missing indexes * [FIX] tests; installation * [ADD] allow purging properties * [ADD] missing file * [ADD] test purging properties * [ADD] missing parent_id for menu entry * [FIX] don't delete too many and wrong properties
PieterPaulussen
pushed a commit
to The-O-Team/server-tools
that referenced
this pull request
Jul 18, 2024
* [ADD] allow creating missing indexes * [FIX] tests; installation * [ADD] allow purging properties * [ADD] missing file * [ADD] test purging properties * [ADD] missing parent_id for menu entry * [FIX] don't delete too many and wrong properties
nguyenminhchien
pushed a commit
to nguyenminhchien/server-tools
that referenced
this pull request
Sep 27, 2024
* [ADD] allow creating missing indexes * [FIX] tests; installation * [ADD] allow purging properties * [ADD] missing file * [ADD] test purging properties * [ADD] missing parent_id for menu entry * [FIX] don't delete too many and wrong properties
nguyenminhchien
pushed a commit
to nguyenminhchien/server-tools
that referenced
this pull request
Sep 27, 2024
* [ADD] allow creating missing indexes * [FIX] tests; installation * [ADD] allow purging properties * [ADD] missing file * [ADD] test purging properties * [ADD] missing parent_id for menu entry * [FIX] don't delete too many and wrong properties
nguyenminhchien
pushed a commit
to nguyenminhchien/server-tools
that referenced
this pull request
Oct 10, 2024
* [ADD] allow creating missing indexes * [FIX] tests; installation * [ADD] allow purging properties * [ADD] missing file * [ADD] test purging properties * [ADD] missing parent_id for menu entry * [FIX] don't delete too many and wrong properties
nguyenminhchien
pushed a commit
to nguyenminhchien/server-tools
that referenced
this pull request
Oct 21, 2024
* [ADD] allow creating missing indexes * [FIX] tests; installation * [ADD] allow purging properties * [ADD] missing file * [ADD] test purging properties * [ADD] missing parent_id for menu entry * [FIX] don't delete too many and wrong properties
SiesslPhillip
pushed a commit
to grueneerde/OCA-server-tools
that referenced
this pull request
Nov 20, 2024
Syncing from upstream OCA/server-tools (14.0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is not exactly a clean up operation in the sense of removing stuff, but in a broader sense of tidying up I think we can justify having this here. I wouldn't know to which other module to add this, and making this a standalone module seems a bit over the top to me