Skip to content

Commit

Permalink
Fixup! base_tier_validation
Browse files Browse the repository at this point in the history
Co-authored-by: Carlos Lopez <celm1990@hotmail.com>
  • Loading branch information
bosd and celm1990 committed Jan 11, 2024
1 parent 6232c83 commit 194f9a5
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions base_tier_validation/models/tier_validation.py
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ def _compute_has_comment(self):
for rec in self:
has_comment = rec.review_ids.filtered(
lambda r: r.status in ("waiting", "pending")
and (self.env.user in r.reviewer_ids)
and self.env.user in r.reviewer_ids
).mapped("has_comment")
rec.has_comment = True in has_comment

Expand Down Expand Up @@ -330,7 +330,7 @@ def _validate_tier(self, tiers=False):
waiting_reviews = tier_reviews.filtered(
lambda r: r.status == "waiting"
or r.approve_sequence_bypass
and (self.env.user in r.reviewer_ids)
and self.env.user in r.reviewer_ids
)
if waiting_reviews:
waiting_reviews.write(
Expand Down Expand Up @@ -449,7 +449,7 @@ def _rejected_tier(self, tiers=False):
tier_reviews = tiers or self.review_ids
user_reviews = tier_reviews.filtered(
lambda r: r.status in ("waiting", "pending")
and (self.env.user in r.reviewer_ids)
and self.env.user in r.reviewer_ids
)
user_reviews.write(
{
Expand Down Expand Up @@ -636,10 +636,10 @@ def _notify_review_available(self, tier_reviews):
and r.res_id == x.id
).mapped("reviewer_ids")
# Subscribe reviewers and notify
getattr(rec, subscribe)(
rec.message_subscribe(
partner_ids=users_to_notify.mapped("partner_id").ids
)
getattr(rec, post)(
rec.message_post(
subtype_xmlid=self._get_requested_notification_subtype(),
body=rec._notify_requested_review_body(),
)

0 comments on commit 194f9a5

Please sign in to comment.