Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIG] 15.0 base_technical_features #391

Merged
merged 45 commits into from
Nov 8, 2021

Conversation

JuMiSanAr
Copy link
Contributor

Migrate base_technical_features to 15.0

@simahawk simahawk mentioned this pull request Oct 19, 2021
34 tasks
@simahawk
Copy link
Contributor

@JuMiSanAr pls check the build

@simahawk
Copy link
Contributor

simahawk commented Oct 19, 2021

pre-commit is still 🔴
I think it's better if we run a sync from the OCA template 1st, then rebase here.

@simahawk
Copy link
Contributor

@JuMiSanAr I think you should drop your change on pre-commit conf and rebase on 15.0

StefanRijnhart and others added 24 commits October 19, 2021 13:54
Using new base model inheritance
Currently translated at 75.0% (6 of 8 strings)

Translation: server-ux-11.0/server-ux-11.0-base_technical_features
Translate-URL: https://translation.odoo-community.org/projects/server-ux-11-0/server-ux-11-0-base_technical_features/ar/
Currently translated at 75.0% (6 of 8 strings)

Translation: server-ux-11.0/server-ux-11.0-base_technical_features
Translate-URL: https://translation.odoo-community.org/projects/server-ux-11-0/server-ux-11-0-base_technical_features/da/
Currently translated at 100.0% (8 of 8 strings)

Translation: server-ux-11.0/server-ux-11.0-base_technical_features
Translate-URL: https://translation.odoo-community.org/projects/server-ux-11-0/server-ux-11-0-base_technical_features/es/
Currently translated at 100,0% (8 of 8 strings)

Translation: server-ux-11.0/server-ux-11.0-base_technical_features
Translate-URL: https://translation.odoo-community.org/projects/server-ux-11-0/server-ux-11-0-base_technical_features/ca/
Currently translated at 100.0% (8 of 8 strings)

Translation: server-ux-12.0/server-ux-12.0-base_technical_features
Translate-URL: https://translation.odoo-community.org/projects/server-ux-12-0/server-ux-12-0-base_technical_features/it/
Updated by Update PO files to match POT (msgmerge) hook in Weblate.
Currently translated at 100.0% (8 of 8 strings)

Translation: server-ux-12.0/server-ux-12.0-base_technical_features
Translate-URL: https://translation.odoo-community.org/projects/server-ux-12-0/server-ux-12-0-base_technical_features/it/
Currently translated at 100.0% (8 of 8 strings)

Translation: server-ux-12.0/server-ux-12.0-base_technical_features
Translate-URL: https://translation.odoo-community.org/projects/server-ux-12-0/server-ux-12-0-base_technical_features/pt/
Currently translated at 100.0% (8 of 8 strings)

Translation: server-ux-12.0/server-ux-12.0-base_technical_features
Translate-URL: https://translation.odoo-community.org/projects/server-ux-12-0/server-ux-12-0-base_technical_features/zh_CN/
Currently translated at 100.0% (8 of 8 strings)

Translation: server-ux-12.0/server-ux-12.0-base_technical_features
Translate-URL: https://translation.odoo-community.org/projects/server-ux-12-0/server-ux-12-0-base_technical_features/pt_BR/
Currently translated at 87.5% (7 of 8 strings)

Translation: server-ux-12.0/server-ux-12.0-base_technical_features
Translate-URL: https://translation.odoo-community.org/projects/server-ux-12-0/server-ux-12-0-base_technical_features/hr/
Copy link

@CasVissers-360ERP CasVissers-360ERP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional test.

@CasVissers-360ERP
Copy link

@JuMiSanAr
I get an error when installing new modules after installing:

  File "/Users/360erp/PycharmProjects/customer/community/base_technical_features/models/res_users.py", line 54, in __init__
    type(self).SELF_READABLE_FIELDS += [
Exception

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/Users/360erp/PycharmProjects/customer/odoo-15.0/odoo/http.py", line 643, in _handle_exception
    return super(JsonRequest, self)._handle_exception(exception)
  File "/Users/360erp/PycharmProjects/customer/odoo-15.0/odoo/http.py", line 301, in _handle_exception
    raise exception.with_traceback(None) from new_cause
TypeError: unsupported operand type(s) for +=: 'property' and 'list

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@simahawk
Copy link
Contributor

simahawk commented Nov 2, 2021

merge build failed w/

Error: reserveCache failed: Cache already exists. Scope: refs/heads/15.0-ocabot-merge-pr-391-by-simahawk-bump-nobump, Key: pre-commit-2-e61b05bccdb35a39be54b14e484996ab8f741257e3664b23cd4e167bcf9277cc-fbf4a408bf120b50899bf0e59355141f0e1e3a98ebc748ccf9df3a735f209967, Version: 28cdb9f5496f334116f23e86f0063f5d3a9348c2e22425a33171e071aadada7e

I'll try again later.
@JuMiSanAr can you check #391 (comment) ?

@JuMiSanAr JuMiSanAr force-pushed the 14.0-mig-base_technical_features branch from fc0fddd to 563e594 Compare November 2, 2021 14:18
@simahawk
Copy link
Contributor

simahawk commented Nov 2, 2021

@BernatPForgeFlow can you check again pls?

Copy link

@CasVissers-360ERP CasVissers-360ERP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good now 👍

@pedrobaeza pedrobaeza added this to the 15.0 milestone Nov 8, 2021
@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 15.0-ocabot-merge-pr-391-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Nov 8, 2021
Signed-off-by pedrobaeza
@OCA-git-bot
Copy link
Contributor

@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 15.0-ocabot-merge-pr-391-by-pedrobaeza-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

1 similar comment
@OCA-git-bot
Copy link
Contributor

@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 15.0-ocabot-merge-pr-391-by-pedrobaeza-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 15.0-ocabot-merge-pr-391-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 519ea07 into OCA:15.0 Nov 8, 2021
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 03df3eb. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.