Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[15.0][MIG] base_tier_validation #424

Merged
merged 95 commits into from
Dec 22, 2021
Merged

[15.0][MIG] base_tier_validation #424

merged 95 commits into from
Dec 22, 2021

Conversation

JasminSForgeFlow
Copy link
Contributor

Standard Migration
@ForgeFlow

LoisRForgeFlow and others added 13 commits December 20, 2021 14:58
@LoisRForgeFlow @JasminSForgeFlow
[9.0][ADD] base_tier_validation
2cc99ec
@LoisRForgeFlow @JasminSForgeFlow
fix: blocking unneded records
f70f900
@LoisRForgeFlow @JasminSForgeFlow
[9.0][IMP] base_tier_validation: tries automatically request validati…
7c31e96 
…on and validate if possible.
@LoisRForgeFlow @JasminSForgeFlow
[9.0][IMP] base_tier_validation: filter out reviews not pending
538f89a
@LoisRForgeFlow @JasminSForgeFlow
make possible to filter by validated records
7112e13
@LoisRForgeFlow @JasminSForgeFlow
allow to add exceptions for fields that can be written on under valid…
0ab6041 
…ation records
@LoisRForgeFlow @JasminSForgeFlow
[9.0][IMP] base_tier_validation:
6be1523 
* able to restart validation
* sudo() not needed anymore
@LoisRForgeFlow @JasminSForgeFlow
[10.0][MIG] base_tier_validation
9668f3a
@LoisRForgeFlow @JasminSForgeFlow
[11.0][MIG] base_tier_validation
fb2889e
@LoisRForgeFlow @JasminSForgeFlow
[11.0][IMP] base_tier_validation: add tests
025db11
@JordiBForgeFlow @JasminSForgeFlow
add 'can_review' to tier.validation so that the buttons approve
249631b 
and reject can be hidden according to this computed field.
@LoisRForgeFlow @JasminSForgeFlow
[11.0][IMP] base_tier_validation: enhance views and register who does…
c6ab71c 
… and who asks for reviews in new fields 'done_by' and 'requested_by'.
@AdriaGForgeFlow @JasminSForgeFlow
[11.0][FIX] base_tier_validation
0e62dd8
@LoisRForgeFlow
Copy link
Contributor

/ocabot migration base_tier_validation

@OCA-git-bot OCA-git-bot added this to the 15.0 milestone Dec 21, 2021
@OCA-git-bot OCA-git-bot mentioned this pull request Dec 21, 2021
Closed
34 tasks
etobella
etobella approved these changes Dec 21, 2021
View reviewed changes
Copy link
Member

@etobella etobella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems straightforward. Can you squash administrative commits?

AdriaGForgeFlow and others added 13 commits December 22, 2021 14:55
@AdriaGForgeFlow @JasminSForgeFlow
Add name attribute to filter
d50ee57
@JasminSForgeFlow
[MIG] base_tier_validation: Migration to 12.0
56dfcc1
@OCA-git-bot @JasminSForgeFlow
[ADD] icon.png
667cab4
@AdriaGForgeFlow @JasminSForgeFlow
[11.0][IMP] base_tier_validation
8f51006 
fixup and extend tests

[ADD] systray icon for pending reviews

[FIX] Remove python safe_eval

[ADD] base_tier_validation_formula and migration scripts

[ADD] widget domain and python expression to define reviewer in tier definition

[ADD] auto updating of systray icon counter

[ADD] validation date field

[ADD] review widget dropdown menu
@etobella @JasminSForgeFlow
[IMP] base_tier_validation: Pass parameters as functions
4be333b
@etobella @JasminSForgeFlow
[IMP] base_tier_validation: Add a chatter message if the model has it
ba28a93
@LoisRForgeFlow @JasminSForgeFlow
[11.0][FIX] base_tier_validation: make name translatable and display …
bc689c2 
…reviews' name and state correctly translated.
@LoisRForgeFlow @JasminSForgeFlow
[11.0][UPD] base_tier_validation: roadmap.
f679af3 
* using similar approach to activities has already benn addressed.
* add a new point explaining review tooltip improvement possibilities.
@LoisRForgeFlow @JasminSForgeFlow
[12.0][MIG] base_tier_validation: adapt systray to v12.
c038838
@LoisRForgeFlow @JasminSForgeFlow
Added translation using Weblate (Spanish)
fb358e7
@LoisRForgeFlow @JasminSForgeFlow
Translated using Weblate (Spanish)
83cce08 
Currently translated at 100.0% (59 of 59 strings)

Translation: server-ux-12.0/server-ux-12.0-base_tier_validation
Translate-URL: https://translation.odoo-community.org/projects/server-ux-12-0/server-ux-12-0-base_tier_validation/es/
@AdriaGForgeFlow @JasminSForgeFlow
[12.0][FIX] dropdown style width and position
787cab2
@AdriaGForgeFlow @JasminSForgeFlow
[12.0][IMP] base_tier_validation module
dfc2db9
newtratip and others added 17 commits December 22, 2021 14:57
@newtratip @JasminSForgeFlow
[14.0][ENH] Nootification message on restart tier
bb4f417
@JordiBForgeFlow @JasminSForgeFlow
[FIX] base_tier_validation: avoid singleton error
06af8e0
@MateuGForgeFlow @JasminSForgeFlow
[14.0][IMP] base_tier_validation: add new review type
43394d9
@alessandro-fiorino @JasminSForgeFlow
Added translation using Weblate (Italian)
fc433ae
@alessandro-fiorino @JasminSForgeFlow
Translated using Weblate (Italian)
c2774fe 
Currently translated at 47.8% (45 of 94 strings)

Translation: server-ux-14.0/server-ux-14.0-base_tier_validation
Translate-URL: https://translation.odoo-community.org/projects/server-ux-14-0/server-ux-14-0-base_tier_validation/it/
@alessandro-fiorino @JasminSForgeFlow
Translated using Weblate (Italian)
5a04c79 
Currently translated at 89.3% (84 of 94 strings)

Translation: server-ux-14.0/server-ux-14.0-base_tier_validation
Translate-URL: https://translation.odoo-community.org/projects/server-ux-14-0/server-ux-14-0-base_tier_validation/it/
@alan196 @JasminSForgeFlow
Added translation using Weblate (Spanish (Mexico))
92b0160
@alan196 @JasminSForgeFlow
Translated using Weblate (Spanish (Mexico))
25d1194 
Currently translated at 1.0% (1 of 94 strings)

Translation: server-ux-14.0/server-ux-14.0-base_tier_validation
Translate-URL: https://translation.odoo-community.org/projects/server-ux-14-0/server-ux-14-0-base_tier_validation/es_MX/
@alan196 @JasminSForgeFlow
Translated using Weblate (Spanish (Mexico))
5000f25 
Currently translated at 100.0% (94 of 94 strings)

Translation: server-ux-14.0/server-ux-14.0-base_tier_validation
Translate-URL: https://translation.odoo-community.org/projects/server-ux-14-0/server-ux-14-0-base_tier_validation/es_MX/
@AdriaGForgeFlow @JasminSForgeFlow
[13.0][IMP] base_tier_validation: review_user_count perfromance
a9f2618
@kittiu @JasminSForgeFlow
[14.0][IMP] base_tier_validation, add tier description on stripe
7a19904
@kittiu @JasminSForgeFlow
[14.0][ENH] base_tier_validation, add configuration
706d8d8
@simonstromb @JasminSForgeFlow
Added translation using Weblate (Swedish)
b49f74d
@simonstromb @JasminSForgeFlow
Translated using Weblate (Swedish)
6288ca6 
Currently translated at 80.1% (85 of 106 strings)

Translation: server-ux-14.0/server-ux-14.0-base_tier_validation
Translate-URL: https://translation.odoo-community.org/projects/server-ux-14-0/server-ux-14-0-base_tier_validation/sv/
@simonstromb @JasminSForgeFlow
Translated using Weblate (Swedish)
13689e9 
Currently translated at 97.1% (103 of 106 strings)

Translation: server-ux-14.0/server-ux-14.0-base_tier_validation
Translate-URL: https://translation.odoo-community.org/projects/server-ux-14-0/server-ux-14-0-base_tier_validation/sv/
@JasminSForgeFlow
[IMP] base_tier_validation: black, isort, prettier
3588df8
@JasminSForgeFlow
[MIG] base_tier_validation: Migration to 15.0
2ef314a
@JasminSForgeFlow JasminSForgeFlow force-pushed the 15.0-mig-base_tier_validation branch from a68c581 to 2ef314a Compare December 22, 2021 09:28
LoisRForgeFlow
LoisRForgeFlow approved these changes Dec 22, 2021
View reviewed changes
Copy link
Contributor

@LoisRForgeFlow LoisRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, works fine! 👍

@LoisRForgeFlow
Copy link
Contributor

@etobella can you check commit history?, it is much leaner now!

etobella
etobella approved these changes Dec 22, 2021
View reviewed changes
Copy link
Member

@etobella etobella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for me! 👍 Thanks

@LoisRForgeFlow
Copy link
Contributor

Let's go!

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 15.0-ocabot-merge-pr-424-by-LoisRForgeFlow-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 2cb6883 into OCA:15.0 Dec 22, 2021
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 627854d. Thanks a lot for contributing to OCA. ❤️

@LoisRForgeFlow LoisRForgeFlow deleted the 15.0-mig-base_tier_validation branch December 22, 2021 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LoisRForgeFlow LoisRForgeFlow LoisRForgeFlow approved these changes

@etobella etobella etobella approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
15.0
Development

Successfully merging this pull request may close these issues.