Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[15.0][MIG] base_cancel_confirm : Migration to 15.0 #455

Closed

Conversation

moaadbourhim
Copy link

No description provided.

@rafaelbn
Copy link
Member

/ocabot migration base_cancel_confirm

@OCA-git-bot
Copy link
Contributor

Sorry @rafaelbn you are not allowed to mark the addon tobe migrated.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

@moaadbourhim
Copy link
Author

@kittiu Can you please review this PR

@kittiu
Copy link
Member

kittiu commented Feb 25, 2022

Looks like there are still some test error. Can you check please.

@jwaes
Copy link
Contributor

jwaes commented Mar 2, 2022

Looks like there are still some test error. Can you check please.

These tests seem to fail in all PR with migrations to 15.0

@CasVissers-360ERP
Copy link

@moaadbourhim I get a traceback

RPC_ERROR
Odoo Server Error
Traceback (most recent call last):
  File "/home/odoo/src/odoo/odoo/addons/base/models/ir_http.py", line 237, in _dispatch
    result = request.dispatch()
  File "/home/odoo/src/odoo/odoo/http.py", line 688, in dispatch
    result = self._call_function(**self.params)
  File "/home/odoo/src/odoo/odoo/http.py", line 360, in _call_function
    return checked_call(self.db, *args, **kwargs)
  File "/home/odoo/src/odoo/odoo/service/model.py", line 94, in wrapper
    return f(dbname, *args, **kwargs)
  File "/home/odoo/src/odoo/odoo/http.py", line 349, in checked_call
    result = self.endpoint(*a, **kw)
  File "/home/odoo/src/odoo/odoo/http.py", line 917, in __call__
    return self.method(*args, **kw)
  File "/home/odoo/src/odoo/odoo/http.py", line 536, in response_wrap
    response = f(*args, **kw)
  File "/home/odoo/src/odoo/addons/web/controllers/main.py", line 1348, in call_kw
    return self._call_kw(model, method, args, kwargs)
  File "/home/odoo/src/odoo/addons/web/controllers/main.py", line 1340, in _call_kw
    return call_kw(request.env[model], method, args, kwargs)
  File "/home/odoo/src/odoo/odoo/api.py", line 460, in call_kw
    result = _call_kw_model(method, model, args, kwargs)
  File "/home/odoo/src/odoo/odoo/api.py", line 433, in _call_kw_model
    result = method(recs, *args, **kwargs)
  File "/home/odoo/src/odoo/odoo/models.py", line 1629, in load_views
    result['fields_views'] = {
  File "/home/odoo/src/odoo/odoo/models.py", line 1630, in <dictcomp>
    v_type: self.fields_view_get(v_id, v_type if v_type != 'list' else 'tree',
  File "/home/odoo/src/user/community14/brand/models/res_brand_mixin.py", line 68, in fields_view_get
    result = super(ResBrandMixin, self).fields_view_get(
  File "/home/odoo/src/user/community/base_cancel_confirm/model/base_cancel_confirm.py", line 60, in fields_view_get
    new_arch, new_fields = View.postprocess_and_fields(doc, self._name)
  File "/home/odoo/src/odoo/odoo/addons/base/models/ir_ui_view.py", line 1020, in postprocess_and_fields
    name_manager = self._postprocess_view(node, model or self.model)
  File "/home/odoo/src/odoo/odoo/addons/base/models/ir_ui_view.py", line 1067, in _postprocess_view
    transfer_node_to_modifiers(node, node_info['modifiers'], self._context)
  File "/home/odoo/src/odoo/odoo/addons/base/models/ir_ui_view.py", line 88, in transfer_node_to_modifiers
    modifiers.update(ast.literal_eval(attrs))
  File "/usr/lib/python3.8/ast.py", line 99, in literal_eval
    return _convert(node_or_string)
  File "/usr/lib/python3.8/ast.py", line 84, in _convert
    return set(map(_convert, node.elts))
Exception

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/home/odoo/src/odoo/odoo/http.py", line 644, in _handle_exception
    return super(JsonRequest, self)._handle_exception(exception)
  File "/home/odoo/src/odoo/odoo/http.py", line 302, in _handle_exception
    raise exception.with_traceback(None) from new_cause
TypeError: unhashable type: 'dict'

@CasVissers-360ERP
Copy link

@moaadbourhim Did you check my message?

@kittiu
Copy link
Member

kittiu commented Jun 13, 2022

In addition, there are improvement in v14, you may want to consider including it here,
#497

@github-actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Oct 16, 2022
@github-actions github-actions bot closed this Nov 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants