[15.0][MIG] base_tier_validation_waiting

[bosd]

Depends on:
#732 Do not sent double messages on the first validation sequence

[bosd]

/ocabot migration base_tier_validation_waiting

[OCA-git-bot]

Sorry @bosd you are not allowed to mark the addon tobe migrated.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

[simahawk]

/ocabot migration base_tier_validation_waiting

[simahawk]

LG minor comments

[bosd]

@cwjoalder Can you please review?

[bosd]

@simahawk Can you review the changes? 🙏

[bosd]

Force pushed to recreate runboat

[bosd]

@Dranyel-Bosd Can you please review?

[Dranyel-Bosd]

looks so good to me 👍 🎇

[simahawk]

I'm not sure I get this IF block: in any case you set "pending" -> can't you have 1 single check?

[bosd]

@simahawk Thanks for your review!

I'm working my way towards more coverage and green tests 😁
Adding coverage by testing the notifications.
But it's breaking/affecting tests of other modules.
Added the fixes for those in this PR. Is that allowed/correct OCA procedure?

I've watched your talks about the unittests.
Still I'm struggling with getting how to get the tier_validation_server_action fixed.

This module is altering the behaviour by adding the state waiting, which results in breaking the tests of server action.
When this module is installed, an alternative version of tests should be run by that module. Is that correct?
Can you explain how to do that? 😊 🙏

===================================================================== 
2023-10-23 07:04:27,754 1037 ERROR odoo odoo.addons.base_tier_validation_server_action.tests.test_tier_validation: FAIL: TierTierValidation.test_1_auto_validation
Traceback (most recent call last):
  File "/__w/server-ux/server-ux/base_tier_validation_server_action/tests/test_tier_validation.py", line 100, in test_1_auto_validation
    self.assertEqual(
AssertionError: Lists differ: ['waiting', 'waiting', 'waiting'] != ['pending', 'pending', 'pending']

First differing element 0:
'waiting'
'pending'

- ['waiting', 'waiting', 'waiting']
+ ['pending', 'pending', 'pending']
 

[DavidJForgeFlow]

from odoo import api, fields, models
from odoo.tools import config


class TierReview(models.Model):
    _inherit = "tier.review"


    def _default_status(self):
        if not config["test_enable"] or config["test_enable"] and self.env.context.get("_testing_base_tier_validationwaiting"):
            self.status = "waiting"
        else:
            self.status = "pending"
        
    status = fields.Selection(
        selection_add=[("waiting", "Waiting")],
        default="_default_status",
        ondelete={"waiting": "set default"},
    )

Maybe this helps to work with the other module

[Dranyel-Bosd]

LGTM 👍

[bosd]

Dropped the dependency on 732. Now we finally have green tests ✔️
✨ 🎉

[simahawk]

do we really need this specific check for tests?

[bosd]

Yes, without this commit, it would mean that we need to patch a lot of depending modules, to fix their tests.

Another solution I've evaluated is using seperate tests. That might solve the problem with the CI tests here on github.
But it would simply transfer the problem to the persons running an custom CI like odoo.sh.

The method here is not really clean. But it's the least dirty solution.
(Discussed this test issue with a couple of oca contributors at the OXP)
Maybe you have another insight to solve this problem?

[simahawk]

use lambda to not reference the method object directly

[github-actions]

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.