[16.0] [MIG] base_export_manager: Migration to 16.0 #649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Improve UX for base_export_manager. - Improve user instructions in README. - Require some required fields. - Allow to select models from a list. - Allow to select up to 3 fields from dynamic lists. - Improve translations. - More tests. - Translate column labels. Some methods have been renamed, so version tag is raised to 8.0.2.0.0. * Make inverse method be called at view time. * Hardcode constraints in the `create` method instead of using normal ones. Depending on the context where the record is created, it gets `resource` or `model_id`. The problem is that Odoo checks constrains before inverses, so constrains would fail always. Test added to ensure future versions contemplate all use cases. * Allow to reorder fields.
* Upgrade base_export_manager to v9 * Rename JS to base_export_manager
* Change osv_memory to transient for model_id domain
* Improve UX for base_export_manager. - Improve user instructions in README. - Require some required fields. - Allow to select models from a list. - Allow to select up to 3 fields from dynamic lists. - Improve translations. - More tests. - Translate column labels. Some methods have been renamed, so version tag is raised to 8.0.2.0.0. * Hardcode constraints in the `create` method instead of using normal ones. Depending on the context where the record is created, it gets `resource` or `model_id`. The problem is that Odoo checks constrains before inverses, so constrains would fail always. Test added to ensure future versions contemplate all use cases. * Allow to reorder fields.
…9 * Rename JS to base_export_manager
[FIX][base_export_manager] Fix "Expected singleton" bug.
If you had a field that got translated in more than 1 addon, you'd possibly getto this error:
File "/opt/odoo/0079_ahk_openerp/oca/base_export_manager/models/ir_exports_line.py", line 105, in _compute_label
field.name)),
File "/opt/odoo/common/openerp/v8/openerp/fields.py", line 825, in __get__
record.ensure_one()
File "/opt/odoo/common/openerp/v8/openerp/models.py", line 5355, in ensure_one
raise except_orm("ValueError", "Expected singleton: %s" % self)
except_orm: ('ValueError', 'Expected singleton: ir.translation(4899, 703976)')
With this patch, now we let Odoo return the translated string by using its
standard method to do so, so we have to care for less.
* Move installation outside a data file.
This makes the whole installation to be able to roll back if something goes
wrong, instead of entering an error loop.
* Include envorionment in its manager.
* Add 4th field
* Move to api.multi, refactoring some stuff.
- Add some comments in complex parts.
- Rename `onchange_name` to `_onchange_name` (guidelines).
- Make `_compute_name`'s try block shorter and easier to understand.
* Allow R/W of name directly in model.
* Update tests to cover new behaviors.
- Remove all possible translation commits - Aesthetical changes - Bump version - Some new standards, such as split readme Basically, nothing.
Currently translated at 80.0% (20 of 25 strings) Translation: server-ux-11.0/server-ux-11.0-base_export_manager Translate-URL: https://translation.odoo-community.org/projects/server-ux-11-0/server-ux-11-0-base_export_manager/da/
Updated by Update PO files to match POT (msgmerge) hook in Weblate.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-ux-12.0/server-ux-12.0-base_export_manager Translate-URL: https://translation.odoo-community.org/projects/server-ux-12-0/server-ux-12-0-base_export_manager/
Currently translated at 100.0% (31 of 31 strings) Translation: server-ux-12.0/server-ux-12.0-base_export_manager Translate-URL: https://translation.odoo-community.org/projects/server-ux-12-0/server-ux-12-0-base_export_manager/pt/
Currently translated at 100.0% (31 of 31 strings) Translation: server-ux-12.0/server-ux-12.0-base_export_manager Translate-URL: https://translation.odoo-community.org/projects/server-ux-12-0/server-ux-12-0-base_export_manager/zh_CN/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-ux-13.0/server-ux-13.0-base_export_manager Translate-URL: https://translation.odoo-community.org/projects/server-ux-13-0/server-ux-13-0-base_export_manager/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-ux-13.0/server-ux-13.0-base_export_manager Translate-URL: https://translation.odoo-community.org/projects/server-ux-13-0/server-ux-13-0-base_export_manager/
Currently translated at 100.0% (31 of 31 strings) Translation: server-ux-14.0/server-ux-14.0-base_export_manager Translate-URL: https://translation.odoo-community.org/projects/server-ux-14-0/server-ux-14-0-base_export_manager/es/
If not, we are not assigning the label value for the record and we get a missing cache value error.
WARNING odoo.fields: Redundant default on ir.exports.line.model1_id
rjpathan
force-pushed
the
16.0-mig-base_export_manager
branch
from
7b512d9
to
1f95963
Compare
|
Here's what I tried:
Did I miss something? V15 is working fine What is reproduced is similar to what was discussed in this issue #474. |
|
@kikopeiro sorry for late reply. Export action button is disabled with a javascript function https://github.com/rjpathan/server-ux/blob/16.0-mig-base_export_manager/base_export_manager/static/src/js/base_export_manager.js Sorry, I am not sure how to fix this as I don't have proficiency with the javascript. |
|
@hugosantosred Thanks for the fix. |
rjpathan
force-pushed
the
16.0-mig-base_export_manager
branch
from
45d3d2d
to
b1573b4
Compare
|
You're pre-commit problem is related with the list_controller.js file. Two possible solutions could be: Good Luck! |
kikopeiro
approved these changes
Jun 26, 2023
stefan-tecnativa
suggested changes
Aug 3, 2023
| @@ -142,8 +142,7 @@ def _inverse_name(self): | |||
| if any(parts): | |||
| # invalidate_cache -> in order to get actual value of field 'label' | |||
| # in function '_check_name' | |||
| self.invalidate_cache(ids=one.ids) | |||
| one._check_name() | |||
| self.env.invalidate_all() | |||
There was a problem hiding this comment.
self.browse(one.ids).invalidate_recordset()
one._check_name()
|
Superseded by #702 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.