Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIG][17.0] multi_step_wizard: Migration to 17.0 #797

Merged
merged 47 commits into from
Jul 19, 2024

Conversation

john-herholz-dt
Copy link

Only views adjusted according to changes with "attrs".

guewen and others added 30 commits January 9, 2024 09:56
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: server-ux-13.0/server-ux-13.0-multi_step_wizard
Translate-URL: https://translation.odoo-community.org/projects/server-ux-13-0/server-ux-13-0-multi_step_wizard/
Currently translated at 85.7% (12 of 14 strings)

Translation: server-ux-13.0/server-ux-13.0-multi_step_wizard
Translate-URL: https://translation.odoo-community.org/projects/server-ux-13-0/server-ux-13-0-multi_step_wizard/nl/
Currently translated at 100.0% (9 of 9 strings)

Translation: server-ux-14.0/server-ux-14.0-multi_step_wizard
Translate-URL: https://translation.odoo-community.org/projects/server-ux-14-0/server-ux-14-0-multi_step_wizard/ca/
weblate and others added 10 commits January 9, 2024 09:56
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: server-ux-16.0/server-ux-16.0-multi_step_wizard
Translate-URL: https://translation.odoo-community.org/projects/server-ux-16-0/server-ux-16-0-multi_step_wizard/
Currently translated at 100.0% (6 of 6 strings)

Translation: server-ux-16.0/server-ux-16.0-multi_step_wizard
Translate-URL: https://translation.odoo-community.org/projects/server-ux-16-0/server-ux-16-0-multi_step_wizard/de/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: server-ux-16.0/server-ux-16.0-multi_step_wizard
Translate-URL: https://translation.odoo-community.org/projects/server-ux-16-0/server-ux-16-0-multi_step_wizard/
Currently translated at 100.0% (6 of 6 strings)

Translation: server-ux-16.0/server-ux-16.0-multi_step_wizard
Translate-URL: https://translation.odoo-community.org/projects/server-ux-16-0/server-ux-16-0-multi_step_wizard/es/
Currently translated at 100.0% (6 of 6 strings)

Translation: server-ux-16.0/server-ux-16.0-multi_step_wizard
Translate-URL: https://translation.odoo-community.org/projects/server-ux-16-0/server-ux-16-0-multi_step_wizard/it/
@john-herholz-dt john-herholz-dt mentioned this pull request Jan 9, 2024
23 tasks
class="oe_inline"
placeholder="Name"/>
</h1>
<group name="configure" attrs="{'invisible': [('state', '!=', 'configure')]}">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<group name="configure" attrs="{'invisible': [('state', '!=', 'configure')]}">
<group name="configure" invisible="state != 'configure'">

I know it's not needed, but could you apply this kind of changes in all places of this file?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I oversaw this. I changed the docs accordingly.

Copy link
Contributor

@celm1990 celm1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SilvioC2C
Copy link

@john-herholz-dt hello, would you please run pre-commit and push the changes?

This module is a dependency of other OCA modules, whose PRs are failing because the setup/multi_step_wizard folder doesn't exist (so it's no use to add the module in test-requirements.txt).

@FernandoRomera
Copy link
Contributor

@MiquelRForgeFlow Could you merge this pr?. Thanks.

@MiquelRForgeFlow
Copy link
Contributor

@MiquelRForgeFlow Could you merge this pr?. Thanks.

I don't have merge rights, I am not a repo maintainer 🤷‍♂️

@LoisRForgeFlow
Copy link
Contributor

/ocabot migration multi_step_wizard

/ocabot merge nobump

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Jul 19, 2024
@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 17.0-ocabot-merge-pr-797-by-LoisRForgeFlow-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 68d9350 into OCA:17.0 Jul 19, 2024
4 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at f61510b. Thanks a lot for contributing to OCA. ❤️

@john-herholz-dt john-herholz-dt deleted the 17.0-mig-multi_step_wizard branch July 19, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.