[16.0][IMP] base_tier_validation: Change _compute_need_validation() #928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @LoisRForgeFlow, |
|
Would you consider adding a test to demonstrate what this effectively changes in the flow? |
AlexPForgeFlow
approved these changes
Sep 2, 2024
JasminSForgeFlow
force-pushed
the
16.0-imp-base_tier_validation-need_validation
branch
from
cbef7e5
to
0d650f2
Compare
|
Thanks for the update. Do I understand correctly that the commit message may be updated to say rather than new tier validations? |
|
This PR has the |
A document does not need validation only if there are no pending reviews, otherwise we should evaluate as True. We add a condition in request_validation to be able to request more than one time if there are new tier validations.
JasminSForgeFlow
force-pushed
the
16.0-imp-base_tier_validation-need_validation
branch
from
0d650f2
to
bfa3c38
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A document does not need validation only if there are no pending reviews, otherwise we should evaluate as True. We add a condition in request_validation to be able to request more than one time if there are new tier validations.