Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0][ADD] hr_shift: New module #8

Open
wants to merge 1 commit into
base: 14.0
Choose a base branch
from

Conversation

chienandalu
Copy link
Member

@chienandalu chienandalu commented Oct 16, 2024

A novel approach for employees shifts

This patch is needed for it to work:

Peek 16-10-2024 17-14

cc @Tecnativa TT50623

@pedrobaeza pedrobaeza added this to the 14.0 milestone Oct 16, 2024
@carmenbianca
Copy link
Member

@chienandalu Hi! This repository is the eventual (hopeful) new home of the shift modules at https://github.com/beescoop/Obeesdoo/tree/16.0. But the cleaning up and moving of those modules to the OCA has been delayed due to the bane of all projects—lack of time.

I have not yet reviewed the code submitted (but the gif looks very cool). My initial thought/observation is that there is a namespace collision for the module name shift.

Can you give me more context for the business need of this module? With this context, I can talk to the team at Coop IT Easy, and we can maybe cooperate on either (A.) finally cleaning up shift in the linked repository to fulfil both our needs, or (B.) migrating to your WIP module by merging functionalities from the linked repository.

Thanks!

@pedrobaeza
Copy link
Member

This one is a generic system for shifts. Yours is oriented just for cooperators, so I think it may be renamed to shift_cooperator or cooperator_shift when coming to OCA, don't you think?

@remytms
Copy link

remytms commented Oct 17, 2024

Yes our module is for managing shift for benevolent, yours is for employee. That's the difference. Managing benevolent or employee does not have the same constrain. But anyway, this module is very interesting.

@pedrobaeza
Copy link
Member

Yeah, and yours is thought for being each person who set their shift, and this one is for a manager to plan the shifts.

@chienandalu what about renaming this to hr_shift?

@chienandalu
Copy link
Member Author

@chienandalu what about renaming this to hr_shift?

I'm ok with it 😄

@pedrobaeza
Copy link
Member

Let's go with it then.

@chienandalu chienandalu changed the title [14.0][ADD] shift: New module [14.0][ADD] hr_shift: New module Oct 17, 2024
@carmenbianca carmenbianca marked this pull request as draft October 17, 2024 14:19
@carmenbianca
Copy link
Member

Fantastic. Please ping again when the module is ready for review :)

@chienandalu chienandalu force-pushed the 14.0-add-shift branch 5 times, most recently from f8b3c3b to 549f3ec Compare October 31, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants