[14.0][IMP] sign_oca: Link from partner to signer #19
Conversation
BernatPForgeFlow
force-pushed
the
14.0-sign_oca-partner_sign_request_link
branch
2 times, most recently
from
c7bc98d to
e38a013
Compare
BernatPForgeFlow
force-pushed
the
14.0-sign_oca-partner_sign_request_link
branch
from
e38a013 to
043f77c
Compare
sign_oca/views/res_partner_views.xml
Outdated
| name="action_show_signer_ids" | ||
| attrs="{'invisible': [('signer_count', '=', 0)]}" | ||
| icon="fa-pencil" | ||
| groups="sign_oca.sign_oca_group_user" |
There was a problem hiding this comment.
For this version, the groups should be put at view level, not element level, or you will have an error.
There was a problem hiding this comment.
I'm not sure if I understand what you mean. In version 14, groups can be added to buttons to not be shown. I have tested it and it works fine.
There was a problem hiding this comment.
As said, if you enter in this view without having the permissions, it will give an access error. Please put the group at view level, not element level. Something like:
<record id="view_partner_form" model="ir.ui.view">
<field name="name">res.partner.form (in sign_oca)</field>
<field name="model">res.partner</field>
<field name="inherit_id" ref="base.view_partner_form" />
<field name="groups_id" eval="[(4, ref('...')]" />
<field name="arch" type="xml">
<div name="button_box" position="inside">There was a problem hiding this comment.
I do not agree that it would give access error. However, I change it since it seems right to me anyway.
There was a problem hiding this comment.
If there are no access errors, it's because this model is readable for all users, but it's a good practice to do it this way because:
- It avoids needing to access the model without need.
- It avoids access errors when the model is not readable.
BernatPForgeFlow
force-pushed
the
14.0-sign_oca-partner_sign_request_link
branch
3 times, most recently
from
1dcb2b6 to
8ac1c42
Compare
|
Oh, wait, there are conflicts, so they should be resolved before merging. @BernatPForgeFlow would you? |
BernatPForgeFlow
force-pushed
the
14.0-sign_oca-partner_sign_request_link
branch
from
8ac1c42 to
2b8206a
Compare
@pedrobaeza Can you merge now? |
|
/ocabot merge minor @victoralmau to be cherry-pick in the v15 migration |
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at 6a80c06. Thanks a lot for contributing to OCA. ❤️ |
Depends on: #8