[17.0][MIG] mail_tracking: Migration to 17.0 #1367

chienandalu · 2024-05-14T13:14:02Z

Ongoing tasks:

Refactor webclient
Fix server logic
TODO: Add more reactivity

This migration is ready for review. 🎉

You could still find tiny issues regarding the reactivity of the components, mainly when we set a failed message as reviewed in the search failed panel or in Discuss. We'll work on that.
A deep refactor of the webclient code has been made in core and thus a complete refactor of the webclient side for mail_tracking was needed.
We've been splitting the funcionality in component that can be esasily used across the core components, so hopefully everything is more modular now.
We're sitting on top of some new core features as well. Like a message search component to filter the failed messages.
Also regular server logic stuff was necessary, although it wasn't needed such a deep refactor as in the client side. Note that the tests are almost untouched in this part.

cc @Tecnativa TT49060

pedrobaeza · 2024-05-14T13:50:46Z

/ocabot migration mail_tracking

pedrobaeza · 2024-05-14T13:53:05Z

Please squash a bit administrative commits.

* [ADD] mail_tracking addon * Add description icon * Fixes remarked * Fix Travis error * Remarks fixed

…ent events (OCA#82) [IMP] mail_tracking: Speed installation time, discard concurrent events and other fixes

* Improve tests * Show trackings even if partner removed * Disable CSRF protection to webhooks controllers

…s and contacts to bounce (OCA#133)

…oved (OCA#132)

As regular users can't access this object.

* [FIX] Only one data-odoo-tracking-email tag in each email * [FIX] Get status even in multicompany instances

The following changes were implemented: 1 - Added Failed Message component and related components to reuse the Message component when rendering failed messages. This allows us to dispose of the messagefailed JS model altogether, since failed messages are now just regular messages that were marked as failed. 2 - Added Owl reactivity to failed message actions so that browser does not have to be reloaded each time a message is marked as reviewed or resent. 3 - Fixed 'Retry' and 'Set as reviewed' flows for failed messages. 4 - Fixed `Failed sent messages` filter on models by overriding `get_view` instead of `_fields_view_get` 5 - Refactored folder structure to more closely resemble the `mail` module's folder structure. 6 - Refactored module to utilize `Command` as a means to create, write, etc. instead of `[0, ...]`, `[4, ...]`. 7 - Fixed and added unit tests. 8 - Removed dead/unused code from `v15`.

Currently translated at 100.0% (125 of 125 strings) Translation: social-16.0/social-16.0-mail_tracking Translate-URL: https://translation.odoo-community.org/projects/social-16-0/social-16-0-mail_tracking/es/

Currently translated at 27.2% (34 of 125 strings) Translation: social-16.0/social-16.0-mail_tracking Translate-URL: https://translation.odoo-community.org/projects/social-16-0/social-16-0-mail_tracking/it/

Currently translated at 82.4% (103 of 125 strings) Translation: social-16.0/social-16.0-mail_tracking Translate-URL: https://translation.odoo-community.org/projects/social-16-0/social-16-0-mail_tracking/pt_BR/

Currently translated at 29.8% (34 of 114 strings) Translation: social-15.0/social-15.0-mail_tracking Translate-URL: https://translation.odoo-community.org/projects/social-15-0/social-15-0-mail_tracking/it/

Currently translated at 100.0% (125 of 125 strings) Translation: social-16.0/social-16.0-mail_tracking Translate-URL: https://translation.odoo-community.org/projects/social-16-0/social-16-0-mail_tracking/fr/

mail_tracking/__manifest__.py

mail_tracking/controllers/mailbox.py

pedrobaeza · 2024-06-11T08:00:43Z

mail_tracking/static/description/icon.png

Great new icon! Did you do it? If not, please include the credits.

Thanks! 😄

Yes, I took the Odoo mass_mailing icon and a font-awesome glyph and playing with the blending mode in inkscape

TT49060

Some improvements/fixes detected in OCA#1367 and brought to `16.0`: - Add `mail_tracking_ids` to `_compute_is_failed_message` triggers. - Handle bounces to avoid flagging recipients which aren't bounced. - Add a logger.debug to research tracking issues - Make the links in the trackings respect the breadcrumb actions.

pedrobaeza · 2024-07-03T10:26:33Z

/ocabot merge nobump

OCA-git-bot · 2024-07-03T10:28:36Z

This PR looks fantastic, let's merge it!
Prepared branch 17.0-ocabot-merge-pr-1367-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot · 2024-07-03T10:38:27Z

Congratulations, your PR was merged at 2d458df. Thanks a lot for contributing to OCA. ❤️

Some improvements/fixes detected in OCA#1367 and brought to `16.0`: - Add `mail_tracking_ids` to `_compute_is_failed_message` triggers. - Handle bounces to avoid flagging recipients which aren't bounced. - Add a logger.debug to research tracking issues - Make the links in the trackings respect the breadcrumb actions.

OCA-git-bot added this to the 17.0 milestone May 14, 2024

OCA-git-bot mentioned this pull request May 14, 2024

Migration to version 17.0 #1251

Open

30 tasks

chienandalu force-pushed the 17.0-mig-mail_tracking branch 4 times, most recently from c462302 to 0f76cde Compare May 21, 2024 12:06

chienandalu force-pushed the 17.0-mig-mail_tracking branch 3 times, most recently from 872dea2 to ace8947 Compare May 23, 2024 08:16

chienandalu force-pushed the 17.0-mig-mail_tracking branch from ace8947 to 51a9d8f Compare May 30, 2024 11:51

antespi and others added 18 commits May 30, 2024 13:53

[8.0][ADD] mail_tracking addon (OCA#67)

dcf1274

* [ADD] mail_tracking addon * Add description icon * Fixes remarked * Fix Travis error * Remarks fixed

[8.0][IMP][mail_tracking] Speed installation time and discard concurr…

5c5ea35

…ent events (OCA#82) [IMP] mail_tracking: Speed installation time, discard concurrent events and other fixes

[FIX] Update email_score when email changes

e232d6c

[MIG] mail_tracking

80e3341

* Improve tests * Show trackings even if partner removed * Disable CSRF protection to webhooks controllers

[FIX] mail_tracking: Typo

741e6a9

[MIG] Make modules uninstallable

7d65c79

[MIG] mail_tracking: Migrated to 10.0

ae82c27

[IMP] mail_tracking performance and bounce process (OCA#103)

d607b97

[IMP] mail_tracking: Allow to define a custom mail_tracking base url

e0f73c7

Add access to portal/public user to his own email trackings

bb5432c

[8.0][FIX][mail_tracking] Use event recipient address to find partner…

a800927

…s and contacts to bounce (OCA#133)

[9.0][FIX][mail_tracking] Control exception when mail_message was rem…

b3fc8bd

…oved (OCA#132)

[FIX] Sender label is repeated in search fields

ad25c28

[FIX][9.0] partner buttons view on enterprise

ef03273

[FIX] mail_tracking: Obtain outgoing server with sudo

cd3302f

As regular users can't access this object.

[IMP] Shut mock exceptions up

62647eb

[9.0][IMP] mail_tracking: Improve view with error details

e413b11

[FIX] mail_tracking: bugfixes (OCA#199)

434d4b7

* [FIX] Only one data-odoo-tracking-email tag in each email * [FIX] Get status even in multicompany instances

filoquin and others added 12 commits June 11, 2024 09:51

[MIG] mail_tracking: Migration to 16.0

e0fee46

Translated using Weblate (Spanish)

41ccc41

Currently translated at 100.0% (125 of 125 strings) Translation: social-16.0/social-16.0-mail_tracking Translate-URL: https://translation.odoo-community.org/projects/social-16-0/social-16-0-mail_tracking/es/

[FIX] mail_tracking: validated mailbox when computing isInFailedDiscuss

c8e5ae9

Translated using Weblate (Italian)

175aadf

Currently translated at 27.2% (34 of 125 strings) Translation: social-16.0/social-16.0-mail_tracking Translate-URL: https://translation.odoo-community.org/projects/social-16-0/social-16-0-mail_tracking/it/

[16.0][FIX] mail_tracking debug mode error

ab323e5

Translated using Weblate (Portuguese (Brazil))

0c71ca5

Currently translated at 82.4% (103 of 125 strings) Translation: social-16.0/social-16.0-mail_tracking Translate-URL: https://translation.odoo-community.org/projects/social-16-0/social-16-0-mail_tracking/pt_BR/

Translated using Weblate (Italian)

0f139e6

Currently translated at 29.8% (34 of 114 strings) Translation: social-15.0/social-15.0-mail_tracking Translate-URL: https://translation.odoo-community.org/projects/social-15-0/social-15-0-mail_tracking/it/

Translated using Weblate (French)

c4addf4

Currently translated at 100.0% (125 of 125 strings) Translation: social-16.0/social-16.0-mail_tracking Translate-URL: https://translation.odoo-community.org/projects/social-16-0/social-16-0-mail_tracking/fr/

[IMP] mail_tracking: Give example that actually works in readme

b5fa425

[FIX] mail_tracking: be closer to what Odoo does in a nodb environment

b293ba5

[IMP] mail_tracking: pre-commit auto fixes

549006c

pedrobaeza force-pushed the 17.0-mig-mail_tracking branch from a59098b to 3ecb872 Compare June 11, 2024 07:57

pedrobaeza reviewed Jun 11, 2024

View reviewed changes

chienandalu force-pushed the 17.0-mig-mail_tracking branch from 3ecb872 to fec835d Compare June 11, 2024 08:05

[MIG] mail_tracking: Migration to 17.0

e981f3c

TT49060

pedrobaeza force-pushed the 17.0-mig-mail_tracking branch from fec835d to e981f3c Compare June 11, 2024 08:08

pedrobaeza approved these changes Jun 11, 2024

View reviewed changes

chienandalu mentioned this pull request Jul 1, 2024

[16.0][FIX] mail_tracking: bounces and others #1406

Merged

OCA-git-bot added the bot is merging ⏳ label Jul 3, 2024

OCA-git-bot merged commit fe54191 into OCA:17.0 Jul 3, 2024
5 of 7 checks passed

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Jul 3, 2024

pedrobaeza deleted the 17.0-mig-mail_tracking branch July 3, 2024 11:05

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[17.0][MIG] mail_tracking: Migration to 17.0 #1367

[17.0][MIG] mail_tracking: Migration to 17.0 #1367

chienandalu commented May 14, 2024 •

edited by pedrobaeza

Loading

pedrobaeza commented May 14, 2024

pedrobaeza commented May 14, 2024

pedrobaeza Jun 11, 2024

chienandalu Jun 11, 2024

pedrobaeza commented Jul 3, 2024

OCA-git-bot commented Jul 3, 2024

OCA-git-bot commented Jul 3, 2024

[17.0][MIG] mail_tracking: Migration to 17.0 #1367

[17.0][MIG] mail_tracking: Migration to 17.0 #1367

Conversation

chienandalu commented May 14, 2024 • edited by pedrobaeza Loading

pedrobaeza commented May 14, 2024

pedrobaeza commented May 14, 2024

pedrobaeza Jun 11, 2024

Choose a reason for hiding this comment

chienandalu Jun 11, 2024

Choose a reason for hiding this comment

pedrobaeza commented Jul 3, 2024

OCA-git-bot commented Jul 3, 2024

OCA-git-bot commented Jul 3, 2024

chienandalu commented May 14, 2024 •

edited by pedrobaeza

Loading